[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458922812 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ## @@ -337,6 +337,10 @@ trait CheckAnalysis extends P

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458922812 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ## @@ -337,6 +337,10 @@ trait CheckAnalysis extends P

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458916883 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -428,7 +428,7 @@ class DataFrameSetOperationsSuite exte

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458915813 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelation.scala ## @@ -50,7 +50,7 @@ object PropagateEmptyR

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458916665 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ## @@ -683,7 +683,7 @@ abstract class SparkStrategies extends

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458909616 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1387,7 +1388,7 @@ class Analyzer( i.copy(r

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458522170 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache So

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458369336 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ## @@ -220,8 +220,15 @@ object Union {

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458368672 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3676,3 +3678,63 @@ object UpdateOuterReferences ext

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458368303 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2085,37 +2084,9 @@ class Dataset[T] private[sql]( "in the right attr

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458365264 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3676,3 +3678,63 @@ object UpdateOuterReferences ext

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458359852 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnionSuite.scala ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apach

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r456742673 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ## @@ -337,6 +337,10 @@ trait CheckAnalysis extends P

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r456742634 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ## @@ -337,6 +337,10 @@ trait CheckAnalysis extends P

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r456714860 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -1099,6 +1101,64 @@ object TypeCoercion {

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r455521016 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -1099,6 +1101,64 @@ object TypeCoercion {

[GitHub] [spark] viirya commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

viirya commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r454848087 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -1099,6 +1101,64 @@ object TypeCoercion {