[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-149651576 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-149651536 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-149659771 **[Test build #1932 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1932/consoleFull)** for PR 9120 at commit

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-149657290 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-20 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9120#discussion_r42531738 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -171,17 +171,25 @@ object ExtractEquiJoinKeys extends

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-20 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9120#discussion_r42531676 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -850,6 +851,15 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-149657293 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-149691519 **[Test build #1932 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1932/consoleFull)** for PR 9120 at commit

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-19 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9120#discussion_r42433852 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -171,17 +171,25 @@ object ExtractEquiJoinKeys extends

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-19 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9120#discussion_r42434348 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/InnerJoinSuite.scala --- @@ -212,4 +212,20 @@ class InnerJoinSuite extends

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-19 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9120#discussion_r42435364 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -850,6 +851,15 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-19 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-149365386 Two small comments, otherwise LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148825207 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148825286 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148826611 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148827457 [Test build #43853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43853/consoleFull) for PR 9120 at commit

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148830759 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148830754 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148826592 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148857675 [Test build #43853 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43853/console) for PR 9120 at commit

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148857832 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148857830 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148184825 [Test build #43732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43732/consoleFull) for PR 9120 at commit

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148185559 Can we add a test that tests the query plan explicitly? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9120#discussion_r42049885 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -171,17 +172,24 @@ object ExtractEquiJoinKeys extends

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9120#discussion_r42048273 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -171,17 +172,24 @@ object ExtractEquiJoinKeys extends

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148194950 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148194787 [Test build #43732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43732/console) for PR 9120 at commit

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148182961 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148182936 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148194947 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/9120 [SPARK-1] [SQL] fast null-safe join Currently, we use CartesianProduct for join with null-safe-equal condition. ``` scala> sqlContext.sql("select * from t a join t b on (a.i <=>

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148218151 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148218181 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148219916 [Test build #43745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43745/consoleFull) for PR 9120 at commit

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148242727 [Test build #43745 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43745/console) for PR 9120 at commit

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148242828 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11111] [SQL] fast null-safe join

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9120#issuecomment-148242827 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your