Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49576209
QA results for PR 1440:br- This patch PASSES unit tests.brbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49576854
QA results for PR 1440:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49579030
Thanks! I've merged this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1440
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49572524
QA tests have started for PR 1440. This patch DID NOT merge cleanly!
brView progress:
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49572762
Rebased to the most recent master, generated all golden answer files after
setting timezone of my local machine to `America/Los_Angeles` and hardcoded the
timezone in
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49572803
QA tests have started for PR 1440. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16895/consoleFull
---
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1440#discussion_r15081630
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -93,6 +93,10 @@ class HiveCompatibilitySuite
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49154451
QA results for PR 1440:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49155576
Hmm, just realized `Timestamp.toString` normalizes date and time according
to current timezone and makes almost all timestamp related tests timezone
sensitive.
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1440#discussion_r14993202
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -249,3 +263,7 @@ case class Cast(child: Expression,
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49156553
Confirmed that the following test cases are timezone sensitive and
blacklisted them (by first remove all timestamp related golden answers, run
them in my local
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1440#discussion_r14993659
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -249,3 +263,7 @@ case class Cast(child: Expression,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49157381
QA tests have started for PR 1440. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16728/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49158865
QA tests have started for PR 1440. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16729/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49168910
QA results for PR 1440:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49171137
QA results for PR 1440:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1440#discussion_r15001961
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala ---
@@ -344,21 +344,52 @@ private[sql] class StringColumnStats extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1440#discussion_r15002400
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -93,6 +93,10 @@ class HiveCompatibilitySuite
Github user concretevitamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1440#discussion_r15018072
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala ---
@@ -344,21 +344,52 @@ private[sql] class StringColumnStats
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1440#discussion_r15020827
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala ---
@@ -344,21 +344,52 @@ private[sql] class StringColumnStats extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49238579
QA tests have started for PR 1440. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16749/consoleFull
---
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1440#discussion_r15035454
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -93,6 +93,10 @@ class HiveCompatibilitySuite
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1440#discussion_r15035556
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -93,6 +93,10 @@ class HiveCompatibilitySuite
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1440#issuecomment-49245732
QA results for PR 1440:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/1440#discussion_r15036800
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -93,6 +93,10 @@ class HiveCompatibilitySuite extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1440#discussion_r15038187
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -93,6 +93,10 @@ class HiveCompatibilitySuite
27 matches
Mail list logo
