Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9566#discussion_r44560836
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/AggregationQuerySuite.scala
---
@@ -545,19 +576,21 @@ abstract class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9566#discussion_r44514711
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/AggregationQuerySuite.scala
---
@@ -545,19 +576,21 @@ abstract class
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155535411
https://github.com/apache/spark/pull/9556 is in. Let's rebase this one.
Also, can you explain more about the potential bug? So, it will be easier for a
reader to get the
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155578114
I'll rebase.
The potential bug is caused by the fact that the attributes for the
distinct columns and the expressions for the distinct columns can possibly
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155583057
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9566#discussion_r44472817
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DistinctAggregationRewriter.scala
---
@@ -151,11 +151,12 @@ case class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155583331
**[Test build #45558 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45558/consoleFull)**
for PR 9566 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155611424
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155611425
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155611685
Thanks! Merging to master and branch 1.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9566#discussion_r44479350
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/AggregationQuerySuite.scala
---
@@ -545,19 +576,21 @@ abstract class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155611304
**[Test build #45558 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45558/consoleFull)**
for PR 9566 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155583018
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9566
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155595668
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155072686
**[Test build #45361 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45361/consoleFull)**
for PR 9566 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155073211
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/9566
[SPARK-9241][SQL] Supporting multiple DISTINCT columns - follow-up (3)
This PR is a 2nd follow-up for
[SPARK-9241](https://issues.apache.org/jira/browse/SPARK-9241). It contains the
following
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155042934
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155042838
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9566#issuecomment-155044754
**[Test build #45361 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45361/consoleFull)**
for PR 9566 at commit
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/9541
[SPARK-9241][SQL] Supporting multiple DISTINCT columns - follow-up
This PR is a follow up for PR https://github.com/apache/spark/pull/9406. It
adds more documentation to the rewriting rule,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154715366
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154716428
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154716423
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154716268
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154716913
**[Test build #45284 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45284/consoleFull)**
for PR 9541 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154722400
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154723564
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154723585
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154742112
**[Test build #45288 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45288/consoleFull)**
for PR 9541 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154742161
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154753581
LGTM. Merging to master and 1.6 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9541
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154723430
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154723404
Funny build failure:
Build was aborted
Aborted by anonymous
ERROR: Step ?Archive the artifacts? failed: no workspace for
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9541#issuecomment-154724539
**[Test build #45288 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45288/consoleFull)**
for PR 9541 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9406#discussion_r44203475
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Utils.scala
---
@@ -213,3 +216,178 @@ object Utils {
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9406#discussion_r44198936
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Utils.scala
---
@@ -213,3 +216,178 @@ object Utils {
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9406#discussion_r44203629
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Utils.scala
---
@@ -213,3 +216,178 @@ object Utils {
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9406#discussion_r44203639
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Utils.scala
---
@@ -213,3 +216,178 @@ object Utils {
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9406#discussion_r44199322
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Utils.scala
---
@@ -213,3 +216,178 @@ object Utils {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9406
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154581656
Okay, I looked over this pretty quickly and it looks awesome. We need some
tests and we are super close to me cutting a preview release. That said, I'd
really like
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9406#discussion_r44207772
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Utils.scala
---
@@ -213,3 +216,178 @@ object Utils {
case
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154342399
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154368700
H... this is a bit of a strange error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154368715
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154369474
Jenkins is not retesting... @marmbrus could you add me to the whitelist?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154371130
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154371145
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154372363
**[Test build #45219 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45219/consoleFull)**
for PR 9406 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154352105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154352102
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154352052
**[Test build #45207 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45207/consoleFull)**
for PR 9406 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154398778
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154398663
**[Test build #45219 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45219/consoleFull)**
for PR 9406 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-154398776
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-153774702
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-153774767
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-153777154
**[Test build #45019 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45019/consoleFull)**
for PR 9406 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-153810427
**[Test build #45019 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45019/consoleFull)**
for PR 9406 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-153810518
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-153810523
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-153323369
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-153323375
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-153323299
**[Test build #44915 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44915/consoleFull)**
for PR 9406 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-153313342
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-153313304
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-153312928
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-153315138
**[Test build #44915 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44915/consoleFull)**
for PR 9406 at commit
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/9406
[SPARK-9241][SQL] Supporting multiple DISTINCT columns (2) - Rewriting Rule
The second PR for SPARK-9241, this adds support for multiple distinct
columns to the new aggregation code path.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9406#issuecomment-152973657
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
73 matches
Mail list logo
