Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-49837566
QA tests have started for PR 993. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17019/consoleFull
---
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-49912228
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user concretevitamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r15311508
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateProjection.scala
---
@@ -0,0 +1,218 @@
+/*
+
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r15321958
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -33,6 +33,13 @@ abstract class DataType {
case
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-49776325
QA tests have started for PR 993. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16976/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-48697796
QA tests have started for PR 993. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16557/consoleFull
---
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r14845258
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -0,0 +1,421 @@
+/*
+ *
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r14845309
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -0,0 +1,421 @@
+/*
+ *
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r14846043
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -0,0 +1,421 @@
+/*
+ *
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r14846216
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -0,0 +1,421 @@
+/*
+ *
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r14847035
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -0,0 +1,421 @@
+/*
+ *
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r14848366
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -0,0 +1,421 @@
+/*
+ *
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r14849312
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -0,0 +1,83 @@
+/*
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-48433215
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-48433227
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-48433291
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16447/
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-48433290
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-48434077
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-48434083
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-48434137
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-48434138
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16448/
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-48437951
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-48437961
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-48438100
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16450/
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-45585458
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13634526
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -72,7 +72,9 @@ abstract class RuleExecutor[TreeType :
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13634545
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -72,7 +72,9 @@ abstract class RuleExecutor[TreeType :
GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/993
[WIP][SPARK-2054][SQL] Code Generation for Expression Evaluation
This PR drops the aggregation code generation, which will be added back in
a follow-up PR. The following remains to be done:
-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-45305818
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-45306506
One more to do is maven build ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user concretevitamin commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-45307236
Another TODO might be to beef up IN's code gen semantics (recall NULL in
NULL and the alike cases).
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-45311891
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13479600
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
@@ -48,14 +48,19 @@ class Projection(expressions:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-45311970
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-45311971
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15499/
---
If your project is set up for it, you can
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13479648
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -23,6 +23,16 @@ import
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13479655
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -23,6 +23,16 @@ import
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13479686
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -72,7 +72,9 @@ abstract class RuleExecutor[TreeType :
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13479742
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -72,6 +79,13 @@ abstract class NumericType extends NativeType {
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13479735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -33,6 +33,13 @@ abstract class DataType {
case
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13479764
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -72,6 +79,13 @@ abstract class NumericType extends NativeType {
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13479850
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregates.scala ---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13479917
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/AnonymousRowSuite.scala ---
@@ -0,0 +1,32 @@
+package org.apache.spark.sql.catalyst.expressions
+
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13480009
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/GeneratedRow.scala
---
@@ -0,0 +1,833 @@
+/*
+ * Licensed to the Apache
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13480043
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/GeneratedRow.scala
---
@@ -0,0 +1,833 @@
+/*
+ * Licensed to the Apache
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13480098
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/GeneratedRow.scala
---
@@ -0,0 +1,833 @@
+/*
+ * Licensed to the Apache
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13480084
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/GeneratedRow.scala
---
@@ -0,0 +1,833 @@
+/*
--- End diff --
Github user hsaputra commented on the pull request:
https://github.com/apache/spark/pull/993#issuecomment-45349273
HI @marmbrus, one generic comment, could you add object or class header
comment to describe why each of them needed and the context why they are used.
It should be very
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13495163
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/GeneratedRow.scala
---
@@ -0,0 +1,833 @@
+/*
+ * Licensed to the
49 matches
Mail list logo
