[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r24061275 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala --- @@ -459,7 +461,41 @@ class LogisticRegressionSuite

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r24060903 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -17,14 +17,17 @@ package

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72787496 [Test build #26719 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26719/consoleFull) for PR 4233 at commit

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72787523 That last commit did significant re-organization and cleanups to address @mengxr 's comments. Hopefully good to go now! I won't put any more models in this PR. ---

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r24052353 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -17,14 +17,17 @@ package

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r24052532 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala --- @@ -65,6 +67,70 @@ class NaiveBayesModel private[mllib] (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r24054409 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala --- @@ -425,25 +427,25 @@ class LogisticRegressionSuite

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r24054690 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala --- @@ -65,6 +67,70 @@ class NaiveBayesModel private[mllib] (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r24054729 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala --- @@ -425,25 +427,25 @@ class LogisticRegressionSuite

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r24055623 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala --- @@ -459,7 +461,41 @@ class LogisticRegressionSuite

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r24054410 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala --- @@ -459,7 +461,41 @@ class LogisticRegressionSuite

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r24054680 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -17,14 +17,17 @@ package

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r24054795 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala --- @@ -459,7 +461,41 @@ class LogisticRegressionSuite

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-03 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r24055819 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -17,14 +17,17 @@ package

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23976586 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-02 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72588869 Rebased after logreg changes...but I need to fix loading still. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72580348 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72580345 [Test build #26579 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26579/consoleFull) for PR 4233 at commit

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72580736 [Test build #26580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26580/consoleFull) for PR 4233 at commit

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72580738 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72580650 [Test build #26580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26580/consoleFull) for PR 4233 at commit

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72589061 [Test build #26600 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26600/consoleFull) for PR 4233 at commit

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72580164 [Test build #26579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26579/consoleFull) for PR 4233 at commit

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72592729 [Test build #26600 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26600/consoleFull) for PR 4233 at commit

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72592738 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-01 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23903668 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-01 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23903673 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-01 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23903677 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23906177 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-01 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23904506 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-01 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23909199 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-01 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23909298 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-02-01 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23910101 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23887814 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23887815 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23887813 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23887816 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-31 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r23888056 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -68,6 +79,65 @@ class LogisticRegressionModel (

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72313229 [Test build #26459 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26459/consoleFull) for PR 4233 at commit

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72313232 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72311863 [Test build #26459 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26459/consoleFull) for PR 4233 at commit

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72278551 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72278541 [Test build #26427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26427/consoleFull) for PR 4233 at commit

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-72269096 [Test build #26427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26427/consoleFull) for PR 4233 at commit

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-27 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/4233 [WIP] [SPARK-4587] [mllib] ML model import/export This is a WIP PR for Parquet-based model import/export. Please see the design doc on [the

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-71741610 [Test build #26190 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26190/consoleFull) for PR 4233 at commit

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-71752235 [Test build #26190 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26190/consoleFull) for PR 4233 at commit

[GitHub] spark pull request: [WIP] [SPARK-4587] [mllib] ML model import/exp...

2015-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4233#issuecomment-71752240 Test PASSed. Refer to this link for build results (access rights to CI server needed):