Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15139#discussion_r79716511
--- Diff: R/pkg/R/mllib.R ---
@@ -1398,20 +1398,22 @@ setMethod("summary", signature(object = "KSTest"),
distParams <-
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15139#discussion_r79614619
--- Diff: R/pkg/R/mllib.R ---
@@ -1398,20 +1398,22 @@ setMethod("summary", signature(object = "KSTest"),
distParams <-
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15139#discussion_r79611427
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -760,13 +760,7 @@ test_that("spark.kstest", {
expect_equal(stats$p.value,
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15139#discussion_r79355286
--- Diff: R/pkg/R/mllib.R ---
@@ -1398,20 +1398,22 @@ setMethod("summary", signature(object = "KSTest"),
distParams <-
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15139#discussion_r79355382
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -760,13 +760,7 @@ test_that("spark.kstest", {
expect_equal(stats$p.value,
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15139#discussion_r79303509
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -761,27 +761,13 @@ test_that("spark.kstest", {
expect_equal(stats$p.value, rStats$p.value,
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15139#discussion_r79303349
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -761,27 +761,13 @@ test_that("spark.kstest", {
expect_equal(stats$p.value, rStats$p.value,
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15139#discussion_r79303313
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -761,27 +761,13 @@ test_that("spark.kstest", {
expect_equal(stats$p.value, rStats$p.value,
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/15139
[SPARK-17315][Follow-up][SparkR][ML] Fix print of Kolmogorov-Smirnov test
summary
## What changes were proposed in this pull request?
#14881 added Kolmogorov-Smirnov Test wrapper to SparkR.
10 matches
Mail list logo
