Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15484
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r86688702
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -229,10 +235,14 @@ class Analyzer(
*
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r86688650
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -216,10 +216,16 @@ class Analyzer(
*
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r86075526
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -229,10 +235,14 @@ class Analyzer(
* Group
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r86075344
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -229,10 +235,14 @@ class Analyzer(
* Group
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r86075252
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -216,10 +216,16 @@ class Analyzer(
* Group
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84589691
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -216,10 +216,16 @@ class Analyzer(
*
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84585794
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -255,98 +265,125 @@ class Analyzer(
expr
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84585577
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -216,10 +216,16 @@ class Analyzer(
*
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84585881
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -255,98 +265,125 @@ class Analyzer(
expr
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84583794
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -255,98 +265,125 @@ class Analyzer(
expr
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84577307
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -518,59 +517,58 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84005447
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -281,9 +294,11 @@ class Analyzer(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84006017
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -488,23 +488,13 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84003737
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -229,10 +235,17 @@ class Analyzer(
* Group
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84012469
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -518,59 +517,64 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84007872
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -488,23 +488,13 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84001582
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -216,10 +216,16 @@ class Analyzer(
* Group
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84003200
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -229,10 +235,17 @@ class Analyzer(
* Group
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84003714
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -229,10 +235,17 @@ class Analyzer(
* Group
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r83426871
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveGroupingAnalyticsSuite.scala
---
@@ -0,0 +1,244 @@
+/*
+ *
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r83426422
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -335,13 +366,16 @@ class Analyzer(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r83425845
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -488,23 +488,13 @@ class AstBuilder extends
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/15484
[SPARK-17868][SQL] Do not use bitmasks during parsing and analysis of
CUBE/ROLLUP/GROUPING SETS
## What changes were proposed in this pull request?
We generate bitmasks for grouping
24 matches
Mail list logo