[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15532 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15532#discussion_r84007392 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -124,7 +124,13 @@ case class SortArray(base:

[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15532#discussion_r84004834 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -124,7 +124,15 @@ case class

[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15532#discussion_r84004551 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -124,7 +124,15 @@ case class SortArray(base:

[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15532#discussion_r84004506 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -124,7 +124,15 @@ case class SortArray(base:

[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15532#discussion_r84004457 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -124,7 +124,15 @@ case class SortArray(base:

[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15532#discussion_r84004431 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -124,7 +124,15 @@ case class SortArray(base:

[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15532#discussion_r84004039 --- Diff: sql/core/src/test/resources/sql-tests/results/array.sql.out --- @@ -124,8 +124,23 @@ struct

[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15532#discussion_r84003975 --- Diff: sql/core/src/test/resources/sql-tests/results/array.sql.out --- @@ -124,8 +124,23 @@ struct

[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15532#discussion_r84001844 --- Diff: sql/core/src/test/resources/sql-tests/inputs/array.sql --- @@ -71,6 +71,10 @@ select sort_array(timestamp_array) from

[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15532#discussion_r84001226 --- Diff: sql/core/src/test/resources/sql-tests/inputs/array.sql --- @@ -71,6 +71,10 @@ select sort_array(timestamp_array) from primitive_arrays;

[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15532#discussion_r83930227 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -124,7 +124,14 @@ case class SortArray(base:

[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15532#discussion_r83927813 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -124,7 +124,14 @@ case class

[GitHub] spark pull request #15532: [SPARK-17989][SQL] Check ascendingOrder type in s...

GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/15532 [SPARK-17989][SQL] Check ascendingOrder type in sort_array function ahead ## What changes were proposed in this pull request? This PR proposes to check the second argument,