[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2017-02-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16387 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2017-01-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16387#discussion_r97034867 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -192,12 +193,16 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2017-01-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16387#discussion_r96698376 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -192,12 +193,16 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2017-01-18 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16387#discussion_r96634742 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -192,12 +193,16 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16387#discussion_r95528463 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -192,12 +193,16 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16387#discussion_r95527814 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -192,12 +193,16 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2017-01-10 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16387#discussion_r95505432 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -192,12 +193,16 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2017-01-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16387#discussion_r95501216 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -192,12 +193,16 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2017-01-10 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16387#discussion_r95458142 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -192,12 +193,16 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2017-01-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16387#discussion_r95048733 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -115,6 +115,7 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2017-01-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16387#discussion_r95044381 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -115,6 +115,7 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2016-12-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16387#discussion_r93732158 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -192,12 +193,16 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2016-12-22 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/16387 [SPARK-18986][Core] ExternalAppendOnlyMap shouldn't fail when forced to spill before calling its iterator ## What changes were proposed in this pull request?