Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16729
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r105590741
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -67,17 +54,20 @@ tweedie <- function(var.power = 0.0, link.power = 1.0 -
var.power) {
#'
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r105576051
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -100,6 +120,12 @@ setMethod("spark.glm", signature(data =
"SparkDataFrame", formula = "formula"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r105566816
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -700,12 +702,13 @@ head(select(gaussianFitted, "model", "prediction",
"mpg", "wt", "hp"))
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r105567733
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -100,6 +120,12 @@ setMethod("spark.glm", signature(data =
"SparkDataFrame", formula = "formula"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r105567744
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -84,14 +93,25 @@ setClass("IsotonicRegressionModel", representation(jobj
= "jobj"))
#' # can also read
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r105567727
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -84,14 +93,25 @@ setClass("IsotonicRegressionModel", representation(jobj
= "jobj"))
#' # can also read
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r105567664
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -100,6 +120,12 @@ setMethod("spark.glm", signature(data =
"SparkDataFrame", formula = "formula"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r105566855
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -67,17 +54,20 @@ tweedie <- function(var.power = 0.0, link.power = 1.0 -
var.power) {
#'
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98760363
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -53,12 +53,19 @@ setClass("IsotonicRegressionModel", representation(jobj
= "jobj"))
#'
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98363560
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/r/GeneralizedLinearRegressionWrapper.scala
---
@@ -143,7 +150,12 @@ private[r] object
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98363550
--- Diff: R/pkg/inst/tests/testthat/test_mllib_regression.R ---
@@ -77,6 +77,18 @@ test_that("spark.glm and predict", {
out <-
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98341289
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/r/GeneralizedLinearRegressionWrapper.scala
---
@@ -143,7 +150,12 @@ private[r] object
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98341193
--- Diff: R/pkg/inst/tests/testthat/test_mllib_regression.R ---
@@ -77,6 +77,18 @@ test_that("spark.glm and predict", {
out <-
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98341050
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/r/GeneralizedLinearRegressionWrapper.scala
---
@@ -81,15 +83,20 @@ private[r] object
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98341028
--- Diff: R/pkg/inst/tests/testthat/test_mllib_regression.R ---
@@ -77,6 +77,18 @@ test_that("spark.glm and predict", {
out <-
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98341000
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -109,7 +125,8 @@ setMethod("spark.glm", signature(data =
"SparkDataFrame", formula = "formula"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98340946
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -84,6 +84,12 @@ setClass("IsotonicRegressionModel", representation(jobj
= "jobj"))
#' # can also read
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98340892
--- Diff: R/pkg/inst/tests/testthat/test_mllib_regression.R ---
@@ -77,6 +77,18 @@ test_that("spark.glm and predict", {
out <-
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98340879
--- Diff: R/pkg/R/mllib_regression.R ---
@@ -84,6 +84,12 @@ setClass("IsotonicRegressionModel", representation(jobj
= "jobj"))
#' # can also read
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16729#discussion_r98340835
--- Diff: R/pkg/inst/tests/testthat/test_mllib_regression.R ---
@@ -77,6 +77,18 @@ test_that("spark.glm and predict", {
out <-
GitHub user actuaryzhang opened a pull request:
https://github.com/apache/spark/pull/16729
[SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR
## What changes were proposed in this pull request?
Port Tweedie GLM #16344 to SparkR
@felixcheung @yanboliang
##
22 matches
Mail list logo
