[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16793 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-03-07 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/16793#discussion_r104810137 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1307,43 +1309,75 @@ def replace(self, to_replace, value, subset=None): |null| null|null|

[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-03-06 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16793#discussion_r104452225 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1307,43 +1309,75 @@ def replace(self, to_replace, value, subset=None): |null| null|null|

[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-03-06 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16793#discussion_r104451583 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1307,43 +1309,75 @@ def replace(self, to_replace, value, subset=None): |null| null|null|

[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-03-06 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16793#discussion_r103533408 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1307,43 +1309,75 @@ def replace(self, to_replace, value, subset=None): |null| null|null|

[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-02-25 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16793#discussion_r103089544 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1307,43 +1307,66 @@ def replace(self, to_replace, value, subset=None): |null| null|null|

[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-02-25 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16793#discussion_r103089653 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1307,43 +1307,66 @@ def replace(self, to_replace, value, subset=None): |null| null|null|

[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-02-25 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16793#discussion_r103089704 --- Diff: python/pyspark/sql/tests.py --- @@ -1591,6 +1591,67 @@ def test_replace(self): self.assertEqual(row.age, 10)

[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-02-12 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/16793#discussion_r100704329 --- Diff: python/pyspark/sql/tests.py --- @@ -1591,6 +1591,67 @@ def test_replace(self): self.assertEqual(row.age, 10)

[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-02-12 Thread nchammas
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/16793#discussion_r100701818 --- Diff: python/pyspark/sql/tests.py --- @@ -1591,6 +1591,67 @@ def test_replace(self): self.assertEqual(row.age, 10)

[GitHub] spark pull request #16793: [SPARK-19454][PYTHON][SQL] DataFrame.replace impr...

2017-02-03 Thread zero323
GitHub user zero323 opened a pull request: https://github.com/apache/spark/pull/16793 [SPARK-19454][PYTHON][SQL] DataFrame.replace improvements ## What changes were proposed in this pull request? - Allows skipping `value` argument if `to_replace` is a `dict`: