[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-03-06 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r104531080 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,411 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-03-06 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r104527025 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,411 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-03-06 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r104526789 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,411 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-03-03 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r104257144 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala --- @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-28 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103564577 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103057183 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103056768 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103056297 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103056078 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103043531 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -152,6 +157,56 @@ private[kafka010] class

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103039701 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103043927 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103033329 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -346,5 +346,5 @@ private[kafka010] object KafkaSource

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103045028 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103044512 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103044371 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103053838 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103044757 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103052449 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103053432 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103043738 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -377,10 +432,11 @@ private[kafka010] class

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103039931 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -152,6 +157,56 @@ private[kafka010] class

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103043568 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -152,6 +157,56 @@ private[kafka010] class

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103046651 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103033150 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103053768 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103033292 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103039812 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103053627 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103050112 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103054126 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103047334 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -152,6 +157,56 @@ private[kafka010] class

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103053743 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103049620 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103049550 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103044313 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103049353 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103053544 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -152,6 +157,56 @@ private[kafka010] class

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103045768 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -377,10 +432,11 @@ private[kafka010] class

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103050085 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103052166 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103053368 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103048542 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103054866 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103053285 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103054142 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103054319 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103053352 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103044379 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103048422 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103050143 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed to the

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103047462 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -152,6 +157,56 @@ private[kafka010] class

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-24 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r103046697 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -152,6 +157,56 @@ private[kafka010] class

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102846556 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102843676 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102843999 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102844522 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102831977 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -152,6 +154,51 @@ private[kafka010] class

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102844431 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102844572 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102832117 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -381,6 +428,7 @@ private[kafka010] object

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102835744 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -152,6 +154,51 @@ private[kafka010] class

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102840031 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102836149 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102843797 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102832015 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -152,6 +154,51 @@ private[kafka010] class

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102836317 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102839754 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102831400 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -23,21 +23,23 @@ import java.util.UUID

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-02-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r102831274 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala --- @@ -346,5 +346,4 @@ private[kafka010] object KafkaSource