Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19239
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139259901
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
GitHub user joseph-torres reopened a pull request:
https://github.com/apache/spark/pull/19239
[SPARK-22017] Take minimum of all watermark execs in StreamExecution.
## What changes were proposed in this pull request?
Take the minimum of all watermark exec nodes as the "real"
Github user joseph-torres closed the pull request at:
https://github.com/apache/spark/pull/19239
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139077988
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,85 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139077656
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,85 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139076625
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -560,13 +567,25 @@ class StreamExecution(
}
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139070352
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -560,13 +567,25 @@ class StreamExecution(
}
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139070245
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -560,13 +567,25 @@ class StreamExecution(
}
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139070184
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -560,13 +567,25 @@ class StreamExecution(
}
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139070141
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -560,13 +567,25 @@ class StreamExecution(
}
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139069900
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -560,13 +567,24 @@ class StreamExecution(
}
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139069662
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -130,6 +130,13 @@ class StreamExecution(
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139036524
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139036217
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139036315
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139035990
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139035867
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139034057
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -130,6 +130,13 @@ class StreamExecution(
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139033482
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139033208
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139029401
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -560,13 +567,24 @@ class StreamExecution(
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139029187
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -130,6 +130,13 @@ class StreamExecution(
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139028613
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139026379
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139026066
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -300,6 +300,67 @@ class EventTimeWatermarkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139025952
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -560,13 +567,24 @@ class StreamExecution(
}
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139025814
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -130,6 +130,13 @@ class StreamExecution(
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139025554
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala
---
@@ -39,7 +39,7 @@ class IncrementalExecution(
GitHub user joseph-torres opened a pull request:
https://github.com/apache/spark/pull/19239
[SPARK-22017] Take minimum of all watermark execs in StreamExecution.
## What changes were proposed in this pull request?
Take the minimum of all watermark exec nodes as the "real"
30 matches
Mail list logo
