Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20786
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r178202438
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,85 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r178202596
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,85 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r178204351
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,85 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r178202260
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,73 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r178202685
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,85 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r178204775
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -17,9 +17,11 @@
package org.apache.spark.ml.tree
+import
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r178202528
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,85 @@ private[ml] object Node {
/**
* Create a new
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175970711
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,73 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175957326
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,73 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175959353
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala ---
@@ -212,15 +212,13 @@ private[ml] object TreeEnsembleModel {
def
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175957767
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -135,32 +175,59 @@ class LeafNode private[ml] (
override
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175955388
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,73 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175958393
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -240,6 +302,69 @@ private object InternalNode {
}
}
+/**
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175957538
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,73 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175957188
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,73 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175959372
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala ---
@@ -306,17 +304,21 @@ private[ml] object DecisionTreeModelReadWrite {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175957487
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,73 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175957245
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,73 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175956585
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -276,8 +276,9 @@ object
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175957437
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,73 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175955065
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,73 @@ private[ml] object Node {
/**
* Create a new
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r174921341
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,73 @@ private[ml] object Node {
/**
* Create a new
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/20786
[SPARK-14681][ML] Provide label/impurity stats for spark.ml decision tree
nodes
## What changes were proposed in this pull request?
API:
```
trait ClassificationNode extends
24 matches
Mail list logo
