Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21082
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r194133638
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -424,6 +424,21 @@ abstract class SparkStrategies extends
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r194133573
--- Diff: python/pyspark/worker.py ---
@@ -128,6 +128,17 @@ def wrapped(*series):
return lambda *a: (wrapped(*a), arrow_return_type)
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r194130366
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/PythonUDF.scala
---
@@ -34,7 +34,12 @@ object PythonUDF {
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r194129021
--- Diff: python/pyspark/sql/tests.py ---
@@ -5181,6 +5190,235 @@ def test_invalid_args(self):
'mixture.*aggregate
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r193327794
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r193326454
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -268,3 +269,40 @@ object PhysicalAggregation {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r193323738
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -297,6 +297,37 @@ trait WindowFunction
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r193323414
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -424,6 +424,21 @@ abstract class SparkStrategies extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r193320743
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/PythonUDF.scala
---
@@ -34,7 +34,12 @@ object PythonUDF {
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r192182678
--- Diff: python/pyspark/worker.py ---
@@ -128,6 +128,17 @@ def wrapped(*series):
return lambda *a: (wrapped(*a), arrow_return_type)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r192151282
--- Diff: python/pyspark/worker.py ---
@@ -128,6 +128,17 @@ def wrapped(*series):
return lambda *a: (wrapped(*a), arrow_return_type)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r192150984
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/PythonUDF.scala
---
@@ -34,7 +34,12 @@ object PythonUDF {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r192146812
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -112,12 +113,19 @@ trait CheckAnalysis extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r192146449
--- Diff: python/pyspark/worker.py ---
@@ -128,6 +128,17 @@ def wrapped(*series):
return lambda *a: (wrapped(*a), arrow_return_type)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r192142018
--- Diff: python/pyspark/sql/tests.py ---
@@ -5181,6 +5190,235 @@ def test_invalid_args(self):
'mixture.*aggregate
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r192140997
--- Diff: python/pyspark/sql/tests.py ---
@@ -5181,6 +5190,235 @@ def test_invalid_args(self):
'mixture.*aggregate
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r192138739
--- Diff: python/pyspark/sql/functions.py ---
@@ -2321,7 +2323,30 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
| 2|
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r191801865
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r191740985
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r190633480
--- Diff: python/pyspark/sql/functions.py ---
@@ -2301,10 +2301,12 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
The
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r190340070
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1869,6 +1870,8 @@ class Analyzer(
case
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r190334520
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1869,6 +1870,8 @@ class Analyzer(
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r190242582
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1869,6 +1870,8 @@ class Analyzer(
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r190177055
--- Diff: python/pyspark/sql/tests.py ---
@@ -5181,6 +5190,235 @@ def test_invalid_args(self):
'mixture.*aggregate function.*group
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r190176898
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1869,6 +1870,8 @@ class Analyzer(
case
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r190065854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -268,3 +269,38 @@ object PhysicalAggregation {
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r190061061
--- Diff: python/pyspark/sql/tests.py ---
@@ -5181,6 +5190,235 @@ def test_invalid_args(self):
'mixture.*aggregate
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r190060687
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -268,3 +269,38 @@ object PhysicalAggregation {
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r190060086
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1869,6 +1870,8 @@ class Analyzer(
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r189161794
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1869,6 +1870,8 @@ class Analyzer(
case
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r189198335
--- Diff: python/pyspark/sql/tests.py ---
@@ -5181,6 +5190,235 @@ def test_invalid_args(self):
'mixture.*aggregate function.*group
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r189216703
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -268,3 +269,38 @@ object PhysicalAggregation {
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r187663449
--- Diff: python/pyspark/worker.py ---
@@ -128,6 +128,17 @@ def wrapped(*series):
return lambda *a: (wrapped(*a), arrow_return_type)
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r187479626
--- Diff: python/pyspark/worker.py ---
@@ -128,6 +128,17 @@ def wrapped(*series):
return lambda *a: (wrapped(*a), arrow_return_type)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r185423199
--- Diff: python/pyspark/sql/functions.py ---
@@ -2301,10 +2301,12 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
The
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r185339976
--- Diff: python/pyspark/sql/functions.py ---
@@ -2301,10 +2301,12 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
The
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r184875393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -268,3 +269,38 @@ object PhysicalAggregation {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r184875163
--- Diff: python/pyspark/sql/tests.py ---
@@ -5181,6 +5190,236 @@ def test_invalid_args(self):
'mixture.*aggregate
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r184875140
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r184875120
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r184875102
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r184875086
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r184875053
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -424,6 +424,21 @@ abstract class SparkStrategies extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r184875039
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -624,7 +624,9 @@ object CollapseRepartition
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r184875000
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -112,12 +113,19 @@ trait CheckAnalysis extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r184874826
--- Diff: python/pyspark/sql/functions.py ---
@@ -2301,10 +2301,12 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
The
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r183769433
--- Diff: python/pyspark/sql/functions.py ---
@@ -2321,7 +2323,30 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
| 2|
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r183768758
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -268,3 +269,38 @@ object PhysicalAggregation {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r183572930
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -268,3 +269,38 @@ object PhysicalAggregation {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r183416353
--- Diff: python/pyspark/sql/functions.py ---
@@ -2321,7 +2323,30 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
| 2|
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r183417848
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/PythonUDF.scala
---
@@ -34,10 +34,15 @@ object PythonUDF {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r183412509
--- Diff: python/pyspark/sql/functions.py ---
@@ -2301,10 +2301,12 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
The returned
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r183412270
--- Diff: python/pyspark/sql/functions.py ---
@@ -2301,10 +2301,12 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
The returned
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r183220435
--- Diff: python/pyspark/sql/tests.py ---
@@ -5156,6 +5156,15 @@ def test_retain_group_columns(self):
expected1 =
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21082#discussion_r183220392
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
---
@@ -149,7 +149,7 @@ class AnalysisErrorSuite
56 matches
Mail list logo
