Re: Review Request 48194: Update name of PXF component to PXF Agent

2016-06-03 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48194/#review136045 --- Ship it! Ship It! - Matt On June 2, 2016, 6:10 p.m., bhuvnes

Re: Review Request 48168: Check new jdbc functionality for SQLA and provide additional testing

2016-06-03 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48168/#review136051 --- Ship it! Ship It! - Dmitro Lisnichenko On June 2, 2016, 9:04

Review Request 48202: NPE during EU at Update Target Stack step

2016-06-03 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48202/ --- Review request for Ambari, Andrew Onischuk and Dmytro Grinenko. Bugs: AMBARI-17

Re: Review Request 48202: NPE during EU at Update Target Stack step

2016-06-03 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48202/#review136052 --- Ship it! Ship It! - Andrew Onischuk On June 3, 2016, 10:05 a

Re: Review Request 48202: NPE during EU at Update Target Stack step

2016-06-03 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48202/#review136053 --- Ship it! Ship It! - Dmytro Grinenko On June 3, 2016, 10:05 a

Re: Review Request 48121: YARN default configs are invalid

2016-06-03 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48121/ --- (Updated Июнь 3, 2016, 10:43 д.п.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 48121: YARN default configs are invalid

2016-06-03 Thread Dmytro Sen
> On Июнь 2, 2016, 4:55 п.п., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 337 > > > > > > This code looks fine

Re: Review Request 48173: Fix logfeeder filter name of logsearch

2016-06-03 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48173/ --- (Updated June 3, 2016, 10:53 a.m.) Review request for Ambari, Dharmesh Makwana,

Re: Review Request 48162: 16171 Addendum2 for stackadvisor with Phoenix Query Server kerberos configuration

2016-06-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48162/#review136057 --- Ship it! ambari-server/src/main/resources/stacks/HDP/2.5/servi

Re: Review Request 48181: Service admin and cluster operator can't modify service configs through API

2016-06-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48181/#review136058 --- Ship it! Ship It! - Nate Cole On June 2, 2016, 2:34 p.m., Ro

Re: Review Request 48162: 16171 Addendum2 for stackadvisor with Phoenix Query Server kerberos configuration

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48162/#review136059 --- Ship it! Ship It! - Jonathan Hurley On June 2, 2016, 12:38 p

Re: Review Request 48181: Service admin and cluster operator can't modify service configs through API

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48181/#review136060 --- Ship it! Ship It! - Jonathan Hurley On June 2, 2016, 2:34 p.

Review Request 48204: HDP-UTILs Repo URL validation/save fails

2016-06-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48204/ --- Review request for Ambari, Jonathan Hurley and Robert Levas. Bugs: AMBARI-17028

Review Request 48205: Cluster operator and ServiceAdministrator not allowed to create config group

2016-06-03 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48205/ --- Review request for Ambari, Eugene Chekanskiy, Jonathan Hurley, Myroslav Papirkov

Re: Review Request 48204: HDP-UTILs Repo URL validation/save fails

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48204/#review136061 --- Ship it! Ship It! - Jonathan Hurley On June 3, 2016, 8:43 a.

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-03 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47730/ --- (Updated Июнь 3, 2016, 1:52 п.п.) Review request for Ambari, Aravindan Vijayan,

Re: Review Request 48205: Cluster operator and ServiceAdministrator not allowed to create config group

2016-06-03 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48205/ --- (Updated June 3, 2016, 9:56 a.m.) Review request for Ambari, Eugene Chekanskiy,

Re: Review Request 48204: HDP-UTILs Repo URL validation/save fails

2016-06-03 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48204/#review136062 --- Ship it! Ship It! - Robert Levas On June 3, 2016, 8:43 a.m.,

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47730/#review136064 --- ambari-metrics/ambari-metrics-common/pom.xml (line 89)

Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-03 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48207/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-17030 https:

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-03 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48207/#review136065 --- Ship it! Ship It! - Dmitro Lisnichenko On June 3, 2016, 5:38

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-03 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47730/ --- (Updated Июнь 3, 2016, 3:15 п.п.) Review request for Ambari, Aravindan Vijayan,

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-03 Thread Dmytro Sen
> On Июнь 3, 2016, 2:34 п.п., Jonathan Hurley wrote: > > ambari-metrics/ambari-metrics-common/pom.xml, line 89 > > > > > > Can you explain how this works with the relocation pattern below? > > > > I get that

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47730/#review136067 --- Ship it! Ship It! - Jonathan Hurley On June 3, 2016, 11:15 a

Re: Review Request 47746: Update Moment.js to latest stable version 2.13.0

2016-06-03 Thread Sangeeta Ravindran
> On June 2, 2016, 10:34 p.m., Jaimin Jetly wrote: > > Ship It! Hi Jaimin, Thank you. Can you help commit the fix. Thanks in advance. -Sangeeta - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews

Review Request 48212: Fix files mentioned by ServicePropertiesTest on latest commits

2016-06-03 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48212/ --- Review request for Ambari and Jayush Luniya. Bugs: AMBARI-17032 https://iss

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-03 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/ --- (Updated June 3, 2016, 4:54 p.m.) Review request for Ambari, Alexander Denissov

Re: Review Request 48212: Fix files mentioned by ServicePropertiesTest on latest commits

2016-06-03 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48212/ --- (Updated June 3, 2016, 7:55 p.m.) Review request for Ambari and Jayush Luniya.

Re: Review Request 48212: Fix files mentioned by ServicePropertiesTest on latest commits

2016-06-03 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48212/#review136078 --- ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/co

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-03 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/#review136089 --- A lof of files have changed, please give me 24 hours to go over th

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-03 Thread Tim Thorpe
> On June 3, 2016, 6:29 p.m., Alejandro Fernandez wrote: > > A lof of files have changed, please give me 24 hours to go over this. Thank > > you The patch really hasn't changed all that much in the past week or so. I did add the Upgrade240 changes to add the 2 new DB tables when upgrading to

Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48221/ --- Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas. Bu

Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48221/#review136101 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-03 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48207/#review136102 --- ambari-agent/src/main/python/ambari_agent/Controller.py (line 290

Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48221/ --- (Updated June 3, 2016, 4:56 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48221/#review136108 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-03 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush Luniya

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-03 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/ --- (Updated June 3, 2016, 9:26 p.m.) Review request for Ambari, Alexander Denissov

Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48221/ --- (Updated June 3, 2016, 5:30 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Jonathan Hurley
> On June 3, 2016, 5:09 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java, > > line 1201 > > > > > > one day we'll support multi-cluster

Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48221/#review136112 --- Ship it! Ship It! - Nate Cole On June 3, 2016, 5:30 p.m., Jo

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-03 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/#review136105 --- This is a fairly big patch and I'm surprised more people haven't r

Re: Review Request 48205: Cluster operator and ServiceAdministrator not allowed to create config group

2016-06-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48205/#review136118 --- Ship it! Ship It! - Nate Cole On June 3, 2016, 9:56 a.m., Ro

Review Request 48234: Falcon server fails to start, HDP 2.4 to use data-mirroring directory, HDP 2.5 to use extensions

2016-06-03 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48234/ --- Review request for Ambari, Andrew Onischuk, Di Li, Dmitro Lisnichenko, Jonathan

Review Request 48235: Show only relevant properties in HAWQ based on the status of HAWQ Resource Manager type

2016-06-03 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48235/ --- Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Bugs: AMBARI

Re: Review Request 47673: Wrong memory conf in spark-env.xml

2016-06-03 Thread Weiqing Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47673/ --- (Updated June 3, 2016, 11:01 p.m.) Review request for Ambari and Sumit Mohanty.

Re: Review Request 47673: Wrong memory conf in spark-env.xml

2016-06-03 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47673/#review136129 --- ambari-server/src/main/resources/common-services/SPARK/1.2.1/conf

Re: Review Request 48235: Show only relevant properties in HAWQ based on the status of HAWQ Resource Manager type

2016-06-03 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48235/#review136128 --- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/servi

Re: Review Request 48235: Show only relevant properties in HAWQ based on the status of HAWQ Resource Manager type

2016-06-03 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48235/#review136131 --- Ship it! Ship It! - Matt On June 3, 2016, 3:49 p.m., bhuvnes

Re: Review Request 48221: Getting JMX Protocol Values On Large Cluster Takes Too Long

2016-06-03 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48221/#review136134 --- Ship it! Ship It! - Robert Levas On June 3, 2016, 5:30 p.m.,

Re: Review Request 48205: Cluster operator and ServiceAdministrator not allowed to create config group

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48205/#review136135 --- Ship it! Ship It! - Jonathan Hurley On June 3, 2016, 9:56 a.

Re: Review Request 48234: Falcon server fails to start, HDP 2.4 to use data-mirroring directory, HDP 2.5 to use extensions

2016-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48234/#review136136 --- Fix it, then Ship it! ambari-server/src/main/resources/common-

Review Request 48241: Enable kerberos wizard UI showing incorrect total of required fields

2016-06-03 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48241/ --- Review request for Ambari, Zhe (Joe) Wang, Xi Wang, and Yusaku Sako. Bugs: AMBA

Re: Review Request 48241: Enable kerberos wizard UI showing incorrect total of required fields

2016-06-03 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48241/#review136138 --- Ship it! Ship It! - Zhe (Joe) Wang On June 3, 2016, 11:43 p.

Re: Review Request 48241: Enable kerberos wizard UI showing incorrect total of required fields

2016-06-03 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48241/#review136139 --- Ship it! Ship It! - Yusaku Sako On June 3, 2016, 11:43 p.m.,

Review Request 48242: Takes long time to start or fail to start service after enabling SSL due to "dfs.https.enable"

2016-06-03 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48242/ --- Review request for Ambari, Alejandro Fernandez and Andrew Onischuk. Bugs: AMBAR

Re: Review Request 48234: Falcon server fails to start, HDP 2.4 to use data-mirroring directory, HDP 2.5 to use extensions

2016-06-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48234/#review136145 --- Ship it! Ship It! - Nate Cole On June 3, 2016, 6:47 p.m., Al

Re: Review Request 48235: Show only relevant properties in HAWQ based on the status of HAWQ Resource Manager type

2016-06-03 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48235/#review136150 --- ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_adviso

Re: Review Request 48235: Show only relevant properties in HAWQ based on the status of HAWQ Resource Manager type

2016-06-03 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48235/#review136151 --- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/servi