Re: Review Request 49786: AMBARI-17615 : AMS metrics GET API does not work for same metric with multiple aggregation functions

2016-07-11 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49786/ --- (Updated July 11, 2016, 8:14 p.m.) Review request for Ambari, Dmytro Sen,

Re: Review Request 49640: Identify config changes added to Ambari-2.4.0 and mark them to not get added during Ambari upgrade

2016-07-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49640/#review141765 --- Ship it! Ship It! - Alejandro Fernandez On July 11, 2016,

Re: Review Request 49915: EU Downgrade Does Not Stop Services

2016-07-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49915/#review141766 --- Ship it! Ship It! - Alejandro Fernandez On July 11, 2016,

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-07-11 Thread Masahiro Tanaka
> On July 11, 2016, 3:46 p.m., Jonathan Hurley wrote: > > Thank you for reviewing! I'm going to fix the issues, and wait till the other reviewers leave comments that we should use `parameters` or not. - Masahiro --- This is an

Review Request 49912: Blueprint registration step uses wrong format for property-attributes in Configuration

2016-07-11 Thread Keta Patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49912/ --- Review request for Ambari, Di Li and Robert Nettleton. Bugs: AMBARI-17626

Review Request 49915: EU Downgrade Does Not Stop Services

2016-07-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49915/ --- Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate

Re: Review Request 44464: AMBARI-15321. Adding support for Hive Server Interactive Alerts.

2016-07-11 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44464/#review141795 ---

Re: Review Request 49640: Identify config changes added to Ambari-2.4.0 and mark them to not get added during Ambari upgrade

2016-07-11 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49640/ --- (Updated July 11, 2016, 10:41 p.m.) Review request for Ambari, Jonathan

Review Request 49930: AMBARI-17614 Clean up import * for AMBARI_METRICS services

2016-07-11 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49930/ --- Review request for Ambari, Aravindan Vijayan, Jayush Luniya, and Juanjo Marron.

Re: Review Request 49927: Atlas HA fails to come up with error finding ids

2016-07-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49927/ --- (Updated July 11, 2016, 9:42 p.m.) Review request for Ambari, Madhan

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-07-11 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review141786 --- Should I UpgradeCatalog250.java as we are readying to release

Review Request 49931: AMBARI-17663 - Hosts page: JS error when sorting

2016-07-11 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49931/ --- Review request for Ambari, Zhe (Joe) Wang and Xi Wang. Bugs: AMBARI-17663

Re: Review Request 49934: AMBARI-17665. Fix the typo in 'alert_hive_interactive_thrift_port.py' for 'HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY'. Also, adding the required extra '-' for 'findAppTimeo

2016-07-11 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49934/ --- (Updated July 11, 2016, 11:50 p.m.) Review request for Ambari, Alejandro

Re: Review Request 49930: AMBARI-17614 Clean up import * for AMBARI_METRICS services

2016-07-11 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49930/#review141805 --- Ship it! Ship It! - Juanjo Marron On July 11, 2016, 10:59

Re: Review Request 49931: AMBARI-17663 - Hosts page: JS error when sorting

2016-07-11 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49931/#review141803 --- Ship it! Ship It! - Zhe (Joe) Wang On July 11, 2016, 11:42

Review Request 49934: AMBARI-17665. Fix the typo in 'alert_hive_interactive_thrift_port.py' for 'HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY'. Also, adding the required extra '-' for 'findAppTimeout'

2016-07-11 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49934/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Re: Review Request 49934: AMBARI-17665. Fix the typo in 'alert_hive_interactive_thrift_port.py' for 'HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY'. Also, adding the required extra '-' for 'findAppTimeo

2016-07-11 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49934/#review141807 ---

Review Request 49935: AMBARI-17633 yarn.nodemanager.remote-app-log-dir should be added stickybit.

2016-07-11 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49935/ --- Review request for Ambari, Andrew Onischuk, jun aoki, and Myroslav Papirkovskyy.

Review Request 49927: Atlas HA fails to come up with error finding ids

2016-07-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49927/ --- Review request for Ambari, Madhan Neethiraj, Nahappan Somasundaram, Sumit

Re: Review Request 49927: Atlas HA fails to come up with error finding ids

2016-07-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49927/#review141783 ---

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-07-11 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/ --- (Updated July 11, 2016, 9:50 p.m.) Review request for Ambari, Florian Barca,

Re: Review Request 49934: AMBARI-17665. Fix the typo in 'alert_hive_interactive_thrift_port.py' for 'HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY'. Also, adding the required extra '-' for 'findAppTimeo

2016-07-11 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49934/ --- (Updated July 12, 2016, 3:14 a.m.) Review request for Ambari, Alejandro

Re: Review Request 49934: AMBARI-17665. Fix the typo in 'alert_hive_interactive_thrift_port.py' for 'HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY'. Also, adding the required extra '-' for 'findAppTimeo

2016-07-11 Thread Swapan Shridhar
> On July 12, 2016, 12:10 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py, > > line 39 > > > > > > Lets add the

Re: Review Request 49934: AMBARI-17665. Fix the typo in 'alert_hive_interactive_thrift_port.py' for 'HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY'. Also, adding the required extra '-' for 'findAppTimeo

2016-07-11 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49934/#review141835 --- Ship it! Ship It! - Sumit Mohanty On July 12, 2016, 3:14

Re: Review Request 49786: AMBARI-17615 : AMS metrics GET API does not work for same metric with multiple aggregation functions

2016-07-11 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49786/#review141829 --- Ship it! Ship It! - Sid Wagle On July 11, 2016, 8:14 p.m.,

Review Request 49944: optimize log description of ambari agent stop

2016-07-11 Thread wang yaoxin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49944/ --- Review request for Ambari. Bugs: AMBARI-17668

Re: Review Request 49809: Ambari server log flooded with error messages related to LogSearch service

2016-07-11 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49809/#review141656 --- Ship it! Ship It! I give you a +1, but logSearchServerRunning

Re: Review Request 49858: Zeppelin service: remove principal and keytab from interpreter settings when kerberos is disabled on a secure cluster

2016-07-11 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49858/#review141660 --- Ship it! Tested on ubuntu 14.04 - Prabhjyot Singh On July

Re: Review Request 49857: Spark Interpreter fails with "HiveException: org.apache.thrift.transport.TTransportException"

2016-07-11 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49857/#review141664 --- Ship it! Ship It! - Pallav Kulshreshtha On July 9, 2016,

Re: Review Request 49859: Zeppelin service: Dependencies for phoenix in JDBC interpreter are not configured by default

2016-07-11 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49859/#review141663 --- Ship it! Ship It! - Pallav Kulshreshtha On July 9, 2016,

Re: Review Request 49889: Fix logfeeder inputs for hbase and hdfs

2016-07-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49889/#review141673 --- Ship it! Ship It! - Sebastian Toader On July 11, 2016, 1:54

Re: Review Request 49859: Zeppelin service: Dependencies for phoenix in JDBC interpreter are not configured by default

2016-07-11 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49859/#review141666 --- Ship it! Ship It! - Rohit Choudhary On July 9, 2016, 6:48

Re: Review Request 49857: Spark Interpreter fails with "HiveException: org.apache.thrift.transport.TTransportException"

2016-07-11 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49857/#review141667 --- Ship it! Ship It! - Rohit Choudhary On July 9, 2016, 6:04

Re: Review Request 49858: Zeppelin service: remove principal and keytab from interpreter settings when kerberos is disabled on a secure cluster

2016-07-11 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49858/#review141665 --- Ship it! Ship It! - Rohit Choudhary On July 9, 2016, 6:33

Review Request 49889: Fix logfeeder inputs for hbase and hdfs

2016-07-11 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49889/ --- Review request for Ambari, Dharmesh Kakadia, Sumit Mohanty, and Sebastian

Re: Review Request 49861: Changes to stack advisor framework to help with service advisors

2016-07-11 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49861/#review141670 --- Ship it! Ship It! - Tim Thorpe On July 9, 2016, 9:22 p.m.,

Re: Review Request 49889: Fix logfeeder inputs for hbase and hdfs

2016-07-11 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49889/#review141671 --- Ship it! Ship It! - Dharmesh Makwana On July 11, 2016,

Re: Review Request 49858: Zeppelin service: remove principal and keytab from interpreter settings when kerberos is disabled on a secure cluster

2016-07-11 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49858/#review141662 --- Ship it! Ship It! - Pallav Kulshreshtha On July 9, 2016,

Re: Review Request 49884: Nodemanager is not started after installation

2016-07-11 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49884/#review141652 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 11,

Re: Review Request 49755: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation

2016-07-11 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49755/#review141661 ---

Review Request 49894: Installation of Components are failed on suse12 with suse11sp3 ambari/hdp repo

2016-07-11 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49894/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-17654

Re: Review Request 49894: Installation of Components was failed on suse12 with suse11sp3 ambari/hdp repo

2016-07-11 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49894/ --- (Updated July 11, 2016, 2 p.m.) Review request for Ambari and Dmitro

Re: Review Request 49640: Identify config changes added to Ambari-2.4.0 and mark them to not get added during Ambari upgrade

2016-07-11 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49640/ --- (Updated July 11, 2016, 4:38 p.m.) Review request for Ambari, Jonathan Hurley,

Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-11 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49891/ --- Review request for Ambari, Andrew Onischuk and Jonathan Hurley. Bugs:

Re: Review Request 49857: Spark Interpreter fails with "HiveException: org.apache.thrift.transport.TTransportException"

2016-07-11 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49857/ --- (Updated July 11, 2016, 12:52 p.m.) Review request for Ambari, Alejandro

Re: Review Request 49857: Spark Interpreter fails with "HiveException: org.apache.thrift.transport.TTransportException"

2016-07-11 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49857/#review141684 --- Ship it! Ship It! - Rohit Choudhary On July 11, 2016, 12:52

Re: Review Request 49894: Installation of Components was failed on suse12 with suse11sp3 ambari/hdp repo

2016-07-11 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49894/#review141690 --- Ship it! Ship It! - Dmitro Lisnichenko On July 11, 2016, 5

Review Request 49895: AMBARI-17631: preinstall-check script should use AMBARI-AGENT REST API for the list of agents

2016-07-11 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49895/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-17631

Review Request 49897: AMBARI-17617: Set default log level for Ranger KMS to INFO

2016-07-11 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49897/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit Mohanty,

Re: Review Request 49786: AMBARI-17615 : AMS metrics GET API does not work for same metric with multiple aggregation functions

2016-07-11 Thread Aravindan Vijayan
> On July 11, 2016, 3:13 a.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java, > > line 290 > >

Review Request 49902: Storm nimbus server fails to come up with CNF backtype.storm.metric.IClusterReporter error

2016-07-11 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49902/ --- Review request for Ambari, Aravindan Vijayan and Sid Wagle. Bugs: AMBARI-17658

Re: Review Request 49902: Storm nimbus server fails to come up with CNF backtype.storm.metric.IClusterReporter error

2016-07-11 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49902/#review141716 --- Ship it! Looks good but can you add Jayush as reviewer as

Re: Review Request 49897: AMBARI-17617: Set default log level for Ranger KMS to INFO

2016-07-11 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49897/#review141699 --- Ship it! Ship It! - Velmurugan Periasamy On July 11, 2016,

Re: Review Request 49808: Host service mapping has incorrect default mapping

2016-07-11 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49808/ --- (Updated July 11, 2016, 3:29 p.m.) Review request for Ambari, Dmytro Sen and

Review Request 49898: ACL support for Logsearch Solr

2016-07-11 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49898/ --- Review request for Ambari, Miklos Gergely, Robert Levas, Robert Nettleton,

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-07-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review141703 --- ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py

Re: Review Request 49831: AMBARI-17562 - Adding single stack, extension and service should be removed from management pack support

2016-07-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49831/#review141725 --- Ship it! Ship It! - Jayush Luniya On July 8, 2016, 9:13

Re: Review Request 49808: Host service mapping has incorrect default mapping

2016-07-11 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49808/#review141701 --- Ship it! Ship It! - Dmytro Sen On Июль 11, 2016, 3:29 п.п.,

Re: Review Request 49902: Storm nimbus server fails to come up with CNF backtype.storm.metric.IClusterReporter error

2016-07-11 Thread Dmytro Sen
> On Июль 11, 2016, 4:35 п.п., Sid Wagle wrote: > > Looks good but can you add Jayush as reviewer as well. Added Jayush. That's a draft yet. Will fix unit tests and commit tomorrow. Now exact storm(and all installed services) version is passed from server to the agents. If version 1+ then new

Review Request 49905: AMBARI-17645 Update JDK version of Dockerfile in dev-support

2016-07-11 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49905/ --- Review request for Ambari, Jaimin Jetly, jun aoki, and Sumit Mohanty. Bugs:

Re: Review Request 49905: AMBARI-17645 Update JDK version of Dockerfile in dev-support

2016-07-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49905/#review141727 --- Ship it! Ship It! - Alejandro Fernandez On July 11, 2016,

Re: Review Request 49905: AMBARI-17645 Update JDK version of Dockerfile in dev-support

2016-07-11 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49905/ --- (Updated July 11, 2016, 5:27 p.m.) Review request for Ambari, Jaimin Jetly,