Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50911/#review145224 ---

Re: Review Request 50170: AMBARI-17749 Typo "rather then" in spark-default.conf

2016-08-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50170/#review145231 --- Ship it! Ship It! - Alejandro Fernandez On July 19, 2016,

Re: Review Request 50801: AMBARI-18026 : Restart of plugin enabled services fails in secured env with Ranger HA

2016-08-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50801/#review145222 --- Ship it! Ship It! - Jonathan Hurley On Aug. 8, 2016, 3:09

Re: Review Request 50870: Introduce validation of hostgroup mapping for active/standby namenode

2016-08-09 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50870/ --- (Updated Aug. 9, 2016, 5:15 p.m.) Review request for Ambari, Di Li and Robert

Re: Review Request 50170: AMBARI-17749 Typo "rather then" in spark-default.conf

2016-08-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50170/#review145234 --- Pushed to trunk, commit aa2930a4a696f721934e0608d1dccf206a2fad9f

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-08-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/#review145236 --- Ship it! Ship It! - Alejandro Fernandez On July 29, 2016,

Re: Review Request 50886: config page load takes long time on cluster with large number of config versions

2016-08-09 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50886/ --- (Updated Aug. 9, 2016, 10:45 p.m.) Review request for Ambari, Dmytro Sen,

Re: Review Request 50886: config page load takes long time on cluster with large number of config versions

2016-08-09 Thread Jaimin Jetly
> On Aug. 9, 2016, 6:22 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > line 21 > > > > > > Could you adjust your import

Review Request 50943: AMBARI-18093 : Reduce TTL for high precision tables and remove HBase policy setters in AMS config

2016-08-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50943/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 50886: config page load takes long time on cluster with large number of config versions

2016-08-09 Thread Jaimin Jetly
> On Aug. 9, 2016, 6:22 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > lines 3558-3565 > > > > > > This logic will not use

Re: Review Request 49905: AMBARI-17645 Update JDK version of Dockerfile in dev-support

2016-08-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49905/#review145296 --- Ship it! Ship It! - Alejandro Fernandez On July 14, 2016,

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50911/ --- (Updated Aug. 10, 2016, 1:22 a.m.) Review request for Ambari, Dmytro Grinenko,

Review Request 50945: Fix Spark2 service check failure when WE is enabled

2016-08-09 Thread Saisai Shao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50945/ --- Review request for Ambari, Jayush Luniya and Sumit Mohanty. Bugs: AMBARI-18091

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50911/#review145308 ---

Re: Review Request 50945: Fix Spark2 service check failure when WE is enabled

2016-08-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50945/#review145309 --- Ship it! Ship It! - Sumit Mohanty On Aug. 10, 2016, 5:45

Re: Review Request 50924: Clean up Log Search Appender and improve speed

2016-08-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50924/#review145200 --- Ship it! Ship It! - Oliver Szabo On Aug. 9, 2016, 11:42

Re: Review Request 50924: Clean up Log Search Appender and improve speed

2016-08-09 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50924/ --- (Updated Aug. 9, 2016, 11:42 a.m.) Review request for Ambari, Hayat Behlim,

Re: Review Request 50691: AMBARI-17213: Worfklow designer initial contrib view

2016-08-09 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50691/#review145201 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Aug. 2, 2016, 7:45

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50884/#review145213 --- commited to trunk: 6dcf638192e8abff967c405cc9ef01b4dfc3b764

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-09 Thread Nate Cole
> On Aug. 9, 2016, 8:33 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java, > > lines 92-96 > > > > > > Doesn't seem like this would be difficult to tell in

Re: Review Request 50475: AMBARI-17778 Add usage information in ambari-server script

2016-08-09 Thread Masahiro Tanaka
> On July 27, 2016, 10:56 p.m., Nate Cole wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you for reviewing. Could you commit it? > > Nate Cole wrote: > Should it be committed to trunk? > > Masahiro Tanaka wrote: > Yes, please. I added "trunk" to "Branch" on this review

Review Request 50919: AMBARI-18073 Text change of Audit to DB Removal during upgrade for Ranger

2016-08-09 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50919/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Velmurugan

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-09 Thread Hemanth Yamijala
> On Aug. 9, 2016, 1:21 p.m., Oliver Szabo wrote: > > commited to trunk: 6dcf638192e8abff967c405cc9ef01b4dfc3b764 > > thanks for the contribution, > > you can close that and repoen it with a patch for 2.5 (if the branch-2.5 is > > created) Thanks, Oliver! - Hemanth

Re: Review Request 50930: Ranger service check does not run during Express Upgrade

2016-08-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50930/#review145248 ---

Re: Review Request 50928: Fix conf-select for Zeppelin service

2016-08-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50928/#review145250 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 9, 2016,

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-09 Thread Alejandro Fernandez
> On Aug. 9, 2016, 9:58 a.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java, > > line 97 > > > > > > What if there are few dependencies in hierarhy? >

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-09 Thread Alejandro Fernandez
> On Aug. 9, 2016, 12:33 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java, > > lines 92-96 > > > > > > Doesn't seem like this would be difficult to tell in

Review Request 50928: Fix conf-select for Zeppelin service

2016-08-09 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50928/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Rohit

Re: Review Request 50928: Fix conf-select for Zeppelin service

2016-08-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50928/#review145239 --- Ship it! Ship It! - Sumit Mohanty On Aug. 9, 2016, 6:48

Re: Review Request 50929: Falcon Ambari integration should be enabled even if Atlas server and Falcon server are no collocated

2016-08-09 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50929/ --- (Updated Сер. 9, 2016, 7:07 після полудня) Review request for Ambari,

Review Request 50930: Ranger service check does not run during Express Upgrade

2016-08-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50930/ --- Review request for Ambari, Alejandro Fernandez and Nate Cole. Bugs:

Re: Review Request 50929: Falcon Ambari integration should be enabled even if Atlas server and Falcon server are no collocated

2016-08-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50929/#review145247 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 9, 2016,

Re: Review Request 50870: Introduce validation of hostgroup mapping for active/standby namenode

2016-08-09 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50870/#review145255 --- Ship it! Ship It! - Di Li On Aug. 9, 2016, 5:15 p.m.,

Re: Review Request 50930: Ranger service check does not run during Express Upgrade

2016-08-09 Thread Jonathan Hurley
> On Aug. 9, 2016, 3:56 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml, > > line 991 > > > > > > Was Ranger KMS not available in HDP 2.2?

Re: Review Request 50930: Ranger service check does not run during Express Upgrade

2016-08-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50930/#review145264 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 9, 2016,

Re: Review Request 50870: Introduce validation of hostgroup mapping for active/standby namenode

2016-08-09 Thread Amruta Borkar
> On Aug. 9, 2016, 8:07 p.m., Di Li wrote: > > Ship It! Thank you Di! Could you please help me push this to trunk? - Amruta --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 50870: Introduce validation of hostgroup mapping for active/standby namenode

2016-08-09 Thread Amruta Borkar
> On Aug. 9, 2016, 2:17 p.m., Di Li wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostGroupImpl.java, > > line 288 > > > > > > what's the purpose of the tailing whitespace ? removed the

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-09 Thread Alejandro Fernandez
> On Aug. 9, 2016, 5:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java, > > lines 92-98 > > > > > > I agree with the other comments that this would

Re: Review Request 50930: Ranger service check does not run during Express Upgrade

2016-08-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50930/#review145245 ---

Re: Review Request 50929: Falcon Ambari integration should be enabled even if Atlas server and Falcon server are no collocated

2016-08-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50929/#review145242 --- Ship it! Ship It! - Sumit Mohanty On Aug. 9, 2016, 7:03

Re: Review Request 50930: Ranger service check does not run during Express Upgrade

2016-08-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50930/#review145246 --- Ship it! Ship It! - Nate Cole On Aug. 9, 2016, 3:41 p.m.,