Re: Review Request 51792: Refactor logsearch portal code - move solr field mappings to UI & remove unused params

2016-09-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51792/ --- (Updated Sept. 12, 2016, 9:39 a.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 51796: Ambari fails to start nodemanager due to unexpected return code from sudo su command on the pid file

2016-09-12 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51796/#review148475 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 12, 2016,

Re: Review Request 51792: Refactor logsearch portal code - move solr field mappings to UI & remove unused params

2016-09-12 Thread Miklos Gergely
> On Sept. 12, 2016, 9:11 a.m., Miklos Gergely wrote: > > Ship It! Fix it, then ship it. - Miklos --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51792/#review148470

Review Request 51795: ZEPPELIN user won't get created in ZEPPELIN group

2016-09-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51795/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18356

Review Request 51796: Ambari fails to start nodemanager due to unexpected return code from sudo su command on the pid file

2016-09-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51796/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18357

Re: Review Request 51795: ZEPPELIN user won't get created in ZEPPELIN group

2016-09-12 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51795/#review148474 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 12, 2016,

Re: Review Request 51792: Refactor logsearch portal code - move solr field mappings to UI & remove unused params

2016-09-12 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51792/#review148470 --- Ship it! Ship It! - Miklos Gergely On Sept. 11, 2016, 7:58

Re: Review Request 51792: Refactor logsearch portal code - move solr field mappings to UI & remove unused params

2016-09-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51792/ --- (Updated Sept. 12, 2016, 9:54 a.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 49804: improve resourcemanager HA description

2016-09-12 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49804/#review148468 --- ambari-web/app/models/host_component.js (line 333)

Re: Review Request 51792: Refactor logsearch portal code - move solr field mappings to UI & remove unused params

2016-09-12 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51792/#review148469 ---

Re: Review Request 51792: Refactor logsearch portal code - move solr field mappings to UI & remove unused params

2016-09-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51792/ --- (Updated Sept. 12, 2016, 11:18 a.m.) Review request for Ambari, Miklos

Re: Review Request 51426: Journal node restart failing on RU from dergM10 to erie on Wire Encrypted cluster

2016-09-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51426/#review148478 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 25, 2016,

Review Request 51801: Get LDAP tests to run in concurrent forked JVMs

2016-09-12 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51801/ --- Review request for Ambari, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.

Re: Review Request 51801: Get LDAP tests to run in concurrent forked JVMs

2016-09-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51801/#review148480 --- Ship it! Ship It! - Sebastian Toader On Sept. 12, 2016,

Re: Review Request 51704: Refactor logsearch portal code - part 2

2016-09-12 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51704/#review148481 --- Ship it! Ship It! - Miklos Gergely On Sept. 7, 2016, 8:52

Review Request 51806: ambari-agent check for unset variables (AMBARI-18317)

2016-09-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51806/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18360

Re: Review Request 51801: Get LDAP tests to run in concurrent forked JVMs

2016-09-12 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51801/ --- (Updated Sept. 12, 2016, 1:01 p.m.) Review request for Ambari, Oliver Szabo,

Review Request 51811: All classes recompiled due to Maven bug, even if none changed

2016-09-12 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51811/ --- Review request for Ambari, Jayush Luniya, Laszlo Puskas, Oliver Szabo, and

Review Request 51818: YAML Maps For Storm Are Not Being Escaped Correctly

2016-09-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51818/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-18366

Review Request 51814: Update sinks to read multiple collector hostnames from configs

2016-09-12 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51814/ --- Review request for Ambari, Aravindan Vijayan and Sid Wagle. Bugs: AMBARI-18362

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-12 Thread Balázs Bence Sári
> On Aug. 29, 2016, 5:27 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java, > > line 562 > > > > > > Weird that it's

Re: Review Request 51813: Modify the AMS stack scripts to support distributed collector

2016-09-12 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51813/#review148533 ---

Re: Review Request 51818: YAML Maps For Storm Are Not Being Escaped Correctly

2016-09-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51818/#review148562 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 12, 2016,

Re: Review Request 51801: Get LDAP tests to run in concurrent forked JVMs

2016-09-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51801/#review148520 --- Ship it! Fantastic! - Alejandro Fernandez On Sept. 12,

Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-09-12 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51815/ --- Review request for Ambari, Di Li, Juanjo Marron, Laszlo Puskas, and Robert

Re: Review Request 51811: All classes recompiled due to Maven bug, even if none changed

2016-09-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51811/#review148510 --- Ship it! Ship It! - Sebastian Toader On Sept. 12, 2016,

Re: Review Request 51811: All classes recompiled due to Maven bug, even if none changed

2016-09-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51811/#review148503 --- Ship it! Ship It! - Nate Cole On Sept. 12, 2016, 11:56

Re: Review Request 51811: All classes recompiled due to Maven bug, even if none changed

2016-09-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51811/#review148513 --- Ship it! Ship It! - Jayush Luniya On Sept. 12, 2016, 3:56

Re: Review Request 51711: AMBARI-17458 : Add support for distributed collector to Ambari REST API.

2016-09-12 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51711/#review148543 --- Ship it! Ship It! - Sid Wagle On Sept. 11, 2016, 2:10 a.m.,

Re: Review Request 51814: Update sinks to read multiple collector hostnames from configs

2016-09-12 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51814/#review148527 ---

Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-12 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-12 Thread Qin Liu
On Sept. 8, 2016, 6:13 p.m., Qin Liu wrote: > > We don't have unit test whcih setup secure cluster so we should definitely > > test this on trunk build, which should be working now. > > The changes overall look good just want to make sure we have done some > > manual testing before commit. >

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-12 Thread Anita Jebaraj
> On Sept. 8, 2016, 5:42 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py, line 103 > > > > > > This will cause problems since you're storing the obfuscated > >

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-12 Thread Anita Jebaraj
> On Sept. 8, 2016, 3:25 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java, > > lines 252-257 > > > > > > Will this be a performance issue? On large clusters

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-12 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51705/ --- (Updated Sept. 12, 2016, 8:20 p.m.) Review request for Ambari, Di Li, Jonathan

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-12 Thread Sid Wagle
> On Sept. 8, 2016, 6:13 p.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py, > > line 25 > > > > > > I do not see a "import kerberos" anywhere in

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-12 Thread Aravindan Vijayan
On Sept. 8, 2016, 6:13 p.m., Qin Liu wrote: > > We don't have unit test whcih setup secure cluster so we should definitely > > test this on trunk build, which should be working now. > > The changes overall look good just want to make sure we have done some > > manual testing before commit. >

Re: Review Request 51818: YAML Maps For Storm Are Not Being Escaped Correctly

2016-09-12 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51818/#review148582 --- Ship it! Ship It! - Robert Levas On Sept. 12, 2016, 3:13

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-12 Thread Balázs Bence Sári
> On Sept. 7, 2016, 11:48 a.m., Tim Thorpe wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java, > > line 1133 > > > > > > This won't include extension services. You would need

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-12 Thread Balázs Bence Sári
> On Aug. 29, 2016, 5:54 p.m., Jayush Luniya wrote: > > contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml, > > line 24 > > > > > > A management pack

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-12 Thread Balázs Bence Sári
> On Aug. 29, 2016, 6:14 p.m., Jayush Luniya wrote: > > contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml, > > line 24 > > > > > > Is it mandatory to

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-12 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/ --- (Updated Sept. 12, 2016, 8:48 p.m.) Review request for Ambari, Jayush Luniya,

Re: Review Request 51833: Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-12 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51833/#review148649 --- Fix it, then Ship it! Ship It!

Re: Review Request 51833: Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51833/#review148636 ---

Review Request 51833: Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51833/ --- Review request for Ambari, Sumit Mohanty and Swapan Shridhar. Bugs:

Re: Review Request 51801: Get LDAP tests to run in concurrent forked JVMs

2016-09-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51801/#review148552 --- Ship it! Ship It! - Oliver Szabo On Sept. 12, 2016, 1:01

Re: Review Request 51833: Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51833/ --- (Updated Sept. 13, 2016, 1:53 a.m.) Review request for Ambari, Sumit Mohanty

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-12 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51705/ --- (Updated Sept. 12, 2016, 10:48 p.m.) Review request for Ambari, Di Li,

Re: Review Request 51762: Declare URL uniqueness in repoinfo.xml

2016-09-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51762/#review148499 --- Ship it! Ship It! - Nate Cole On Sept. 9, 2016, 1:07 p.m.,

Re: Review Request 51761: AMBARI-18050 - Upgrade pre-req check code needs to be decoupled from CheckDescription class

2016-09-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51761/#review148496 --- Perhaps we should have a check interface instead of requiring

Re: Review Request 51762: Declare URL uniqueness in repoinfo.xml

2016-09-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51762/#review148497 --- Ship it! Ship It! - Jonathan Hurley On Sept. 9, 2016, 1:07

Re: Review Request 51806: ambari-agent check for unset variables (AMBARI-18317)

2016-09-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51806/#review148502 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 12, 2016,

Review Request 51813: Modify the AMS stack scripts to support distributed collector

2016-09-12 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51813/ --- Review request for Ambari, Aravindan Vijayan and Sid Wagle. Bugs: AMBARI-17457