/service_config_layout_tab_view.js
Lines 185 (patched)
<https://reviews.apache.org/r/57268/#comment240302>
I think this two conditions can be join in one line
- Andrii Babiichuk
On Березень 6, 2017, 9:13 після полудня, Richard Zang wrote:
>
> ---
are always
enabled.
Diffs
-
ambari-web/app/utils/config.js 28881bb
ambari-web/test/utils/config_test.js f418614
Diff: https://reviews.apache.org/r/57389/diff/1/
Testing
---
20577 passing (20s)
153 pending
Thanks,
Andrii Babiichuk
emoved as
described above).
Diffs
-
ambari-web/app/messages.js 2e80a2b
ambari-web/app/styles/application.less 8a15fb1
ambari-web/app/views/common/configs/config_diff_view.js 135efb7
Diff: https://reviews.apache.org/r/57561/diff/1/
Testing
---
20559 passing (18s)
153 pendi
hanks,
Andrii Babiichuk
---
20569 passing (22s)
153 pending
Thanks,
Andrii Babiichuk
incorrect.
Diffs
-
ambari-web/app/styles/application.less 2112c51
Diff: https://reviews.apache.org/r/57639/diff/1/
Testing
---
20571 passing (19s)
153 pending
Thanks,
Andrii Babiichuk
ambari-web/test/controllers/experimental_test.js 0ff0758
Diff: https://reviews.apache.org/r/57681/diff/1/
Testing
---
20579 passing (19s)
153 pending
Thanks,
Andrii Babiichuk
)
-
ambari-web/app/controllers/experimental.js da8f39d
ambari-web/test/controllers/experimental_test.js 0ff0758
Diff: https://reviews.apache.org/r/57681/diff/2/
Changes: https://reviews.apache.org/r/57681/diff/1-2/
Testing
---
20579 passing (19s)
153 pending
Thanks,
Andrii Babiichuk
**Result**
Dropwown is incorrectly positioned
Diffs
-
ambari-web/vendor/scripts/theme/bootstrap-ambari.js 1f61104
Diff: https://reviews.apache.org/r/57698/diff/1/
Testing
---
20579 passing (21s)
153 pending
Thanks,
Andrii Babiichuk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57858/#review169753
---
Ship it!
Ship It!
- Andrii Babiichuk
On Березень 22, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57858/#review169863
---
Ship it!
Ship It!
- Andrii Babiichuk
On Березень 23, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57858/#review169873
---
Ship it!
Ship It!
- Andrii Babiichuk
On Березень 23, 2017
.js 21fb6b4
ambari-web/app/utils/configs/move_hm_config_initializer.js ab150e9
ambari-web/app/utils/configs/move_hs_config_initializer.js 7b15d0d
ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js
0f3c599
Diff: https://reviews.apache.org/r/57885/diff/1/
Testing
---
20602 pa
views/main/admin/stack_upgrade/upgrade_version_box_view_test.js
58067a2
Diff: https://reviews.apache.org/r/57907/diff/1/
Testing
---
20604 passing (20s)
128 pending
Thanks,
Andrii Babiichuk
e_version_box_view.js
a714149
ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js
58067a2
Diff: https://reviews.apache.org/r/57907/diff/1/
Testing
---
20604 passing (20s)
128 pending
Thanks,
Andrii Babiichuk
-admin/src/main/resources/ui/admin-web/app/views/users/list.html
87e2be7
Diff: https://reviews.apache.org/r/57961/diff/1/
Testing
---
Executed 81 of 81 SUCCESS (0.553 secs / 0.548 secs)
Thanks,
Andrii Babiichuk
-
20674 passing (24s)
128 pending
Thanks,
Andrii Babiichuk
/58207/diff/1/
Testing
---
20674 passing (19s)
128 pending
Thanks,
Andrii Babiichuk
fbc24
Diff: https://reviews.apache.org/r/58266/diff/1/
Testing
---
20678 passing (20s)
128 pending
Thanks,
Andrii Babiichuk
st.js 6c0f1f1
ambari-web/test/views/main/service/services/hdfs_test.js 4de5f0b
ambari-web/test/views/main/service/services/oozie_test.js c95e65f
Diff: https://reviews.apache.org/r/58300/diff/1/
Testing
---
20669 passing (23s)
128 pending
Thanks,
Andrii Babiichuk
shows "10"
Diffs
-
ambari-web/app/views/common/configs/widgets/slider_config_widget_view.js
c7e810b
ambari-web/test/views/common/configs/widgets/slider_config_widget_view_test.js
5cc055c
Diff: https://reviews.apache.org/r/58740/diff/1/
Testing
---
20701 passing (23s)
128 pending
Thanks,
Andrii Babiichuk
iew.js
948af5d
ambari-web/test/views/common/configs/widgets/slider_config_widget_view_test.js
9817479
Diff: https://reviews.apache.org/r/59024/diff/1/
Testing
---
20701 passing (22s)
128 pending
Thanks,
Andrii Babiichuk
/test/controllers/wizard_test.js 078f8ae
ambari-web/test/views/main/admin/highAvailability/resourceManager/wizard_view_test.js
d30be42
ambari-web/test/views/main/service/reassign_view_test.js f6ae81e
Diff: https://reviews.apache.org/r/59347/diff/1/
Testing
---
20698 passing (24s)
128 pending
Thanks,
Andrii Babiichuk
/tslint.json PRE-CREATION
ambari-logsearch/ambari-logsearch-web-new/yarn.lock PRE-CREATION
Diff: https://reviews.apache.org/r/60367/diff/1/
Testing
---
Executed 49 of 49 SUCCESS (1.504 secs / 1.472 secs)
Thanks,
Andrii Babiichuk
ari-logsearch/ambari-logsearch-web-new/src/app/top-menu/top-menu.component.ts
73b6131
ambari-logsearch/ambari-logsearch-web-new/src/app/variables.less 9a8ea09
Diff: https://reviews.apache.org/r/60430/diff/1/
Testing
---
Executed 49 of 49 SUCCESS (1.754 secs / 1.722 secs)
Thanks,
Andrii Babiichuk
,
Andrii Babiichuk
-web-new/src/app/services/storage/user-configs.service.ts
b26485d
Diff: https://reviews.apache.org/r/60650/diff/1/
Testing
---
Executed 46 of 46 SUCCESS (1.287 secs / 1.257 secs)
Thanks,
Andrii Babiichuk
of 46 SUCCESS (1.22 secs / 1.185 secs)
Thanks,
Andrii Babiichuk
://reviews.apache.org/r/60751/diff/1/
Testing
---
Executed 47 of 47 SUCCESS (1.178 secs / 1.147 secs)
Thanks,
Andrii Babiichuk
,
Andrii Babiichuk
/61373/diff/1/
Testing
---
21227 passing (26s)
128 pending
Thanks,
Andrii Babiichuk
://reviews.apache.org/r/61424/diff/1/
Testing
---
21266 passing (31s)
128 pending
Thanks,
Andrii Babiichuk
ost/bulk_operations_controller.js 34d61d8
Diff: https://reviews.apache.org/r/61425/diff/1/
Testing
---
21266 passing (20s)
128 pending
Thanks,
Andrii Babiichuk
-new/yarn.lock 6e592a7
Diff: https://reviews.apache.org/r/61549/diff/1/
Testing
---
Executed 51 of 51 SUCCESS
Thanks,
Andrii Babiichuk
-CREATION
ambari-logsearch/ambari-logsearch-web-new/src/assets/i18n/en.json d6a46ac
Diff: https://reviews.apache.org/r/61658/diff/1/
Testing
---
Executed 51 of 51 SUCCESS (1.378 secs / 1.353 secs)
Thanks,
Andrii Babiichuk
/app/services/storage/service-logs.service.ts
529a390
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/user-configs.service.ts
6640a30
Diff: https://reviews.apache.org/r/61659/diff/1/
Testing
---
Executed 51 of 51 SUCCESS (1.378 secs / 1.353 secs)
Thanks,
Andrii
://reviews.apache.org/r/61710/diff/1/
Testing
---
Executed 57 of 57 SUCCESS (1.367 secs / 1.345 secs)
Thanks,
Andrii Babiichuk
/ 1.498 secs)
Thanks,
Andrii Babiichuk
://reviews.apache.org/r/61718/diff/1/
Testing
---
Executed 78 of 78 SUCCESS (1.429 secs / 1.39 secs)
Thanks,
Andrii Babiichuk
,
Andrii Babiichuk
endor/**
**/yarn.lock
**/docker/Profile
**/node_modules/**
**/dist/**
```
- Andrii Babiichuk
On Сер. 28, 2017, 11:16 до полудня, Oliver Szabo wrote:
>
> ---
> This is an automatically genera
pache.org/r/61937/
> ---
>
> (Updated Сер. 28, 2017, 11:16 до полудня)
>
>
> Review request for Ambari, Andrii Babiichuk and Miklos Gergely.
>
>
> Bugs: AMBARI-21825
> https://issues.apache.org/jira/browse/AMBARI-21825
>
>
> Repository: ambari
>
>
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61937/#review183919
---
Ship it!
Ship It!
- Andrii Babiichuk
On Сер. 28, 2017, 11
-logsearch/ambari-logsearch-web-new/src/assets/i18n/en.json 5c7ab8d
Diff: https://reviews.apache.org/r/61970/diff/1/
Testing
---
Executed 84 of 84 SUCCESS (1.471 secs / 1.43 secs)
Thanks,
Andrii Babiichuk
-web-new/yarn.lock PRE-CREATION
ambari-logsearch/pom.xml 2be11ee
Diff: https://reviews.apache.org/r/61971/diff/1/
Testing
---
mvn clean install
Thanks,
Andrii Babiichuk
rch/ambari-logsearch-web/yarn.lock 291b489
Diff: https://reviews.apache.org/r/62159/diff/1/
Testing
---
Executed 84 of 84 SUCCESS (1.985 secs / 1.906 secs)
Thanks,
Andrii Babiichuk
/ambari-logsearch-web/yarn.lock 4883a15
Diff: https://reviews.apache.org/r/62184/diff/1/
Testing
---
Executed 84 of 84 SUCCESS (1.828 secs / 1.798 secs)
Thanks,
Andrii Babiichuk
secs / 1.804 secs)
Thanks,
Andrii Babiichuk
-CREATION
Diff: https://reviews.apache.org/r/62277/diff/2/
Changes: https://reviews.apache.org/r/62277/diff/1-2/
Testing
---
Executed 84 of 84 SUCCESS (1.844 secs / 1.804 secs)
Thanks,
Andrii Babiichuk
ambari-logsearch/ambari-logsearch-web/webpack.config.js PRE-CREATION
Diff: https://reviews.apache.org/r/62277/diff/3/
Changes: https://reviews.apache.org/r/62277/diff/2-3/
Testing
---
Executed 84 of 84 SUCCESS (1.844 secs / 1.804 secs)
Thanks,
Andrii Babiichuk
---
Executed 86 of 86 SUCCESS (1.909 secs / 1.869 secs)
Thanks,
Andrii Babiichuk
)
Thanks,
Andrii Babiichuk
(2.25 secs / 2.213 secs)
Thanks,
Andrii Babiichuk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62460/#review185872
---
Ship it!
Ship It!
- Andrii Babiichuk
On Вер. 21, 2017, 10
mbari-logsearch-web/src/assets/i18n/en.json e3f4c69
Diff: https://reviews.apache.org/r/62497/diff/1/
Testing
---
Executed 86 of 86 SUCCESS (1.902 secs / 1.883 secs)
Thanks,
Andrii Babiichuk
/assets/i18n/en.json 1235a80
ambari-logsearch/ambari-logsearch-web/src/polyfills.ts 0ab921a
Diff: https://reviews.apache.org/r/62499/diff/1/
Testing
---
Executed 86 of 86 SUCCESS (2.094 secs / 2.08 secs)
Thanks,
Andrii Babiichuk
/
Testing
---
Executed 87 of 87 SUCCESS (1.942 secs / 1.898 secs)
Thanks,
Andrii Babiichuk
-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 0d40bc7
Diff: https://reviews.apache.org/r/62689/diff/1/
Testing
---
Executed 89 of 89 SUCCESS (2.19 secs / 2.162 secs)
Thanks,
Andrii Babiichuk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62666/#review186669
---
Ship it!
Ship It!
- Andrii Babiichuk
On Вер. 28, 2017, 3:13
-
ambari-logsearch/ambari-logsearch-web/webpack.config.js c608d10
Diff: https://reviews.apache.org/r/62721/diff/1/
Testing
---
tested manually (```yarn start```, ```yarn build```, ```yarn build-prod```,
```yarn test```)
Thanks,
Andrii Babiichuk
/
Testing
---
Executed 89 of 89 SUCCESS (2.763 secs / 2.733 secs)
Thanks,
Andrii Babiichuk
/services/http-client.service.ts
44a5f6a
Diff: https://reviews.apache.org/r/62766/diff/1/
Testing
---
Executed 91 of 91 SUCCESS (2.144 secs / 2.103 secs)
Thanks,
Andrii Babiichuk
-configs.service.ts
1596e78
Diff: https://reviews.apache.org/r/62770/diff/1/
Testing
---
Executed 91 of 91 SUCCESS (2.491 secs / 2.474 secs)
Thanks,
Andrii Babiichuk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62727/#review187166
---
Ship it!
Ship It!
- Andrii Babiichuk
On Жов. 5, 2017, 9:37
-logsearch/ambari-logsearch-web/src/app/components/variables.less
2dc6278
ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 1dee559
Diff: https://reviews.apache.org/r/62896/diff/1/
Testing
---
Executed 102 of 102 SUCCESS (3.194 secs / 3.174 secs)
Thanks,
Andrii Babiichuk
]
[INFO] BUILD SUCCESS
2. tested generated files manually
Thanks,
Andrii Babiichuk
SUCCESS (3.318 secs / 3.295 secs)
Thanks,
Andrii Babiichuk
/r/63587/diff/1/
Testing
---
Executed 109 of 109 SUCCESS (2.729 secs / 2.668 secs)
Thanks,
Andrii Babiichuk
CCESS (3.186 secs / 3.147 secs)
Thanks,
Andrii Babiichuk
/
Testing
---
Executed 121 of 121 SUCCESS (3.552 secs / 3.496 secs)
Thanks,
Andrii Babiichuk
67d0615
ambari-logsearch/ambari-logsearch-web/webpack.config.js 7a60df2
Diff: https://reviews.apache.org/r/63697/diff/1/
Testing
---
Executed 140 of 140 SUCCESS (3.709 secs / 3.654 secs)
Thanks,
Andrii Babiichuk
s
a4a0cf8
ambari-logsearch/ambari-logsearch-web/src/app/services/utils.service.ts
3448dd4
Diff: https://reviews.apache.org/r/63734/diff/1/
Testing
---
Executed 203 of 203 SUCCESS (4.088 secs / 4.039 secs)
Thanks,
Andrii Babiichuk
-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 16b4b32
Diff: https://reviews.apache.org/r/63758/diff/1/
Testing
---
Executed 205 of 205 SUCCESS (4.258 secs / 4.209 secs)
Thanks,
Andrii Babiichuk
/
Testing
---
Executed 206 of 206 SUCCESS (8.096 secs / 8.004 secs)
Thanks,
Andrii Babiichuk
211 of 211 SUCCESS (4.882 secs / 4.796 secs)
Thanks,
Andrii Babiichuk
src/assets/i18n/en.json b214a4f
Diff: https://reviews.apache.org/r/64036/diff/1/
Testing
---
Executed 211 of 211 SUCCESS (4.731 secs / 4.643 secs)
Thanks,
Andrii Babiichuk
hanks,
Andrii Babiichuk
-logsearch-web/webpack.config.js 75d6aee
Diff: https://reviews.apache.org/r/64214/diff/1/
Testing
---
Executed 211 of 211 SUCCESS (4.549 secs / 4.463 secs)
Thanks,
Andrii Babiichuk
ogsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts
4adf577
ambari-logsearch/ambari-logsearch-web/yarn.lock c005503
Diff: https://reviews.apache.org/r/64411/diff/1/
Testing
---
Executed 216 of 216 SUCCESS (4.525 secs / 4.447 secs)
Thanks,
Andrii Babiichuk
16 SUCCESS (4.644 secs / 4.562 secs)
Thanks,
Andrii Babiichuk
ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 6c916aa
Diff: https://reviews.apache.org/r/64446/diff/1/
Testing
---
Executed 221 of 221 SUCCESS (5.452 secs / 5.358 secs)
Thanks,
Andrii Babiichuk
8n/en.json 3f4f5c8
Diff: https://reviews.apache.org/r/64679/diff/1/
Testing
---
Executed 221 of 221 SUCCESS (6.166 secs / 6.035 secs)
Thanks,
Andrii Babiichuk
64716/diff/1/
Testing
---
Executed 221 of 221 SUCCESS (7.013 secs / 6.895 secs)
Thanks,
Andrii Babiichuk
ambari-logsearch/ambari-logsearch-web/src/vendor/js/bootstrap-logsearch.min.js
a1b68d2
ambari-logsearch/ambari-logsearch-web/yarn.lock 8eb2bbd
Diff: https://reviews.apache.org/r/64886/diff/1/
Testing
---
Executed 241 of 241 SUCCESS (5.832 secs / 5.734 secs)
Thanks,
Andrii Babiichuk
242 SUCCESS (5.417 secs / 5.343 secs)
Thanks,
Andrii Babiichuk
85 matches
Mail list logo