ote:
> Rephrase: Cluster Aggregation will *now* occur at topology level
>
> Jungtaek Lim wrote:
> > Only thing to consider is whether we need task metrics to be aggregated
> across topology? If yes, taskId cannot be part of the metric name.
>
> It depends on use
n automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48065/#review136468
---
On 6 3, 2016, 12:43 오전, Jungtaek Lim wrote:
>
> ---
> This is an automa
:50:33+09:00
[INFO] Final Memory: 24M/300M
[INFO] ----
```
Thanks,
Jungtaek Lim
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48395/#review137086
-------
On 6 10, 2016, 12:50 오전, Jungtaek Lim wrote:
>
>
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48395/#review137086
---
On 6 10, 2016, 12:50 오전, Jungtaek Lim wrote:
>
> ---
> On 6 9, 2016, 5:42 오후, Aravindan Vijayan wrote:
> > Please add Dmitry Sen as well. Thanks
>
> Jungtaek Lim wrote:
> Could you tell what's Dmitry's ID? Auto-complete can't find Dmitry Sen.
>
> Aravindan Vijayan wrote:
> dsen
I just found it. His name is re
To reply, visit:
https://reviews.apache.org/r/48395/#review136855
---
On 6 9, 2016, 4:46 오후, Jungtaek Lim wrote:
>
> ---
> This is an automatically generated e-mail. To rep
...
npm WARN install:fsevents fsevents@0.2.1 install: `node-gyp rebuild`
npm WARN install:fsevents Exit status 1
```
No luck on `npm install`, too.
Thanks,
Jungtaek Lim
/fsevents
> node-gyp rebuild
...
npm WARN install:fsevents fsevents@0.2.1 install: `node-gyp rebuild`
npm WARN install:fsevents Exit status 1
```
No luck on `npm install`, too.
Thanks,
Jungtaek Lim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48065/
---
Review request for Ambari.
Bugs: AMBARI-16949
//reviews.apache.org/r/48395/#review138870
---
On 6 22, 2016, 2:09 오전, Jungtaek Lim wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 43.037 s
[INFO] Finished at: 2016-06-08T14:50:33+09:00
[INFO] Final Memory: 24M/300M
[INFO] ----
```
Thanks,
Jungtaek Lim
ries Aggregation. We need to have
> > a "none" option, and "sum" shouldn't be set as the default option.
>
> Jungtaek Lim wrote:
> There's check button on the UI (target.shouldAggregateSeries) and series
> aggregation only works when button is checked. Please let
INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 43.037 s
[INFO] Finished at: 2016-06-08T14:50:33+09:00
[INFO] Final Memory: 24M/300M
[INFO] ----
```
Thanks,
Jungtaek Lim
ries Aggregation. We need to have
> > a "none" option, and "sum" shouldn't be set as the default option.
>
> Jungtaek Lim wrote:
> There's check button on the UI (target.shouldAggregateSeries) and series
> aggregation only works when button is checked. Please let
ing enable/disable series aggregation. Thanks!
- Jungtaek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48395/#review137790
------
can imagine how it will make
change.
Thanks,
Jungtaek Lim
Thanks,
Jungtaek Lim
can also close issue AMBARI-17416 as duplicated
or take over.
- Jungtaek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49173/#review139384
-------
c4b54b4
Diff: https://reviews.apache.org/r/49249/diff/
Testing
---
Tested locally. Attached screenshot to origin issue.
https://issues.apache.org/jira/secure/attachment/12813582/AMBARI-17445-changes.png
Thanks,
Jungtaek Lim
/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
c4b54b4
Diff: https://reviews.apache.org/r/48840/diff/
Testing
---
mvn test succeed
applied and tested manually (via 2.4 branch)
Thanks,
Jungtaek Lim
> On 7 27, 2016, 2:31 오전, Jungtaek Lim wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml,
> > line 54
> > <https://reviews.apache.org/r/50479/diff/1/?file=1454635#file1454635line54>
> >
> > T
t; > we should make this as true on-upgrade no?
>
> Jungtaek Lim wrote:
> To tell the truth I don't understand how this tag works.
> Could you elaborate how on-ambari-upgrade works, and also could you check
> all the properties in this pom?
> Other
branch without Ignore annotation)
- Tested manually with STORM-2006 pre-applied cluster
Thanks,
Jungtaek Lim
: https://reviews.apache.org/r/50479/diff/
Testing
---
- Build succeed (build passed with 2.4 branch without Ignore annotation)
- Tested manually with STORM-2006 pre-applied cluster
Thanks,
Jungtaek Lim
s to be in the
same line.
- Jungtaek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50479/#review143652
-------
On
Tested manually
Thanks,
Jungtaek Lim
ferent between legacy and
current.
- Jungtaek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50180/#review142812
--------
/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
c76197b
Diff: https://reviews.apache.org/r/50063/diff/
Testing
---
Build OK via `mvn clean install` for both of storm-sink and storm-sink-legacy.
Tested manually.
Thanks,
Jungtaek Lim
3582/AMBARI-17445-changes.png
Thanks,
Jungtaek Lim
/12813582/AMBARI-17445-changes.png
Thanks,
Jungtaek Lim
> On 7 4, 2016, 2:09 오전, Jungtaek Lim wrote:
> > Ship It!
Looks good to me overall. I assumed 'ambari-metrics-storm-legacy' is just a
copy of previous 'ambari-metrics-storm'.
- Jungtaek
---
This is an automatically generat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140599
---
Ship it!
Ship It!
- Jungtaek Lim
On 7 3, 2016, 1:23 오후
On July 1, 2016, 3:32 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
>
> (Updated July 1, 2016, 3:32 p.m.)
>
>
> Review request for A
---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> -------
>
> (Updated July 1, 2016, 3:32 p.m.)
>
>
> Review reques
logfeeder config? Then
LGTM.
- Jungtaek Lim
On 12월 11, 2017, 11:47 오후, Oliver Szabo wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
tests
- manual tests (manually deploying to cluster)
Thanks,
Jungtaek Lim
the change to configuration of test cluster, and confirmed it
works.
It doesn't mean I have tested it with upgrading, so please consider verifying
it works well with various upgrade cases.
Thanks,
Jungtaek Lim
Diff: https://reviews.apache.org/r/64837/diff/1/
Testing
---
Manually applied the change to configuration of test cluster, and confirmed it
works.
It doesn't mean I have tested it with upgrading, so please consider verifying
it works well with various upgrade cases.
Thanks,
Jungtaek
view board
for trunk branch.
- Jungtaek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64837/#review194559
---
On 12월 25, 2017, 4:38 오
40 matches
Mail list logo