Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review155115 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 7, 2016,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review155114 ---

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/ --- (Updated Nov. 7, 2016, 9:40 a.m.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153693 --- ambari-agent/src/main/python/ambari_agent/ActionQueue.py (line

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/ --- (Updated Oct. 24, 2016, 3:18 p.m.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/ --- (Updated Oct. 24, 2016, 3:16 p.m.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153451 --- Fix it, then Ship it! Pending unit tests for the patch, +1 for

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153444 ---

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

> On Oct. 20, 2016, 6:11 p.m., Andrew Onischuk wrote: > > The blacklisting logic we previously were implementing is not needed now > > (as disscussed with Sid). > > > > Reasons for that: > > 1. If command takes more than 5 seconds, the executor will just restart > > itself and continue to

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153434 --- The blacklisting logic we previously were implementing is not

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

> On Oct. 20, 2016, 4:52 p.m., Sid Wagle wrote: > > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py, line 56 > > > > > > This looks weird I would think you would need a > >

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153416 ---

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/ --- (Updated Oct. 20, 2016, 3:54 p.m.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153406 --- This is preliminary version of the patch. Basically to have the

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/ --- (Updated Oct. 20, 2016, 3:50 p.m.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review151158 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 3, 2016,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review151155 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 3, 2016,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/ --- (Updated Oct. 3, 2016, 9:38 a.m.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review151153 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 3, 2016,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/ --- (Updated Oct. 3, 2016, 9:19 a.m.) Review request for Ambari and Dmitro

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review151049 --- So we are still slowing down heartbeat status by 5 seconds and