Re: Review Request 44700: Ambari Views : each view should have separate log file for better troubleshooting

2016-03-22 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44700/
---

(Updated March 22, 2016, 1:03 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, and 
Yusaku Sako.


Changes
---

added proper indentation in the apache licence comments as per the standards.


Bugs: AMBARI-14084
https://issues.apache.org/jira/browse/AMBARI-14084


Repository: ambari


Description
---

Earlier : 
logs of all the views used to go into ambari-server.log which caused problem in 
debugging views.

In this Patch:
ViewRegistry now looks for file
 view.log4j.properties using the view archive classloader and loads all the
 log4j properties in it using PropertyConfigurator. Separate log4j
 configuraiton files added to all core views.


Diffs (updated)
-

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
6a01351 
  contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
144926a 
  contrib/views/files/src/main/resources/view.log4j.properties b47fd80 
  contrib/views/hive/src/main/resources/view.log4j.properties 3e9454b 
  contrib/views/jobs/src/main/resources/view.log4j.properties da54ebf 
  contrib/views/pig/src/main/resources/view.log4j.properties fcd57eb 
  contrib/views/slider/src/main/resources/view.log4j.properties 68541af 
  contrib/views/storm/src/main/resources/view.log4j.properties 3383137 
  contrib/views/tez/src/main/resources/view.log4j.properties ae1f5ce 

Diff: https://reviews.apache.org/r/44700/diff/


Testing
---

Manual Testing Done.
separate log files for each view was properly generated. Also the log level was 
getting properly set.


Thanks,

Nitiraj Rathore

Re: Review Request 44700: Ambari Views : each view should have separate log file for better troubleshooting

2016-03-22 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44700/#review124774
---




contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties (line 
8)


Try to give a space after #. Just from the conventions point of view.


- DIPAYAN BHOWMICK


On March 22, 2016, 10:20 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44700/
> ---
> 
> (Updated March 22, 2016, 10:20 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14084
> https://issues.apache.org/jira/browse/AMBARI-14084
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : 
> logs of all the views used to go into ambari-server.log which caused problem 
> in debugging views.
> 
> In this Patch:
> ViewRegistry now looks for file
>  view.log4j.properties using the view archive classloader and loads all the
>  log4j properties in it using PropertyConfigurator. Separate log4j
>  configuraiton files added to all core views.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 6a01351 
>   contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
> 144926a 
>   contrib/views/files/src/main/resources/view.log4j.properties b47fd80 
>   contrib/views/hive/src/main/resources/view.log4j.properties 3e9454b 
>   contrib/views/jobs/src/main/resources/view.log4j.properties da54ebf 
>   contrib/views/pig/src/main/resources/view.log4j.properties fcd57eb 
>   contrib/views/slider/src/main/resources/view.log4j.properties 68541af 
>   contrib/views/storm/src/main/resources/view.log4j.properties 3383137 
>   contrib/views/tez/src/main/resources/view.log4j.properties ae1f5ce 
> 
> Diff: https://reviews.apache.org/r/44700/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing Done.
> separate log files for each view was properly generated. Also the log level 
> was getting properly set.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 44700: Ambari Views : each view should have separate log file for better troubleshooting

2016-03-22 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44700/
---

(Updated March 22, 2016, 10:20 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, and 
Yusaku Sako.


Changes
---

added apache licence and incorporated review comments


Bugs: AMBARI-14084
https://issues.apache.org/jira/browse/AMBARI-14084


Repository: ambari


Description
---

Earlier : 
logs of all the views used to go into ambari-server.log which caused problem in 
debugging views.

In this Patch:
ViewRegistry now looks for file
 view.log4j.properties using the view archive classloader and loads all the
 log4j properties in it using PropertyConfigurator. Separate log4j
 configuraiton files added to all core views.


Diffs (updated)
-

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
6a01351 
  contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
144926a 
  contrib/views/files/src/main/resources/view.log4j.properties b47fd80 
  contrib/views/hive/src/main/resources/view.log4j.properties 3e9454b 
  contrib/views/jobs/src/main/resources/view.log4j.properties da54ebf 
  contrib/views/pig/src/main/resources/view.log4j.properties fcd57eb 
  contrib/views/slider/src/main/resources/view.log4j.properties 68541af 
  contrib/views/storm/src/main/resources/view.log4j.properties 3383137 
  contrib/views/tez/src/main/resources/view.log4j.properties ae1f5ce 

Diff: https://reviews.apache.org/r/44700/diff/


Testing
---

Manual Testing Done.
separate log files for each view was properly generated. Also the log level was 
getting properly set.


Thanks,

Nitiraj Rathore

Re: Review Request 44700: Ambari Views : each view should have separate log file for better troubleshooting

2016-03-19 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44700/#review124000
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On March 15, 2016, 12:20 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44700/
> ---
> 
> (Updated March 15, 2016, 12:20 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14084
> https://issues.apache.org/jira/browse/AMBARI-14084
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : 
> logs of all the views used to go into ambari-server.log which caused problem 
> in debugging views.
> 
> In this Patch:
> ViewRegistry now looks for file
>  view.log4j.properties using the view archive classloader and loads all the
>  log4j properties in it using PropertyConfigurator. Separate log4j
>  configuraiton files added to all core views.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> e31037e 
>   contrib/views/capacity-scheduler/pom.xml 5569859 
>   contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
> PRE-CREATION 
>   contrib/views/files/pom.xml ccea5ab 
>   contrib/views/files/src/main/resources/view.log4j.properties PRE-CREATION 
>   contrib/views/hive/pom.xml 1f150ff 
>   contrib/views/hive/src/main/resources/view.log4j.properties PRE-CREATION 
>   contrib/views/jobs/pom.xml d797ebd 
>   contrib/views/jobs/src/main/resources/view.log4j.properties PRE-CREATION 
>   contrib/views/pig/pom.xml 97160cc 
>   contrib/views/pig/src/main/resources/view.log4j.properties PRE-CREATION 
>   contrib/views/slider/pom.xml 608988f 
>   contrib/views/slider/src/main/resources/view.log4j.properties PRE-CREATION 
>   contrib/views/storm/src/main/resources/view.log4j.properties PRE-CREATION 
>   contrib/views/tez/pom.xml 8e82c5e 
>   contrib/views/tez/src/main/resources/view.log4j.properties PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44700/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing Done.
> separate log files for each view was properly generated. Also the log level 
> was getting properly set.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 44700: Ambari Views : each view should have separate log file for better troubleshooting

2016-03-15 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44700/
---

(Updated March 15, 2016, 12:20 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, and 
Yusaku Sako.


Changes
---

New patch submitted after incorporating changes in the comments.
1. now log level is INFO for views
2. log directory is separate for all views.


Bugs: AMBARI-14084
https://issues.apache.org/jira/browse/AMBARI-14084


Repository: ambari


Description
---

Earlier : 
logs of all the views used to go into ambari-server.log which caused problem in 
debugging views.

In this Patch:
ViewRegistry now looks for file
 view.log4j.properties using the view archive classloader and loads all the
 log4j properties in it using PropertyConfigurator. Separate log4j
 configuraiton files added to all core views.


Diffs (updated)
-

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
e31037e 
  contrib/views/capacity-scheduler/pom.xml 5569859 
  contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
PRE-CREATION 
  contrib/views/files/pom.xml ccea5ab 
  contrib/views/files/src/main/resources/view.log4j.properties PRE-CREATION 
  contrib/views/hive/pom.xml 1f150ff 
  contrib/views/hive/src/main/resources/view.log4j.properties PRE-CREATION 
  contrib/views/jobs/pom.xml d797ebd 
  contrib/views/jobs/src/main/resources/view.log4j.properties PRE-CREATION 
  contrib/views/pig/pom.xml 97160cc 
  contrib/views/pig/src/main/resources/view.log4j.properties PRE-CREATION 
  contrib/views/slider/pom.xml 608988f 
  contrib/views/slider/src/main/resources/view.log4j.properties PRE-CREATION 
  contrib/views/storm/src/main/resources/view.log4j.properties PRE-CREATION 
  contrib/views/tez/pom.xml 8e82c5e 
  contrib/views/tez/src/main/resources/view.log4j.properties PRE-CREATION 

Diff: https://reviews.apache.org/r/44700/diff/


Testing
---

Manual Testing Done.
separate log files for each view was properly generated. Also the log level was 
getting properly set.


Thanks,

Nitiraj Rathore

Re: Review Request 44700: Ambari Views : each view should have separate log file for better troubleshooting

2016-03-14 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44700/#review123386
---




contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties (line 
2)


Do you think it will be better if we add these log files into their own 
folder inside the /var/log/ambari-server directory. Like, hive-view logs can be 
inside: /var/log/ambari-server/hive-view/hive-view.log

In future if a developer wants to add some other logs along with the view 
log, it will be compartmentalized inside its own directory.



contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties (line 
8)


Modify log level in all the view log4j properties to INFO


- DIPAYAN BHOWMICK


On March 11, 2016, 7:52 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44700/
> ---
> 
> (Updated March 11, 2016, 7:52 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14084
> https://issues.apache.org/jira/browse/AMBARI-14084
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : 
> logs of all the views used to go into ambari-server.log which caused problem 
> in debugging views.
> 
> In this Patch:
> ViewRegistry now looks for file
>  view.log4j.properties using the view archive classloader and loads all the
>  log4j properties in it using PropertyConfigurator. Separate log4j
>  configuraiton files added to all core views.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> e31037e 
>   contrib/views/capacity-scheduler/pom.xml 5569859 
>   contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
> PRE-CREATION 
>   contrib/views/files/pom.xml ccea5ab 
>   contrib/views/files/src/main/resources/view.log4j.properties PRE-CREATION 
>   contrib/views/hive/pom.xml 1f150ff 
>   contrib/views/hive/src/main/resources/view.log4j.properties PRE-CREATION 
>   contrib/views/jobs/pom.xml d797ebd 
>   contrib/views/jobs/src/main/resources/view.log4j.properties PRE-CREATION 
>   contrib/views/pig/pom.xml 97160cc 
>   contrib/views/pig/src/main/resources/view.log4j.properties PRE-CREATION 
>   contrib/views/slider/pom.xml 608988f 
>   contrib/views/slider/src/main/resources/view.log4j.properties PRE-CREATION 
>   contrib/views/storm/src/main/resources/view.log4j.properties PRE-CREATION 
>   contrib/views/tez/pom.xml 8e82c5e 
>   contrib/views/tez/src/main/resources/view.log4j.properties PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44700/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing Done.
> separate log files for each view was properly generated. Also the log level 
> was getting properly set.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 44700: Ambari Views : each view should have separate log file for better troubleshooting

2016-03-10 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44700/
---

Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, and 
Yusaku Sako.


Bugs: AMBARI-14084
https://issues.apache.org/jira/browse/AMBARI-14084


Repository: ambari


Description
---

Earlier : 
logs of all the views used to go into ambari-server.log which caused problem in 
debugging views.

In this Patch:
ViewRegistry now looks for file
 view.log4j.properties using the view archive classloader and loads all the
 log4j properties in it using PropertyConfigurator. Separate log4j
 configuraiton files added to all core views.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
e31037e 
  contrib/views/capacity-scheduler/pom.xml 5569859 
  contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
PRE-CREATION 
  contrib/views/files/pom.xml ccea5ab 
  contrib/views/files/src/main/resources/view.log4j.properties PRE-CREATION 
  contrib/views/hive/pom.xml 1f150ff 
  contrib/views/hive/src/main/resources/view.log4j.properties PRE-CREATION 
  contrib/views/jobs/pom.xml d797ebd 
  contrib/views/jobs/src/main/resources/view.log4j.properties PRE-CREATION 
  contrib/views/pig/pom.xml 97160cc 
  contrib/views/pig/src/main/resources/view.log4j.properties PRE-CREATION 
  contrib/views/slider/pom.xml 608988f 
  contrib/views/slider/src/main/resources/view.log4j.properties PRE-CREATION 
  contrib/views/storm/src/main/resources/view.log4j.properties PRE-CREATION 
  contrib/views/tez/pom.xml 8e82c5e 
  contrib/views/tez/src/main/resources/view.log4j.properties PRE-CREATION 

Diff: https://reviews.apache.org/r/44700/diff/


Testing
---

Manual Testing Done.
separate log files for each view was properly generated. Also the log level was 
getting properly set.


Thanks,

Nitiraj Rathore