Re: Review Request 45208: Cleanup LDAP sync process

2016-03-30 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/#review126120 --- Ship it! Ship It! - Robert Levas On March 30, 2016, 11:25 a.

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-30 Thread Oliver Szabo
> On March 30, 2016, 2:05 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapUtils.java, > > line 62 > > > > > > `full` is never `null`? No, during cr

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-30 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/ --- (Updated March 30, 2016, 3:25 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-30 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/#review126103 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-30 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/#review126068 --- Ship it! Ship It! - Sebastian Toader On March 30, 2016, 11:2

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-30 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/ --- (Updated March 30, 2016, 9:28 a.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-29 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/#review126041 --- ambari-server/src/main/java/org/apache/ambari/server/security/lda

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/ --- (Updated March 29, 2016, 4:06 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/ --- (Updated March 29, 2016, 10:03 a.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-29 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/#review125834 --- ambari-server/conf/unix/log4j.properties (line 79)

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-28 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/ --- (Updated March 28, 2016, 8:23 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-24 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/#review125231 --- ambari-server/src/main/java/org/apache/ambari/server/security/lda

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-23 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/ --- (Updated March 23, 2016, 1:28 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-23 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/#review125019 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-23 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/#review125008 --- Ship it! Ship It! - Daniel Gergely On márc. 23, 2016, 11:45

Review Request 45208: Cleanup LDAP sync process

2016-03-23 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/ --- Review request for Ambari, Daniel Gergely, Robert Levas, and Sebastian Toader.