Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread bhuvnesh chaudhary 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review134032
---


Ship it!




Ship It!

- bhuvnesh chaudhary


On May 19, 2016, 6:58 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47580/
> ---
> 
> (Updated May 19, 2016, 6:58 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16752
> https://issues.apache.org/jira/browse/AMBARI-16752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In service install wizard, pxf-hbase.jar should be added to the 
> HBASE_CLASSPATH (recommendation and validation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> e2510eb 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47580/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Unit tests added.
> 
> ```
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF does not get recommended during Add Service Wizard, when PXF 
> has already been installed ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Add Service Wizard, when PXF 
> is selected for installation ... ok
> test_createComponentLayoutRecommendations_pxf_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Cluster Install Wizard, when 
> PXF is selected for installation ... ok
> test_getComponentLayoutValidations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test layout validations for HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test validation warning for HAWQ segment not colocated with DATANODE ... ok
> test_getComponentLayoutValidations_nohawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test NO warning is generated when PXF is co-located with NAMENODE and 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_sparkts_no_hive 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test SparkTS is picked when Hive is not installed ... ok
> test_getComponentLayoutValidations_sparkts_with_hive 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test SparkTS is picked when Hive is installed ... ok
> test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_recommendFalconConfigurations (

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread Matt 


> On May 19, 2016, 10:14 a.m., Lav Jain wrote:
> > ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py, line 
> > 29
> > 
> >
> > Not sure if loading of PXFServiceAdvisor is necessary. The test should 
> > call stackAdvisor directly and that should automatically load PXF service 
> > advisor for the corresponding routines.

Unit test would call service_advisor, and stack_advisor loading will be deleted 
in the future.

This would be fixed after https://issues.apache.org/jira/browse/AMBARI-16663


- Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review133974
---


On May 19, 2016, 11:58 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47580/
> ---
> 
> (Updated May 19, 2016, 11:58 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16752
> https://issues.apache.org/jira/browse/AMBARI-16752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In service install wizard, pxf-hbase.jar should be added to the 
> HBASE_CLASSPATH (recommendation and validation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> e2510eb 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47580/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Unit tests added.
> 
> ```
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF does not get recommended during Add Service Wizard, when PXF 
> has already been installed ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Add Service Wizard, when PXF 
> is selected for installation ... ok
> test_createComponentLayoutRecommendations_pxf_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Cluster Install Wizard, when 
> PXF is selected for installation ... ok
> test_getComponentLayoutValidations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test layout validations for HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test validation warning for HAWQ segment not colocated with DATANODE ... ok
> test_getComponentLayoutValidations_nohawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test NO warning is generated when PXF is co-located with NAMENODE and 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread Lav Jain 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review134019
---


Ship it!




Ship It!

- Lav Jain


On May 19, 2016, 6:58 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47580/
> ---
> 
> (Updated May 19, 2016, 6:58 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16752
> https://issues.apache.org/jira/browse/AMBARI-16752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In service install wizard, pxf-hbase.jar should be added to the 
> HBASE_CLASSPATH (recommendation and validation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> e2510eb 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47580/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Unit tests added.
> 
> ```
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF does not get recommended during Add Service Wizard, when PXF 
> has already been installed ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Add Service Wizard, when PXF 
> is selected for installation ... ok
> test_createComponentLayoutRecommendations_pxf_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Cluster Install Wizard, when 
> PXF is selected for installation ... ok
> test_getComponentLayoutValidations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test layout validations for HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test validation warning for HAWQ segment not colocated with DATANODE ... ok
> test_getComponentLayoutValidations_nohawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test NO warning is generated when PXF is co-located with NAMENODE and 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_sparkts_no_hive 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test SparkTS is picked when Hive is not installed ... ok
> test_getComponentLayoutValidations_sparkts_with_hive 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test SparkTS is picked when Hive is installed ... ok
> test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_recommendFalconConfigurations (test_stack

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread Matt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/
---

(Updated May 19, 2016, 11:58 a.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.


Bugs: AMBARI-16752
https://issues.apache.org/jira/browse/AMBARI-16752


Repository: ambari


Description
---

In service install wizard, pxf-hbase.jar should be added to the HBASE_CLASSPATH 
(recommendation and validation)


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
e2510eb 
  ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/47580/diff/


Testing
---

Manually Tested.

Unit tests added.

```
test_createComponentLayoutRecommendations_hawq_1_Host 
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_createComponentLayoutRecommendations_hawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT does not get recommended during Add Service Wizard, when 
HAWQ has already been installed ... ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
when HAWQ is selected for installation ... ok
test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Cluster Install Wizard, 
when HAWQ is selected for installation ... ok
test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF does not get recommended during Add Service Wizard, when PXF has 
already been installed ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Add Service Wizard, when PXF is 
selected for installation ... ok
test_createComponentLayoutRecommendations_pxf_cluster_install 
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Cluster Install Wizard, when 
PXF is selected for installation ... ok
test_getComponentLayoutValidations_hawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test layout validations for HAWQ components on a 3-node cluster ... ok
test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
(test_stack_advisor.TestHDP23StackAdvisor)
Test validation warning for HAWQ segment not colocated with DATANODE ... ok
test_getComponentLayoutValidations_nohawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components on a 3-node cluster ... ok
test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
(test_stack_advisor.TestHDP23StackAdvisor)
Test NO warning is generated when PXF is co-located with NAMENODE and DATANODE 
... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE 
... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn 
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE ... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn 
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE 
... ok
test_getComponentLayoutValidations_sparkts_no_hive 
(test_stack_advisor.TestHDP23StackAdvisor)
Test SparkTS is picked when Hive is not installed ... ok
test_getComponentLayoutValidations_sparkts_with_hive 
(test_stack_advisor.TestHDP23StackAdvisor)
Test SparkTS is picked when Hive is installed ... ok
test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendFalconConfigurations (test_stack_advisor.TestHDP23StackAdvisor) 
... ok
test_recommendHAWQConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... 
ok
test_recommendHBASEConfigurations (test_stack_advisor.TestHDP23StackAdvisor) 
... ok
test_recommendHDFSConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... 
ok
test_recommendHiveConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... 
ok
test_recommendHiveConfigurations_with_atlas 
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendKAFKAConfigurations (test_stack_adv

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread Matt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/
---

(Updated May 19, 2016, 11:55 a.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.


Bugs: AMBARI-16752
https://issues.apache.org/jira/browse/AMBARI-16752


Repository: ambari


Description
---

In service install wizard, pxf-hbase.jar should be added to the HBASE_CLASSPATH 
(recommendation and validation)


Diffs (updated)
-

  ambari-admin/src/main/resources/ui/admin-web/app/index.html 9344f15 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersEditCtrl.js
 5420ae5 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
3ed2687 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/DeregisterClusterModal.js
 174c0d6 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RemoteCluster.js
 1c5f588 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
 2481d59 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/modals/deregisterClusterModal.html
 e6c67ca 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html
 8979cba 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html 
7f525e8 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/modals/changePassword.html
 55611a0 
  ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 87d9483 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py
 260f018 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 0fb017d 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
0dcbea8 
  ambari-server/conf/unix/ambari.properties 9f1692e 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 f5e8f39 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 9c2db1c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 b60592d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 36be39e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
 6f2a134 
  ambari-server/src/main/python/ambari_server/serverSetup.py f01465d 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
 119f2c7 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 b9b49e9 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
 abb47e5 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 9094f7f 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
 e3aff9d 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 abb8469 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 a1ffc5e 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 716b612 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 f285853 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
 81a4e3e 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 7a68a32 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
 3a9f51e 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 5d454de 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
 d4eb6b9 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 dd3a692 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 2f091a5 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 b76bc89 
  ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
e2510eb 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 d4418e0 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
 3dc4914 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 0a39219 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread Alexander Denissov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review133977
---




ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
(line 74)


I would check only for presence of pxf-hbase.jar string, in case users edit 
the content with extra information



ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
(line 84)


here as well, just check for the jar



ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
(line 86)


pxf-hbase.jar -- h is missing


- Alexander Denissov


On May 19, 2016, 6:11 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47580/
> ---
> 
> (Updated May 19, 2016, 6:11 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16752
> https://issues.apache.org/jira/browse/AMBARI-16752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In service install wizard, pxf-hbase.jar should be added to the 
> HBASE_CLASSPATH (recommendation and validation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> e2510eb 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47580/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Unit tests added.
> 
> Hadoop QA:
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12804840/AMBARI-16752-trunk-orig.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread Lav Jain 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review133985
---



Should we create a services/PXF directory under 
ambari-server/src/test/python/stacks or continue to put the common-services 
tests under 2.3 stack?

- Lav Jain


On May 19, 2016, 6:11 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47580/
> ---
> 
> (Updated May 19, 2016, 6:11 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16752
> https://issues.apache.org/jira/browse/AMBARI-16752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In service install wizard, pxf-hbase.jar should be added to the 
> HBASE_CLASSPATH (recommendation and validation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> e2510eb 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47580/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Unit tests added.
> 
> Hadoop QA:
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12804840/AMBARI-16752-trunk-orig.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread Lav Jain 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review133974
---




ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py (line 29)


Not sure if loading of PXFServiceAdvisor is necessary. The test should call 
stackAdvisor directly and that should automatically load PXF service advisor 
for the corresponding routines.


- Lav Jain


On May 19, 2016, 6:11 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47580/
> ---
> 
> (Updated May 19, 2016, 6:11 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16752
> https://issues.apache.org/jira/browse/AMBARI-16752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In service install wizard, pxf-hbase.jar should be added to the 
> HBASE_CLASSPATH (recommendation and validation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> e2510eb 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47580/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Unit tests added.
> 
> Hadoop QA:
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12804840/AMBARI-16752-trunk-orig.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Matt
> 
>

Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-18 Thread Matt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.


Bugs: AMBARI-16752
https://issues.apache.org/jira/browse/AMBARI-16752


Repository: ambari


Description
---

In service install wizard, pxf-hbase.jar should be added to the HBASE_CLASSPATH 
(recommendation and validation)


Diffs
-

  ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
e2510eb 
  ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/47580/diff/


Testing
---

Manually Tested.

Unit tests added.

Hadoop QA:
```
+1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12804840/AMBARI-16752-trunk-orig.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6889//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6889//console
This message is automatically generated.
```


Thanks,

Matt