Re: Review Request 45212: Remove hard dependency on a specific mesos-version

2016-03-23 Thread Zameer Manji
> On March 23, 2016, 7:31 a.m., Stephan Erb wrote: > > Thinking out loud here, so please comment: > > > > We could move to a mode where we build against a specific Mesos version, > > and recommend that version for deployment, but leave it up to the cluster > > operator to select and deploy a

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-23 Thread John Sirois
> On March 23, 2016, 1:36 p.m., Zameer Manji wrote: > > I am in favor of making this change. However, it seems this patch could be > > improved because the storage layer has to now check for both `null` and > > empty collection. > > > > I think a better solution would be to change Query.Builder

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/#review125102 --- I am in favor of making this change. However, it seems this patch

Review Request 45206: HTTPLifeCycleConfig to HttpLifeCycleConfig typo

2016-03-23 Thread se choi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45206/ --- Review request for Aurora. Repository: aurora Description ---

Re: Review Request 45206: HTTPLifeCycleConfig to HttpLifeCycleConfig typo

2016-03-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45206/#review125000 --- Ship it! Master (c66a9ee) is green with this patch.

Re: Review Request 45206: HTTPLifeCycleConfig to HttpLifeCycleConfig typo

2016-03-23 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45206/#review125017 --- Thanks Se! I'll patch this in presently. - John Sirois On

Re: Review Request 45206: HTTPLifeCycleConfig to HttpLifeCycleConfig typo

2016-03-23 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45206/#review125016 --- Ship it! Ship It! - John Sirois On March 23, 2016, 3:35

Review Request 45212: Remove hard dependency on a specific mesos-version

2016-03-23 Thread Pierre Cheynier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45212/ --- Review request for Aurora. Repository: aurora-packaging Description ---

Re: Review Request 45212: Remove hard dependency on a specific mesos-version

2016-03-23 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45212/#review125020 --- specs/rpm/aurora.spec (line 100)

Re: Review Request 45172: Tweak update-sources script to also update mesos config.

2016-03-23 Thread Joshua Cohen
> On March 23, 2016, 3:26 a.m., Bill Farner wrote: > > examples/vagrant/provision-dev-cluster.sh, lines 89-92 > > > > > > Echoing IRC discussion: i'm -1 to this change because it copies sources > > but does not

Re: Review Request 45167: Fixup install docs.

2016-03-23 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45167/#review125031 --- riceb86 - I'm going to submit this now, but I'll happily circle

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-23 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/#review125024 --- I think this change stands on its own aside from the current

Re: Review Request 45167: Fixup install docs.

2016-03-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45167/#review125029 --- Ship it! Ship It! - Stephan Erb On March 22, 2016, 11:40

Re: Review Request 45212: Remove hard dependency on a specific mesos-version

2016-03-23 Thread John Sirois
> On March 23, 2016, 8:31 a.m., Stephan Erb wrote: > > Thinking out loud here, so please comment: > > > > We could move to a mode where we build against a specific Mesos version, > > and recommend that version for deployment, but leave it up to the cluster > > operator to select and deploy a

Re: Review Request 45212: Remove hard dependency on a specific mesos-version

2016-03-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45212/#review125027 --- Thinking out loud here, so please comment: We could move to a

Re: Review Request 45212: Remove hard dependency on a specific mesos-version

2016-03-23 Thread Stephan Erb
> On March 23, 2016, 3:31 p.m., Stephan Erb wrote: > > Thinking out loud here, so please comment: > > > > We could move to a mode where we build against a specific Mesos version, > > and recommend that version for deployment, but leave it up to the cluster > > operator to select and deploy a

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-23 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/ --- (Updated March 23, 2016, 10:35 a.m.) Review request for Aurora, David Chung,

Re: Review Request 45212: Remove hard dependency on a specific mesos-version

2016-03-23 Thread Maxim Khutornenko
> On March 23, 2016, 2:31 p.m., Stephan Erb wrote: > > Thinking out loud here, so please comment: > > > > We could move to a mode where we build against a specific Mesos version, > > and recommend that version for deployment, but leave it up to the cluster > > operator to select and deploy a

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-23 Thread John Sirois
> On March 23, 2016, 8:35 a.m., John Sirois wrote: > > I think this change stands on its own aside from the current state of the > > generated Go thrift bindings, but there has been a good deal of discussion > > about those bindings offline. Some homework below. > > > > For the case of the

Re: Review Request 45212: Remove hard dependency on a specific mesos-version

2016-03-23 Thread Bill Farner
> On March 23, 2016, 7:31 a.m., Stephan Erb wrote: > > Thinking out loud here, so please comment: > > > > We could move to a mode where we build against a specific Mesos version, > > and recommend that version for deployment, but leave it up to the cluster > > operator to select and deploy a