Re: Review Request 49578: Close `PathChildrenCache` before its framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49578/#review140618 --- Ship it! Trusting your analysis, the patch looks sane to me. -

Re: Review Request 49512: [FEEDBACK] Add thermos option to monitor whole docker storage disk usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49512/#review140619 --- Have you considered querying Mesos for the disk usage of the task?

Review Request 49593: Upgrade to pants 1.1.0-pre6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/ --- Review request for Aurora and Stephan Erb. Bugs: AURORA-1620 https://issues

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/#review140660 --- pants.ini (line 21)

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/#review140663 --- Ship it! While I am OK with using a pre-release on master, I'd

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/#review140665 --- Master (311b892) is red with this patch. ./build-support/jenkins

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

> On July 4, 2016, 9:01 a.m., Stephan Erb wrote: > > While I am OK with using a pre-release on master, I'd really like to see us > > migrate to stable 1.1 before doing the next release of Aurora. We have never been on a stable yet, the naming scheme is just changed, ie `1.1.0-pre6` is somethin

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/#review140668 --- @ReviewBot retry - John Sirois On July 4, 2016, 8:52 a.m., John

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/#review140670 --- Ship it! Master (311b892) is green with this patch. ./build-s

Re: Review Request 49528: Patch thrift to compile under modern gcc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49528/#review140671 --- build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java

Review Request 49595: Fix thrift t_java_generator.ccc patch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49595/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1727 https://

Re: Review Request 49528: Patch thrift to compile under modern gcc.

> On July 4, 2016, 9:36 a.m., John Sirois wrote: > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch, > > line 8 > > > > > > This is a bug - should be `if (!first) {`. We don't hi

Re: Review Request 49595: Fix thrift t_java_generator.ccc patch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49595/#review140675 --- Ship it! Master (43db929) is green with this patch. ./build-s

Re: Review Request 49595: Fix thrift t_java_generator.ccc patch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49595/#review140692 --- Ship it! Ship It! - Maxim Khutornenko On July 4, 2016, 3:45