Re: Review Request 62857: Fix broken end-to-end tests

> On Oct. 10, 2017, 2:29 p.m., Joshua Cohen wrote: > > I'd be shocked if they've been failing for over a year. We've had three > > releases since then and the release candidate verification script runs the > > end to end tests. > > > > If I had to hazard a guess, I'd point the finger at

Re: Review Request 62857: Fix broken end-to-end tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62857/#review187535 --- I'd be shocked if they've been failing for over a year. We've had

Re: Review Request 62857: Fix broken end-to-end tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62857/#review187536 --- Ship it! Regardless... ship away! - Joshua Cohen On Oct.

Re: Review Request 62623: Use a simpler command line argument system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62623/ --- (Updated Oct. 10, 2017, 7:37 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 62763: Create Update Page with React

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62763/ --- (Updated Oct. 10, 2017, 5:02 p.m.) Review request for Aurora, Kai Huang and

Re: Review Request 62763: Create Update Page with React

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62763/#review187560 --- Master (2df250e) is red with this patch.

Re: Review Request 62763: Create Update Page with React

> On Oct. 6, 2017, 7:46 p.m., Santhosh Kumar Shanmugham wrote: > > ui/src/main/js/components/__tests__/InstanceViz-test.js > > Lines 23 (patched) > > > > > > nit - assert `medium` and `big` do not appear? Done. >

Re: Review Request 62763: Create Update Page with React

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62763/#review187558 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 10,

Re: Review Request 62623: Use a simpler command line argument system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62623/#review187539 --- Master (0169b81) is red with this patch.

Re: Review Request 62857: Fix broken end-to-end tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62857/#review187542 --- Ship it! Ship It! - Stephan Erb On Oct. 10, 2017, 8:21

Re: Review Request 62623: Use a simpler command line argument system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62623/#review187547 --- Master (0169b81) is red with this patch.

Re: Review Request 62857: Fix broken end-to-end tests

> On Oct. 10, 2017, 2:29 p.m., Joshua Cohen wrote: > > I'd be shocked if they've been failing for over a year. We've had three > > releases since then and the release candidate verification script runs the > > end to end tests. > > > > If I had to hazard a guess, I'd point the finger at

Re: Review Request 62857: Fix broken end-to-end tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62857/#review187540 --- I have been running the end-to-end tests from time to time and

Re: Review Request 62857: Fix broken end-to-end tests

> On Oct. 10, 2017, 4:59 p.m., Stephan Erb wrote: > > I have been running the end-to-end tests from time to time and have not > > seen this problem, yet. > > > > Code wide, I also don't think this should be necessary. We are defaulting > > to json if there is no accept header in order to

Re: Review Request 62623: Use a simpler command line argument system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62623/#review187550 --- Ship it! Master (0169b81) is green with this patch.

Re: Review Request 62873: Stream backup file from disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62873/#review187585 --- Master (4a1fba3) is red with this patch.

Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62869/ --- Review request for Aurora, Jordan Ly and Stephan Erb. Repository: aurora

Re: Review Request 62623: Use a simpler command line argument system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62623/#review187575 --- Ship it! Ship It! - David McLaughlin On Oct. 10, 2017, 2:37

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62869/#review187574 --- Master (4a1fba3) is red with this patch.

Review Request 62873: Stream backup file from disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62873/ --- Review request for Aurora and Jordan Ly. Repository: aurora Description

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62869/#review187591 --- Master (4a1fba3) is green with this patch.

Re: Review Request 62873: Stream backup file from disk

> On Oct. 10, 2017, 10:53 p.m., Jordan Ly wrote: > > Change LGTM, but is build failing due to this change or being flaky? Not enough memory on Jenkins :/ INFO: os::commit_memory(0x0007b110, 248512512, 0) failed; error='Cannot allocate memory' (errno=12) # There is

Re: Review Request 62873: Stream backup file from disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62873/#review187595 --- @ReviewBot retry - Stephan Erb On Oct. 10, 2017, 10:35 p.m.,

Re: Review Request 62873: Stream backup file from disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62873/#review187597 --- Master (4a1fba3) is green with this patch.

Re: Review Request 62873: Stream backup file from disk

> On Oct. 10, 2017, 2:39 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java > > Line 143 (original), 146 (patched) > > > > > > Bill, totally unrelated question: Has

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62869/#review187581 --- I have a first set of comments, but will have to complete my

Re: Review Request 62873: Stream backup file from disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62873/#review187586 --- Ship it! Change LGTM, but is build failing due to this change

Re: Review Request 62857: Fix broken end-to-end tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62857/#review187502 --- Ship it! Master (0169b81) is green with this patch.

Review Request 62857: Fix broken end-to-end tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62857/ --- Review request for Aurora, David McLaughlin and Stephan Erb. Repository:

Re: Review Request 62623: Use a simpler command line argument system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62623/ --- (Updated Oct. 10, 2017, 4:16 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 62623: Use a simpler command line argument system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62623/#review187605 --- Master (cb8e956) is red with this patch.

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

> On Oct. 10, 2017, 2:23 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md > > Line 4 (original), 4 (patched) > > > > > > This is a major change. We should proabably call it out here. Done. > On Oct. 10, 2017, 2:23

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62869/#review187612 --- This patch does not apply cleanly against master (519e3df), do

Re: Review Request 62623: Use a simpler command line argument system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62623/#review187610 --- Ship it! Master (cb8e956) is green with this patch.