Re: Review Request 22207: Prevent keyboard interrupts from spewing stack dumps.

2014-06-03 Thread Maxim Khutornenko
://reviews.apache.org/r/22165 gets in first. - Maxim Khutornenko On June 3, 2014, 3:30 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22207

Re: Review Request 22207: Prevent keyboard interrupts from spewing stack dumps.

2014-06-03 Thread Maxim Khutornenko
On June 3, 2014, 4:32 p.m., Maxim Khutornenko wrote: src/test/python/apache/aurora/client/test_config.py, line 24 https://reviews.apache.org/r/22207/diff/1/?file=602877#file602877line24 These import order fixing will need to be rebased if https://reviews.apache.org/r/22165 gets

Re: Review Request 22207: Prevent keyboard interrupts from spewing stack dumps.

2014-06-03 Thread Maxim Khutornenko
://reviews.apache.org/r/22207/#comment79052 What about SystemExit? Should not that be trapped here as well? - Maxim Khutornenko On June 3, 2014, 5:07 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 22207: Prevent keyboard interrupts from spewing stack dumps.

2014-06-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22207/#review44644 --- Ship it! Ship It! - Maxim Khutornenko On June 3, 2014, 5:07 p.m

Re: Review Request 22214: Add a target for a standalone v2 client.

2014-06-03 Thread Maxim Khutornenko
gradually deprecate v1 along with the bridge keeping the existing build targets. - Maxim Khutornenko On June 3, 2014, 5:23 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 32554: Enable gradle daemon in Vagrant.

2015-03-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32554/#review78061 --- Ship it! Ship It! - Maxim Khutornenko On March 26, 2015, 10:45

Review Request 32597: Improving async preemptor efficiency.

2015-03-27 Thread Maxim Khutornenko
b80e558f18b817814e4768b13ff94aa816d28543 Diff: https://reviews.apache.org/r/32597/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant Thanks, Maxim Khutornenko

Re: Review Request 32541: Adding client Kerberos support.

2015-04-01 Thread Maxim Khutornenko
://reviews.apache.org/r/32541/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-02 Thread Maxim Khutornenko
281f4e02650727aa5d0a35a09dcf0eb823ad1b50 src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorSlotFinderTest.java b80e558f18b817814e4768b13ff94aa816d28543 Diff: https://reviews.apache.org/r/32597/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant Thanks, Maxim

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-02 Thread Maxim Khutornenko
/PreemptorSlotFinderTest.java b80e558f18b817814e4768b13ff94aa816d28543 Diff: https://reviews.apache.org/r/32597/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant Thanks, Maxim Khutornenko

Re: Review Request 33105: Return Iterable from TaskStore.fetchTasks to allow for streaming.

2015-04-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33105/#review79960 --- Ship it! Ship It! - Maxim Khutornenko On April 11, 2015, 6:22

Re: Review Request 33106: Simplify AttributeAggregate.

2015-04-13 Thread Maxim Khutornenko
but two use cases by 20-70%. That's quite a big hit to our baseline with unclear motivation. I don't necessarily find the complexity reduction gain worthwhile the perf hit. What drives your changes here? Is there a connection to other work that would justify this refactoring? - Maxim Khutornenko

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907/#review79470 --- On April 6, 2015, 11:51 p.m., Maxim Khutornenko wrote

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-13 Thread Maxim Khutornenko
80bd13a192bda64759b5a93749ec47ddfeae504a src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 281f4e02650727aa5d0a35a09dcf0eb823ad1b50 Diff: https://reviews.apache.org/r/32907/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant. Thanks, Maxim Khutornenko

Re: Review Request 33200: Require non-default primitive values in StorageEntityUtil, extract a task factory utility.

2015-04-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33200/#review80871 --- Ship it! Ship It! - Maxim Khutornenko On April 16, 2015, 9:56

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-20 Thread Maxim Khutornenko
--- On April 16, 2015, 1:39 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/ --- (Updated April

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-20 Thread Maxim Khutornenko
/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant Thanks, Maxim Khutornenko

Review Request 33374: Resuming blocked updates on restart.

2015-04-20 Thread Maxim Khutornenko
/33374/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-20 Thread Maxim Khutornenko
: https://reviews.apache.org/r/32597/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant Thanks, Maxim Khutornenko

Review Request 33487: Bumping up scheduling rate.

2015-04-23 Thread Maxim Khutornenko
35c7e43746783ec81254b473848fb8579f9d233e Diff: https://reviews.apache.org/r/33487/diff/ Testing --- Thanks, Maxim Khutornenko

Re: Review Request 33487: Bumping up scheduling rate.

2015-04-23 Thread Maxim Khutornenko
), which suggests a new default scheduling rate of 40/sec. Diffs - src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 35c7e43746783ec81254b473848fb8579f9d233e Diff: https://reviews.apache.org/r/33487/diff/ Testing --- Thanks, Maxim Khutornenko

Re: Review Request 33487: Increasing the default scheduling rate limit to 40 attempts per second

2015-04-23 Thread Maxim Khutornenko
Diff: https://reviews.apache.org/r/33487/diff/ Testing --- Thanks, Maxim Khutornenko

Re: Review Request 33273: Add a specific storage routine for bulk loading data.

2015-04-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33273/#review81064 --- Ship it! Ship It! - Maxim Khutornenko On April 16, 2015, 9:50

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Maxim Khutornenko
/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant Thanks, Maxim Khutornenko

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Maxim Khutornenko
(Iterables.concat( slavesToOffers.keySet(), slavesToActiveTasks.keySet())); ``` Maxim Khutornenko wrote: Not opposed to the change but how is this better exactly? The way it's currently written will iterate over all available slaves only once whereas the proposed change

Re: Review Request 33411: Add typed Shiro permissions SPI.

2015-04-22 Thread Maxim Khutornenko
/common/base/Enums.html#getIfPresent(java.lang.Class,%20java.lang.String) - Maxim Khutornenko On April 22, 2015, 5:46 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.

2015-04-24 Thread Maxim Khutornenko
/ --- (Updated April 16, 2015, 10 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-556 https://issues.apache.org/jira/browse/AURORA-556 Repository: aurora Description --- Add SQL tables needed for a datbase-backed task store. Diffs

Review Request 33458: Implementing PendingTaskProcessor benchmark.

2015-04-22 Thread Maxim Khutornenko
/PreemptorModule.java 156bac2d8cf941bcda0474ef75c7eaec74a39a3a Diff: https://reviews.apache.org/r/33458/diff/ Testing --- ./gradlew jmh Thanks, Maxim Khutornenko

Review Request 33456: Adding logging threadpool executor.

2015-04-22 Thread Maxim Khutornenko
3a4d40adc1abe170b5b80644db9f079751d8a9bf src/test/java/org/apache/aurora/scheduler/base/AsyncUtilTest.java e990f528aac768b5c9b829c9544045a831e094fe Diff: https://reviews.apache.org/r/33456/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.

2015-04-20 Thread Maxim Khutornenko
On April 20, 2015, 5:50 p.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line 200 https://reviews.apache.org/r/33279/diff/1/?file=932067#file932067line200 Isn't this too restrictive? Currently, we can still have something like

Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.

2015-04-20 Thread Maxim Khutornenko
/aurora/scheduler/storage/db/schema.sql https://reviews.apache.org/r/33279/#comment130882 Isn't this too restrictive? Currently, we can still have something like 'rack':'limit:5' and 'rack':'abc'. This constraint will now allow configs like that any longer. - Maxim Khutornenko On April 16

Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.

2015-04-24 Thread Maxim Khutornenko
On April 24, 2015, 6:35 p.m., Bill Farner wrote: Ping - Maxim, can you check my replies above? Maxim Khutornenko wrote: My plan is to avoid changing behavior with the task store, so i did not have any intention of removing fields. Sorry, I was under assumption your

Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.

2015-04-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33279/#review81525 --- Ship it! Ship It! - Maxim Khutornenko On April 16, 2015, 10 p.m

Re: Review Request 33530: Simplify storage bindings, remove shims that are now mostly getting in the way.

2015-04-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33530/#review81533 --- Ship it! Ship It! - Maxim Khutornenko On April 24, 2015, 7:07

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-28 Thread Maxim Khutornenko
. - Maxim Khutornenko On April 29, 2015, 12:48 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608

Re: Review Request 33611: Add benchmarks for fetching tasks over the API.

2015-04-28 Thread Maxim Khutornenko
https://reviews.apache.org/r/33611/#comment132321 This benchmark is nearly identical to the role summary one. Any chance they could share common definitions? - Maxim Khutornenko On April 28, 2015, 12:57 a.m., Bill Farner wrote

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-28 Thread Maxim Khutornenko
generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/#review81725 --- On April 22, 2015, 10:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated

Re: Review Request 33608: Added a status update throughput benchmark.

2015-04-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review81993 --- Ship it! Ship It! - Maxim Khutornenko On April 29, 2015, 6:12

Re: Review Request 33600: Extract an abstract base test for TaskStore implementations.

2015-04-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33600/#review81739 --- Ship it! Ship It! - Maxim Khutornenko On April 27, 2015, 10:26

Re: Review Request 33458: Implementing PendingTaskProcessor benchmark.

2015-04-27 Thread Maxim Khutornenko
--- On April 23, 2015, 12:24 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33458

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-04-30 Thread Maxim Khutornenko
On April 28, 2015, 11:48 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 131 https://reviews.apache.org/r/33612/diff/1/?file=944387#file944387line131 This feels like a potential for flakiness. Why 5? Any reason against

Re: Review Request 33456: Adding logging threadpool executor.

2015-05-01 Thread Maxim Khutornenko
/google/common/util/concurrent/ForwardingExecutorService.html Maxim Khutornenko wrote: I could not figure out how to make it useful for this particular case. The `afterExecute` is defined in a more concrete ThreadPoolExecutor rather than in ExecutorService that ForwardingExecutorService

Re: Review Request 33458: Implementing PendingTaskProcessor benchmark.

2015-04-28 Thread Maxim Khutornenko
4427115ceee0e5f3ca32462e3cfb2ad2f0ece913 src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java 156bac2d8cf941bcda0474ef75c7eaec74a39a3a Diff: https://reviews.apache.org/r/33458/diff/ Testing --- ./gradlew jmh Thanks, Maxim Khutornenko

Re: Review Request 33611: Add benchmarks for fetching tasks over the API.

2015-04-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/#review81855 --- Ship it! Ship It! - Maxim Khutornenko On April 28, 2015, 6:16

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

2015-05-07 Thread Maxim Khutornenko
://reviews.apache.org/r/33689/#comment133775 Suggest using 5 seconds as it's more than enough time to run a single update. - Maxim Khutornenko On May 7, 2015, 12:27 a.m., Ben Mahler wrote: --- This is an automatically generated e

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko
On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, line 122 https://reviews.apache.org/r/33959/diff/1/?file=952678#file952678line122 Suggest --wait-until for consistency with job create command. Bill Farner wrote: `--wait

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko
://reviews.apache.org/r/33959/#comment133818 Suggest --wait-until for consistency with job create command. - Maxim Khutornenko On May 7, 2015, 11:58 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko
On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, line 122 https://reviews.apache.org/r/33959/diff/1/?file=952678#file952678line122 Suggest --wait-until for consistency with job create command. Bill Farner wrote: `--wait

Re: Review Request 33962: Remove often-redundant Error executing command prefix from client output.

2015-05-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33962/#review82948 --- Ship it! Ship It! - Maxim Khutornenko On May 8, 2015, 12:16 a.m

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-07 Thread Maxim Khutornenko
/aurora/client/cli/update.py https://reviews.apache.org/r/33959/#comment133833 drop pass - Maxim Khutornenko On May 8, 2015, 1:04 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 33969: Fix broken style test cases causing PEP302

2015-05-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33969/#review82974 --- Ship it! Ship It! - Maxim Khutornenko On May 8, 2015, 3:30 a.m

Re: Review Request 33905: Updgrade to gradle 2.4.

2015-05-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33905/#review82720 --- Ship it! Ship It! - Maxim Khutornenko On May 6, 2015, 7:06 p.m

Re: Review Request 33869: Fix inconsistency in MemTaskStore secondary indices.

2015-05-06 Thread Maxim Khutornenko
On May 6, 2015, 3:39 p.m., Maxim Khutornenko wrote: Mind explaining explaining the bug for everyone's benefit? Never mind, found the answer in the attached ticket. Hard to notice index.remove(key, Tasks.id(task)); bundled with unrelated stats refactoring. - Maxim

Re: Review Request 33869: Fix inconsistency in MemTaskStore secondary indices.

2015-05-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33869/#review82690 --- Ship it! Ship It! - Maxim Khutornenko On May 5, 2015, 11:16 p.m

Review Request 33924: Adding missing API hook support in kill commands.

2015-05-06 Thread Maxim Khutornenko
in vagrant. Thanks, Maxim Khutornenko

Re: Review Request 33869: Fix inconsistency in MemTaskStore secondary indices.

2015-05-06 Thread Maxim Khutornenko
5, 2015, 11:16 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1305 https://issues.apache.org/jira/browse/AURORA-1305 Repository: aurora Description --- In practice this amounts to little more than a space leak, but a bug nonetheless. Diffs

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

2015-05-04 Thread Maxim Khutornenko
On May 4, 2015, 9:56 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, lines 199-203 https://reviews.apache.org/r/33689/diff/1/?file=947578#file947578line199 This isn't necessary. You can use `.execute(...)` instead and rely

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

2015-05-04 Thread Maxim Khutornenko
https://reviews.apache.org/r/33689/#comment133186 This isn't necessary. You can use `.execute(...)` instead and rely on a single threaded executor to enforce sequential item processing. - Maxim Khutornenko On May 1, 2015, 10:55 p.m., Ben Mahler wrote

Re: Review Request 34046: Upgade h2 to 1.4.187.

2015-05-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34046/#review83243 --- Ship it! Ship It! - Maxim Khutornenko On May 11, 2015, 5:58 p.m

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

2015-05-11 Thread Maxim Khutornenko
/UserTaskLauncherTest.java https://reviews.apache.org/r/33689/#comment134216 IAnswerVoid - Maxim Khutornenko On May 11, 2015, 6:55 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review83306 --- Ship it! - Maxim Khutornenko On May 9, 2015, 5:53 p.m., Bill

Review Request 34121: Disable state transition logging for unknown tasks.

2015-05-12 Thread Maxim Khutornenko
://reviews.apache.org/r/34121/diff/ Testing --- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko

Review Request 34124: Removing dead code from StateManagerImpl.

2015-05-12 Thread Maxim Khutornenko
/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java b30a0737bb0d60cd8b58f7be0fff5db20f808347 Diff: https://reviews.apache.org/r/34124/diff/ Testing --- Thanks, Maxim Khutornenko

Re: Review Request 34121: Disable state transition logging for unknown tasks.

2015-05-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34121/#review83477 --- @ReviewBot retry - Maxim Khutornenko On May 12, 2015, 8:40 p.m

Re: Review Request 34121: Disable state transition logging for unknown tasks.

2015-05-12 Thread Maxim Khutornenko
://reviews.apache.org/r/34121/#review83481 --- On May 12, 2015, 8:40 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 34148: Enhancing the StateManager.changeState result.

2015-05-12 Thread Maxim Khutornenko
/34148/#review83545 --- On May 13, 2015, 1:43 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34148

Re: Review Request 34126: Use JDK 8 language features.

2015-05-12 Thread Maxim Khutornenko
/preemptor/PendingTaskProcessorTest.java https://reviews.apache.org/r/34126/#comment134512 Can't wait! - Maxim Khutornenko On May 12, 2015, 10:54 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 34301: Implementing benchmark for snapshot restore.

2015-05-15 Thread Maxim Khutornenko
-Pbenchmarks='SnapshotBenchmarks' Thanks, Maxim Khutornenko

Re: Review Request 34301: Implementing benchmark for snapshot restore.

2015-05-15 Thread Maxim Khutornenko
./gradlew jmh -Pbenchmarks='SnapshotBenchmarks' Thanks, Maxim Khutornenko

Re: Review Request 34301: Implementing benchmark for snapshot restore.

2015-05-15 Thread Maxim Khutornenko
AURORA-1318. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34301/#review84008 --- On May 16, 2015, 1:22 a.m., Maxim Khutornenko

Re: Review Request 34169: Add a type witness to satisfy JDK 8U11 compiler.

2015-05-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34169/#review83617 --- Ship it! Ship It! - Maxim Khutornenko On May 13, 2015, 3:34 p.m

Re: Review Request 34148: Enhancing the StateManager.changeState result.

2015-05-13 Thread Maxim Khutornenko
, Maxim Khutornenko

Re: Review Request 34148: Enhancing the StateManager.changeState result.

2015-05-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34148/#review83623 --- On May 13, 2015, 1:43 a.m., Maxim Khutornenko wrote

Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34373/#review84226 --- On May 18, 2015, 9:41 p.m., Maxim Khutornenko wrote

Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Maxim Khutornenko
/UserTaskLauncher.java f1e5dd2d47af2570f404d198b3fbdd754174206e src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java f4631c1cec4386d813d5869c28289207acf8523f Diff: https://reviews.apache.org/r/34373/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Maxim Khutornenko
/apache/aurora/scheduler/UserTaskLauncherTest.java f4631c1cec4386d813d5869c28289207acf8523f Diff: https://reviews.apache.org/r/34373/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 33106: Simplify AttributeAggregate.

2015-04-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33106/#review80047 --- Ship it! Ship It! - Maxim Khutornenko On April 14, 2015, 4 a.m

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32907/#review80052 --- Ping Zameer. - Maxim Khutornenko On April 14, 2015, 1:09 a.m

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-14 Thread Maxim Khutornenko
80bd13a192bda64759b5a93749ec47ddfeae504a src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 97d6087ab92ae6d492f50ccf6c6091ec42b1c032 Diff: https://reviews.apache.org/r/32907/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant. Thanks, Maxim Khutornenko

Review Request 33235: Fixing e2e kerberos tests.

2015-04-15 Thread Maxim Khutornenko
--- Changes in https://reviews.apache.org/r/33048/ did not propagate into kerberos .conf Diffs - examples/vagrant/upstart/aurora-scheduler-kerberos.conf 7736ff4f30acdf015c8573bd17d0cc817220ac74 Diff: https://reviews.apache.org/r/33235/diff/ Testing --- Thanks, Maxim

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Maxim Khutornenko
/PreemptorSlotFinderTest.java eed2de99a145dd2124b7f2b4d401214f1d8adf2e Diff: https://reviews.apache.org/r/32597/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant Thanks, Maxim Khutornenko

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Maxim Khutornenko
generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review80256 --- On April 15, 2015, 7:05 p.m., Maxim Khutornenko wrote: --- This is an automatically generated

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Maxim Khutornenko
/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant Thanks, Maxim Khutornenko

Re: Review Request 33244: Fixed the end-to-end tests.

2015-04-15 Thread Maxim Khutornenko
/33235/ Thanks for discovering and testing it! - Maxim Khutornenko On April 15, 2015, 10:42 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33244

Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Maxim Khutornenko
/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko

Re: Review Request 32541: Adding client Kerberos support.

2015-04-10 Thread Maxim Khutornenko
://reviews.apache.org/r/32541/#review79766 --- On April 10, 2015, 10:45 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 32990: Improving JobUpdateDetails fetch performance.

2015-04-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32990/#review79467 --- On April 8, 2015, 9:45 p.m., Maxim Khutornenko wrote

Re: Review Request 32990: Improving JobUpdateDetails fetch performance.

2015-04-09 Thread Maxim Khutornenko
. Thanks, Maxim Khutornenko

Review Request 32990: Improving JobUpdateDetails fetch performance.

2015-04-08 Thread Maxim Khutornenko
/scheduler/storage/db/JobUpdateDetailsMapper.xml 4536cd35ffc231a5d2f6c1b5bf2aaa084ce3ad1d Diff: https://reviews.apache.org/r/32990/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant. Thanks, Maxim Khutornenko

Review Request 33202: Fixing benchmarks.

2015-04-14 Thread Maxim Khutornenko
--- Benchmark module configuration got broken by recent refactoring. Diffs - src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 011350540d4f5091ff5f8a3c646f40f3f63357fd Diff: https://reviews.apache.org/r/33202/diff/ Testing --- ./gradlew jmh Thanks, Maxim

Re: Review Request 33202: Fixing benchmarks.

2015-04-14 Thread Maxim Khutornenko
://reviews.apache.org/r/33202/diff/ Testing --- ./gradlew jmh Thanks, Maxim Khutornenko

Re: Review Request 32907: Generalizing preemption reservation pool.

2015-04-14 Thread Maxim Khutornenko
80bd13a192bda64759b5a93749ec47ddfeae504a src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 97d6087ab92ae6d492f50ccf6c6091ec42b1c032 Diff: https://reviews.apache.org/r/32907/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant. Thanks, Maxim Khutornenko

Review Request 33191: Removing taskId from ResourceRequest.

2015-04-14 Thread Maxim Khutornenko
://reviews.apache.org/r/33191/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-03 Thread Maxim Khutornenko
/scheduler/async/preemptor/PreemptorSlotFinderTest.java b80e558f18b817814e4768b13ff94aa816d28543 Diff: https://reviews.apache.org/r/32597/diff/ Testing --- ./gradlew -Pq build Manual testing in vagrant Thanks, Maxim Khutornenko

Re: Review Request 32840: Ignore maxWaitToInstanceRunningMs in the scheduler updater.

2015-04-03 Thread Maxim Khutornenko
On April 3, 2015, 11:34 p.m., Maxim Khutornenko wrote: src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java, line 1155 https://reviews.apache.org/r/32840/diff/1/?file=915023#file915023line1155 Would it make sense to trigger a task timeout event instead to simulate

Re: Review Request 32840: Ignore maxWaitToInstanceRunningMs in the scheduler updater.

2015-04-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32840/#review78863 --- Ship it! Ship It! - Maxim Khutornenko On April 3, 2015, 11:23

Re: Review Request 32840: Ignore maxWaitToInstanceRunningMs in the scheduler updater.

2015-04-03 Thread Maxim Khutornenko
/JobUpdaterIT.java https://reviews.apache.org/r/32840/#comment127930 Would it make sense to trigger a task timeout event instead to simulate real life behavior? - Maxim Khutornenko On April 3, 2015, 11:23 p.m., Bill Farner wrote

Re: Review Request 32541: Adding client Kerberos support.

2015-04-02 Thread Maxim Khutornenko
Diff: https://reviews.apache.org/r/32541/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko

Re: Review Request 32541: Adding client Kerberos support.

2015-04-02 Thread Maxim Khutornenko
On April 1, 2015, 8:40 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/client/cli/BUILD, line 29 https://reviews.apache.org/r/32541/diff/2/?file=909509#file909509line29 How about kaurora Maxim Khutornenko wrote: This is a joke, right? :) If not I am really

Re: Review Request 32541: Adding client Kerberos support.

2015-04-01 Thread Maxim Khutornenko
--- On March 30, 2015, 9:09 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32541

  1   2   3   4   5   6   7   8   9   >