://reviews.apache.org/r/32541/diff/
Testing
---
./pants test.pytest --no-fast src/test/python:all
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33105/#review79960
---
Ship it!
Ship It!
- Maxim Khutornenko
On April 11, 2015, 6:22
80bd13a192bda64759b5a93749ec47ddfeae504a
src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
281f4e02650727aa5d0a35a09dcf0eb823ad1b50
Diff: https://reviews.apache.org/r/32907/diff/
Testing
---
./gradlew -Pq build
Manual testing in vagrant.
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33200/#review80871
---
Ship it!
Ship It!
- Maxim Khutornenko
On April 16, 2015, 9:56
---
On April 16, 2015, 1:39 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597/
---
(Updated April
/diff/
Testing
---
./gradlew -Pq build
Manual testing in vagrant
Thanks,
Maxim Khutornenko
/33374/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
: https://reviews.apache.org/r/32597/diff/
Testing
---
./gradlew -Pq build
Manual testing in vagrant
Thanks,
Maxim Khutornenko
35c7e43746783ec81254b473848fb8579f9d233e
Diff: https://reviews.apache.org/r/33487/diff/
Testing
---
Thanks,
Maxim Khutornenko
), which suggests a new default scheduling rate of 40/sec.
Diffs
-
src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java
35c7e43746783ec81254b473848fb8579f9d233e
Diff: https://reviews.apache.org/r/33487/diff/
Testing
---
Thanks,
Maxim Khutornenko
Diff: https://reviews.apache.org/r/33487/diff/
Testing
---
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33273/#review81064
---
Ship it!
Ship It!
- Maxim Khutornenko
On April 16, 2015, 9:50
/diff/
Testing
---
./gradlew -Pq build
Manual testing in vagrant
Thanks,
Maxim Khutornenko
(Iterables.concat(
slavesToOffers.keySet(),
slavesToActiveTasks.keySet()));
```
Maxim Khutornenko wrote:
Not opposed to the change but how is this better exactly? The way it's
currently written will iterate over all available slaves only once whereas
the proposed change
/common/base/Enums.html#getIfPresent(java.lang.Class,%20java.lang.String)
- Maxim Khutornenko
On April 22, 2015, 5:46 p.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
/
---
(Updated April 16, 2015, 10 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-556
https://issues.apache.org/jira/browse/AURORA-556
Repository: aurora
Description
---
Add SQL tables needed for a datbase-backed task store.
Diffs
/PreemptorModule.java
156bac2d8cf941bcda0474ef75c7eaec74a39a3a
Diff: https://reviews.apache.org/r/33458/diff/
Testing
---
./gradlew jmh
Thanks,
Maxim Khutornenko
3a4d40adc1abe170b5b80644db9f079751d8a9bf
src/test/java/org/apache/aurora/scheduler/base/AsyncUtilTest.java
e990f528aac768b5c9b829c9544045a831e094fe
Diff: https://reviews.apache.org/r/33456/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
https://reviews.apache.org/r/33611/#comment132321
This benchmark is nearly identical to the role summary one. Any chance they
could share common definitions?
- Maxim Khutornenko
On April 28, 2015, 12:57 a.m., Bill Farner wrote
---
On April 23, 2015, 12:24 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33458
On April 28, 2015, 11:48 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 131
https://reviews.apache.org/r/33612/diff/1/?file=944387#file944387line131
This feels like a potential for flakiness. Why 5? Any reason against
4427115ceee0e5f3ca32462e3cfb2ad2f0ece913
src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java
156bac2d8cf941bcda0474ef75c7eaec74a39a3a
Diff: https://reviews.apache.org/r/33458/diff/
Testing
---
./gradlew jmh
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33611/#review81855
---
Ship it!
Ship It!
- Maxim Khutornenko
On April 28, 2015, 6:16
://reviews.apache.org/r/33689/#comment133775
Suggest using 5 seconds as it's more than enough time to run a single
update.
- Maxim Khutornenko
On May 7, 2015, 12:27 a.m., Ben Mahler wrote:
---
This is an automatically generated e
://reviews.apache.org/r/33959/#comment133818
Suggest --wait-until for consistency with job create command.
- Maxim Khutornenko
On May 7, 2015, 11:58 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit
On May 8, 2015, 12:04 a.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/update.py, line 122
https://reviews.apache.org/r/33959/diff/1/?file=952678#file952678line122
Suggest --wait-until for consistency with job create command.
Bill Farner wrote:
`--wait
/aurora/client/cli/update.py
https://reviews.apache.org/r/33959/#comment133833
drop pass
- Maxim Khutornenko
On May 8, 2015, 1:04 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33969/#review82974
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 8, 2015, 3:30 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33905/#review82720
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 6, 2015, 7:06 p.m
On May 6, 2015, 3:39 p.m., Maxim Khutornenko wrote:
Mind explaining explaining the bug for everyone's benefit?
Never mind, found the answer in the attached ticket. Hard to notice
index.remove(key, Tasks.id(task)); bundled with unrelated stats refactoring.
- Maxim
5, 2015, 11:16 p.m.)
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-1305
https://issues.apache.org/jira/browse/AURORA-1305
Repository: aurora
Description
---
In practice this amounts to little more than a space leak, but a bug
nonetheless.
Diffs
https://reviews.apache.org/r/33689/#comment133186
This isn't necessary. You can use `.execute(...)` instead and rely on a
single threaded executor to enforce sequential item processing.
- Maxim Khutornenko
On May 1, 2015, 10:55 p.m., Ben Mahler wrote
/UserTaskLauncherTest.java
https://reviews.apache.org/r/33689/#comment134216
IAnswerVoid
- Maxim Khutornenko
On May 11, 2015, 6:55 p.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java
b30a0737bb0d60cd8b58f7be0fff5db20f808347
Diff: https://reviews.apache.org/r/34124/diff/
Testing
---
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34121/#review83477
---
@ReviewBot retry
- Maxim Khutornenko
On May 12, 2015, 8:40 p.m
://reviews.apache.org/r/34121/#review83481
---
On May 12, 2015, 8:40 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/34148/#review83545
---
On May 13, 2015, 1:43 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34148
/preemptor/PendingTaskProcessorTest.java
https://reviews.apache.org/r/34126/#comment134512
Can't wait!
- Maxim Khutornenko
On May 12, 2015, 10:54 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit
AURORA-1318.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34301/#review84008
---
On May 16, 2015, 1:22 a.m., Maxim Khutornenko
,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34148/#review83623
---
On May 13, 2015, 1:43 a.m., Maxim Khutornenko wrote
/UserTaskLauncher.java
f1e5dd2d47af2570f404d198b3fbdd754174206e
src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java
f4631c1cec4386d813d5869c28289207acf8523f
Diff: https://reviews.apache.org/r/34373/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
/apache/aurora/scheduler/UserTaskLauncherTest.java
f4631c1cec4386d813d5869c28289207acf8523f
Diff: https://reviews.apache.org/r/34373/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33106/#review80047
---
Ship it!
Ship It!
- Maxim Khutornenko
On April 14, 2015, 4 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32907/#review80052
---
Ping Zameer.
- Maxim Khutornenko
On April 14, 2015, 1:09 a.m
80bd13a192bda64759b5a93749ec47ddfeae504a
src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
97d6087ab92ae6d492f50ccf6c6091ec42b1c032
Diff: https://reviews.apache.org/r/32907/diff/
Testing
---
./gradlew -Pq build
Manual testing in vagrant.
Thanks,
Maxim Khutornenko
/PreemptorSlotFinderTest.java
eed2de99a145dd2124b7f2b4d401214f1d8adf2e
Diff: https://reviews.apache.org/r/32597/diff/
Testing
---
./gradlew -Pq build
Manual testing in vagrant
Thanks,
Maxim Khutornenko
generated e-mail. To reply, visit:
https://reviews.apache.org/r/32597/#review80256
---
On April 15, 2015, 7:05 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated
/33235/ Thanks
for discovering and testing it!
- Maxim Khutornenko
On April 15, 2015, 10:42 p.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33244
/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32990/#review79467
---
On April 8, 2015, 9:45 p.m., Maxim Khutornenko wrote
.
Thanks,
Maxim Khutornenko
---
Benchmark module configuration got broken by recent refactoring.
Diffs
-
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java
011350540d4f5091ff5f8a3c646f40f3f63357fd
Diff: https://reviews.apache.org/r/33202/diff/
Testing
---
./gradlew jmh
Thanks,
Maxim
80bd13a192bda64759b5a93749ec47ddfeae504a
src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
97d6087ab92ae6d492f50ccf6c6091ec42b1c032
Diff: https://reviews.apache.org/r/32907/diff/
Testing
---
./gradlew -Pq build
Manual testing in vagrant.
Thanks,
Maxim Khutornenko
On April 3, 2015, 11:34 p.m., Maxim Khutornenko wrote:
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java, line
1155
https://reviews.apache.org/r/32840/diff/1/?file=915023#file915023line1155
Would it make sense to trigger a task timeout event instead to simulate
/JobUpdaterIT.java
https://reviews.apache.org/r/32840/#comment127930
Would it make sense to trigger a task timeout event instead to simulate
real life behavior?
- Maxim Khutornenko
On April 3, 2015, 11:23 p.m., Bill Farner wrote
Diff: https://reviews.apache.org/r/32541/diff/
Testing
---
./pants test.pytest --no-fast src/test/python:all
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
On April 1, 2015, 8:40 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/cli/BUILD, line 29
https://reviews.apache.org/r/32541/diff/2/?file=909509#file909509line29
How about kaurora
Maxim Khutornenko wrote:
This is a joke, right? :) If not I am really
---
On March 30, 2015, 9:09 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32541
-hooks hook,hook,...]
CLUSTER/ROLE/ENV/NAME[/INSTANCES]
aurora job kill: error: argument CLUSTER/ROLE/ENV/NAME[/INSTANCES]: Invalid
instance range: ['1', '0']
Thanks,
Maxim Khutornenko
/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34566/#review86710
---
On June 4, 2015, 7:31 p.m., Maxim Khutornenko wrote
/e2e/test_kerberos_end_to_end.sh
Connecting to H2 in Vagrant.
Thanks,
Maxim Khutornenko
)
---
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh
Connecting to H2 in Vagrant.
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35219/#review87071
---
Ship it!
Ship It!
- Maxim Khutornenko
On June 8, 2015, 7:10 p.m
as it's no longer referenced.
src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java
https://reviews.apache.org/r/34967/#comment138397
any particular reason for this change?
- Maxim Khutornenko
On June 3, 2015, 1:11 a.m., Zameer Manji wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35274/#review87311
---
Ship it!
Ship It!
- Maxim Khutornenko
On June 9, 2015, 11:05
.
commit-revert-re-apply).
- Maxim Khutornenko
On June 8, 2015, 6:21 p.m., Brian Brazil wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33433
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35672/#review88804
---
Ship it!
Ship It!
- Maxim Khutornenko
On June 19, 2015, 10:43
On June 19, 2015, 11:50 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java, line 127
https://reviews.apache.org/r/35672/diff/1/?file=988557#file988557line127
Curious, why special treating whitespacing here and not in other places?
Bill
/SlaModule.java (line 65)
https://reviews.apache.org/r/35498/#comment141384
Missing .
src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java (line 70)
https://reviews.apache.org/r/35498/#comment141385
Same here.
- Maxim Khutornenko
On June 21, 2015, 2:39 p.m., Stephan Erb wrote
e4e158721e0bdc7ed8a02eea24f4915ab937b9c7
Diff: https://reviews.apache.org/r/35761/diff/
Testing
---
Thanks,
Maxim Khutornenko
d2ec944ca12456c23eb54c9be8b1e6756f35e7f1
src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java
ec43a44d9cbd0f303e4833953cdb65664d5ed569
Diff: https://reviews.apache.org/r/35760/diff/
Testing
---
Thanks,
Maxim Khutornenko
---
On June 23, 2015, 2:29 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/#review89039
---
On June 23, 2015, 6:35 p.m., Maxim Khutornenko wrote
/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java
f0f9ac392973a276028aee3e06517a6e6d960bb6
Diff: https://reviews.apache.org/r/35587/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
would pass before the patch.
Maxim Khutornenko wrote:
This is mostly for test coverage similarly to the
testOfferFirstAcceptsFineLogging above. Asserting a message would require
replacing current anonymous logger with a mock and deeper refactoring. Do you
think it's worth it here
---
On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/
---
(Updated June 24, 2015
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35793/#review89404
---
Ship it!
Ship It!
- Maxim Khutornenko
On June 24, 2015, 10:46
On June 25, 2015, 6:05 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 254
https://reviews.apache.org/r/35793/diff/3/?file=991667#file991667line254
This will use a regular single threaded executor, right? Any chance
/RowGarbageCollector.java
(line 60)
https://reviews.apache.org/r/35793/#comment141982
I'd still recommend having a run counter to help us monitor collector
availability/health.
- Maxim Khutornenko
On June 24, 2015, 10:46 p.m., Bill Farner wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/#review89453
---
Ship it!
Ship It!
- Maxim Khutornenko
On June 26, 2015, 12:07
/aurora/scheduler/mesos/MesosSchedulerImplTest.java
f0f9ac392973a276028aee3e06517a6e6d960bb6
Diff: https://reviews.apache.org/r/35587/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35587/
---
(Updated June 18, 2015, 1:02 a.m.)
Review
/apache/aurora/scheduler/async/TaskReconcilerTest.java
9ed1dba04667df52ba1c1538709a043308828763
Diff: https://reviews.apache.org/r/35639/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
Thanks,
Maxim Khutornenko
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
/db/TaskMapper.xml (line
167)
https://reviews.apache.org/r/35630/#comment140987
Is DISTINCT necessary given the Set result type?
- Maxim Khutornenko
On June 18, 2015, 10:39 p.m., Bill Farner wrote:
---
This is an automatically
src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java
a8badd40f63433216d809cbbebe79c15c9427571
Diff: https://reviews.apache.org/r/35633/diff/
Testing
---
Thanks,
Maxim Khutornenko
On June 18, 2015, 11:08 p.m., Maxim Khutornenko wrote:
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml,
line 167
https://reviews.apache.org/r/35630/diff/1/?file=987636#file987636line167
Is DISTINCT necessary given the Set result type?
Bill Farner wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35613/#review88458
---
@ReviewBot retry
- Maxim Khutornenko
On June 18, 2015, 10:12 p.m
/#review89104
---
On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813
On June 24, 2015, 12:31 a.m., Brian Wickman wrote:
slightly overzealous deleting. the thermos gc stuff should still be part
of the thermos toolchain.
Maxim Khutornenko wrote:
Should not we rather rely on task reconciliation to do any cleanup
instead? Force GCing a task does
/monitoring/test_garbage.py
4309c46a3af5f12c8eb3192e3156348fa7c0db23
Diff: https://reviews.apache.org/r/35813/diff/
Testing
---
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33433/#review87417
---
On master now. Thanks!
- Maxim Khutornenko
On June 10, 2015, 9
https://reviews.apache.org/r/32973/#comment140041
Any particular reason why this skipif moved down here?
- Maxim Khutornenko
On June 11, 2015, 10:39 a.m., Brian Brazil wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/#review88139
---
Ship it!
Ship It!
- Maxim Khutornenko
On June 16, 2015, 9:54
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/
---
(Updated June 16, 2015, 9:54 p.m.)
Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
Bugs: AURORA-1352
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35527/#review88130
---
On June 16, 2015, 8:50 p.m., Maxim Khutornenko wrote
--test.pytest --no-fast src/test/python::
Thanks,
Maxim Khutornenko
1 - 100 of 737 matches
Mail list logo
