Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-11 Thread Stephan Erb
--- ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/executor:thermos_task_runner In addition, manual verification that shutdown of health-checked services without lifecycle methods is 10 seconds faster. Thanks, Stephan Erb

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review79718 --- On April 11, 2015, 11:52 p.m., Stephan Erb wrote

Re: Review Request 33612: Add a task store implementation that uses a relational database.

2015-05-03 Thread Stephan Erb
/DbTaskStore.java https://reviews.apache.org/r/33612/#comment133061 Copy paste error. Should be `db_storage_save_tasks`. - Stephan Erb On April 28, 2015, 10:11 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

2015-05-03 Thread Stephan Erb
, using a LinkedList here seems rather uncommon. - Stephan Erb On May 2, 2015, 12:55 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33689

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

2015-05-10 Thread Stephan Erb
On May 3, 2015, 4:01 p.m., Stephan Erb wrote: src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, line 70 https://reviews.apache.org/r/33689/diff/1/?file=947578#file947578line70 Any reason why you have chosen this particular value? Ben Mahler wrote: Are you

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

2015-05-10 Thread Stephan Erb
https://reviews.apache.org/r/33689/#comment134073 You mentioned that updates should be processed in FIFO order. As we have effectively lost the entire batch here, do we have to clear the pendingUpdates queue to prevent our of order processing? - Stephan Erb On May 7, 2015, 2:27 a.m., Ben

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

2015-05-12 Thread Stephan Erb
On May 10, 2015, 2:10 p.m., Stephan Erb wrote: src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, line 211 https://reviews.apache.org/r/33689/diff/3/?file=951771#file951771line211 You mentioned that updates should be processed in FIFO order. As we have effectively

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-15 Thread Stephan Erb
faster. Thanks, Stephan Erb

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-15 Thread Stephan Erb
: https://reviews.apache.org/r/32889/#review80210 --- On April 15, 2015, 8:38 p.m., Stephan Erb wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 33184: Implement missing != operator for AuroraJobKey

2015-04-14 Thread Stephan Erb
, 9:18 p.m., Stephan Erb wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33184/ --- (Updated April 14, 2015, 9:18 p.m

Re: Review Request 33184: Implement missing != operator for AuroraJobKey

2015-04-14 Thread Stephan Erb
7d8d58b541f16d63495f46b58bd928e8f53f66d1 Diff: https://reviews.apache.org/r/33184/diff/ Testing --- ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/common:: Thanks, Stephan Erb

Re: Review Request 33184: Implement missing != operator for AuroraJobKey

2015-04-14 Thread Stephan Erb
://reviews.apache.org/r/33184/diff/ Testing --- ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/common:: Thanks, Stephan Erb

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-14 Thread Stephan Erb
? - Stephan Erb On April 11, 2015, 11:52 p.m., Stephan Erb wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/ --- (Updated

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-06 Thread Stephan Erb
://mail-archives.apache.org/mod_mbox/incubator-aurora-dev/201503.mbox/%3cea362985d93941b1b12fc028e8aca...@ex2013-3.phi-tps.local%3E) never really took off. I thought I might as well let to code speak for itself and see what you think about it. - Stephan Erb On April 6, 2015, 7:12 p.m., Stephan Erb

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review78942 --- @ReviewBot retry - Stephan Erb On April 6, 2015, 7:12 p.m

Review Request 32830: Fix header levels in monitoring.md

2015-04-03 Thread Stephan Erb
header levels in monitoring.md Diffs - docs/monitoring.md 8aee66915f40d39368b57acd2b9e328e52b8cdbe Diff: https://reviews.apache.org/r/32830/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 32830: Fix header levels in monitoring.md

2015-04-04 Thread Stephan Erb
--- Thanks, Stephan Erb

Re: Review Request 32861: Increase executor resource epsilon to match the minimum required by Mesos

2015-04-04 Thread Stephan Erb
8ae68653427c0bdbf33751d5ed4b74afcaf98a7b Diff: https://reviews.apache.org/r/32861/diff/ Testing --- ./gradlew -Pq build Thanks, Stephan Erb

Review Request 32861: Increase executor resource epsilon to match the minimum required by Mesos

2015-04-04 Thread Stephan Erb
build Thanks, Stephan Erb

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-21 Thread Stephan Erb
-to-constant-expression - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88552 --- On June 19, 2015, 5:23 p.m., Stephan Erb

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-21 Thread Stephan Erb
5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d Diff: https://reviews.apache.org/r/35498/diff/ Testing --- `./gradlew -Pq build` and a manual verification in Vagrant. Thanks, Stephan Erb

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-26 Thread Stephan Erb
, 2015, 9:09 p.m., Stephan Erb wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 24, 2015, 9:09 p.m

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-19 Thread Stephan Erb
--- `./gradlew -Pq build` and a manual verification in Vagrant. Thanks, Stephan Erb

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-23 Thread Stephan Erb
/org/apache/aurora/scheduler/sla/SlaModuleTest.java 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d Diff: https://reviews.apache.org/r/35498/diff/ Testing --- `./gradlew -Pq build` and a manual verification in Vagrant. Thanks, Stephan Erb

Re: Review Request 35840: Don't warn about unoptimized Operations

2015-06-26 Thread Stephan Erb
/StreamManagerImpl.java 12da352a749fe5d974b0cd69eda0b694b0a90bf4 Diff: https://reviews.apache.org/r/35840/diff/ Testing --- ./gradlew -Pq build Thanks, Stephan Erb

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-26 Thread Stephan Erb
cb98834e925793fc116814371548a30470830164 src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d Diff: https://reviews.apache.org/r/35498/diff/ Testing --- `./gradlew -Pq build` and a manual verification in Vagrant. Thanks, Stephan Erb

Re: Review Request 35840: Don't warn about unoptimized Operations

2015-06-26 Thread Stephan Erb
/aurora/scheduler/storage/log/StreamManagerImpl.java 12da352a749fe5d974b0cd69eda0b694b0a90bf4 Diff: https://reviews.apache.org/r/35840/diff/ Testing --- ./gradlew -Pq build Thanks, Stephan Erb

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-26 Thread Stephan Erb
rather than direct field access. Stephan Erb wrote: I can submit an updated patch tonight. I've somewhat expected that some of you would point it out :-) I thought about adding these when writing the patch but then decided against them: Getters for final attributes on an inner

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-24 Thread Stephan Erb
cb98834e925793fc116814371548a30470830164 src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d Diff: https://reviews.apache.org/r/35498/diff/ Testing --- `./gradlew -Pq build` and a manual verification in Vagrant. Thanks, Stephan Erb

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-24 Thread Stephan Erb
cb98834e925793fc116814371548a30470830164 src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d Diff: https://reviews.apache.org/r/35498/diff/ Testing --- `./gradlew -Pq build` and a manual verification in Vagrant. Thanks, Stephan Erb

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-26 Thread Stephan Erb
src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d Diff: https://reviews.apache.org/r/35498/diff/ Testing --- `./gradlew -Pq build` and a manual verification in Vagrant. Thanks, Stephan Erb

Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-16 Thread Stephan Erb
, Stephan Erb

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-16 Thread Stephan Erb
://reviews.apache.org/r/35498/diff/ Testing --- `./gradlew -Pq build` and a manual verification in Vagrant. Thanks, Stephan Erb

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-16 Thread Stephan Erb
(line 65) https://reviews.apache.org/r/35498/#comment140450 Using a list of enums instead of serveral bools will also help to simplify this code. - Stephan Erb On June 16, 2015, 11 a.m., Stephan Erb wrote

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-07-01 Thread Stephan Erb
this is a great idea. For details, see: https://github.com/prometheus/mesos_exporter/issues/7 - Stephan Erb On June 30, 2015, 9:36 p.m., Stephan Erb wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-30 Thread Stephan Erb
://reviews.apache.org/r/35990/#review89750 --- On June 28, 2015, 10:44 p.m., Stephan Erb wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-07-01 Thread Stephan Erb
/diff/ Testing --- `./gradlew -Pq build` and a manual verification in Vagrant. Thanks, Stephan Erb

Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-28 Thread Stephan Erb
/mesos/MesosTaskFactoryImplTest.java 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 Diff: https://reviews.apache.org/r/35990/diff/ Testing --- ./gradlew -Pq build Thanks, Stephan Erb

Re: Review Request 36064: Perform leader redirect using HTTP status code 307

2015-07-05 Thread Stephan Erb
/java/org/apache/aurora/scheduler/http/ServletFilterTest.java f8b134fa1f3fbbd7affef31acb077e7acd4f9761 Diff: https://reviews.apache.org/r/36064/diff/ Testing --- ./gradlew -Pq build Thanks, Stephan Erb

Re: Review Request 34020: Normalize SLA stat names

2015-07-05 Thread Stephan Erb
/aurora/blob/827b9abea48babe53ad5b2c521757c60f04c6dfc/src/main/java/org/apache/aurora/scheduler/TaskVars.java#L110 - Stephan Erb On June 13, 2015, 1:18 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-07-05 Thread Stephan Erb
rather than direct field access. Stephan Erb wrote: I can submit an updated patch tonight. I've somewhat expected that some of you would point it out :-) I thought about adding these when writing the patch but then decided against them: Getters for final attributes on an inner

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-07-05 Thread Stephan Erb
On July 1, 2015, 1:59 p.m., Stephan Erb wrote: For sake of transparency: Turns out not everyone thinks this is a great idea. For details, see: https://github.com/prometheus/mesos_exporter/issues/7 Bill Farner wrote: Would it be reasonable to impose namespacing of labels

Re: Review Request 37560: Adding TierManager initial implementation.

2015-08-18 Thread Stephan Erb
) https://reviews.apache.org/r/37560/#comment150864 For better readability, how about using an enum? - Stephan Erb On Aug. 18, 2015, 7:04 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 37560: Adding TierManager initial implementation.

2015-08-18 Thread Stephan Erb
On Aug. 18, 2015, 8:08 p.m., Stephan Erb wrote: src/main/java/org/apache/aurora/scheduler/TierInfo.java, line 27 https://reviews.apache.org/r/37560/diff/2/?file=1043194#file1043194line27 For better readability, how about using an enum? Maxim Khutornenko wrote: Not sure I

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-30 Thread Stephan Erb
` and a manual verification in Vagrant. Thanks, Stephan Erb

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2015-06-30 Thread Stephan Erb
, Stephan Erb

Review Request 36064: Perform leader redirect using HTTP status code 307

2015-06-30 Thread Stephan Erb
f8b134fa1f3fbbd7affef31acb077e7acd4f9761 Diff: https://reviews.apache.org/r/36064/diff/ Testing --- ./gradlew -Pq build Thanks, Stephan Erb

Re: Review Request 36700: Remove references to binary build targets that are not currently for general consumption.

2015-07-28 Thread Stephan Erb
the same flexibility nor the same performance (subprocess call and thrift connections take rather long). - Stephan Erb On July 28, 2015, 2:58 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 36436: Prevent job updates from allowing unbounded instance events

2015-07-13 Thread Stephan Erb
configuration. src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java (line 173) https://reviews.apache.org/r/36436/#comment144795 Same as above. It is hard to understand the implications of this option without reading the code. - Stephan Erb On July 12, 2015, 8:49 p.m

Re: Review Request 39670: Create immutable copy of offers for PendingTaskProcessor.

2015-10-26 Thread Stephan Erb
/PendingTaskProcessor.java (line 133) <https://reviews.apache.org/r/39670/#comment162352> Couldn't we run into the same `ConcurrentModificationException` if the offer list is modified while `ImmutableList.copyOf()` is executed? - Stephan Erb On Oct. 27, 2015, 12:16 a.m., Zameer Manji

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106558 --- Ship it! A working build on Arch, thanks for that\! - Stephan

Review Request 39854: Retry scheduler connection after unknown failures

2015-11-02 Thread Stephan Erb
1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 Diff: https://reviews.apache.org/r/39854/diff/ Testing --- ./pants test.pytest --options=-v src/test/python/apache/aurora/client/api:scheduler_client Thanks, Stephan Erb

Re: Review Request 39823: Eliminate duplicate docu in configuration tutorial

2015-10-30 Thread Stephan Erb
ba0dc864a10726456373c23b508e04dd3b08a3ef docs/configuration-tutorial.md bbb1684645b628df5fe8a45fcce6813e718157af Diff: https://reviews.apache.org/r/39823/diff/ Testing --- Rendered documentation is available at https://github.com/StephanErb/aurora/blob/dedup-docu Thanks, Stephan Erb

Re: Review Request 39823: Eliminate duplicate docu in configuration tutorial

2015-10-30 Thread Stephan Erb
--- Rendered documentation is available at https://github.com/StephanErb/aurora/blob/dedup-docu Thanks, Stephan Erb

Re: Review Request 39073: Generalize plugin interface for aurora client.

2015-10-11 Thread Stephan Erb
to write a plugin and merge it into the client pex using PEX_PATH)?. I believe that otherwise most adopters of Aurora will not discover this great feature. - Stephan Erb On Oct. 7, 2015, 7:29 a.m., Brian Wickman wrote

Re: Review Request 39057: "aurora config read" command

2015-10-11 Thread Stephan Erb
) <https://reviews.apache.org/r/39057/#comment159759> I find it a little bit confusing that this command is called `read`. Isn't the `bind` the most important step it does? - Stephan Erb On Oct. 6, 2015, 8:43 p.m., Brian Wickman

Review Request 39169: Minor improvement of the storoge documentation

2015-10-09 Thread Stephan Erb
--- Fix minor inconsistencies in the storoge documentation. Diffs - docs/storage-config.md 4ec33a14d3361dfd7f5c07a1d01e31bb96243029 Diff: https://reviews.apache.org/r/39169/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 39169: Fix minor inconsistencies in the storage documentation

2015-10-09 Thread Stephan Erb
://reviews.apache.org/r/39169/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 36064: Perform leader redirect using HTTP status code 307

2015-07-08 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36064/#review90931 --- Friendly ping. Anything still missing here? - Stephan Erb

Re: Review Request 34020: Normalize SLA stat names

2015-07-08 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review90933 --- Joe, have you tested this change in vagrant? - Stephan Erb

Re: Review Request 36305: Remove restriction that -hostname must resolve.

2015-07-08 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36305/#review90989 --- Ship it! Ship It! - Stephan Erb On July 8, 2015, 2:53 p.m

Re: Review Request 36362: Upgrade to gradle 2.5.

2015-07-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36362/#review91170 --- You forgot to update the debian and rpm dependencies. - Stephan

Re: Review Request 36365: Upgrade gradle version dependencies in rpm/deb specs.

2015-07-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36365/#review91195 --- Ship it! Ship It! - Stephan Erb On July 9, 2015, 9:52 p.m

Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-29 Thread Stephan Erb
On Aug. 26, 2015, 7:55 p.m., Zameer Manji wrote: The ticket referenced also talks about {{mesos.ip}}, will you also add support for that? Steve Niemitz wrote: It's not exposed anywhere by mesos AFAIK. If someone can correct me I can add it in another review. I have to agree,

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-15 Thread Stephan Erb
> On Sept. 16, 2015, 2:51 a.m., Bill Farner wrote: > > docs/configuration-tutorial.md, line 583 > > > > > > Woah, this is a new doc to me...seems significantly redundant with > > configuration-reference.md. All

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-11 Thread Stephan Erb
) <https://reviews.apache.org/r/38270/#comment155097> The title is rather specific and might not match what people outside of Twitter use the job_viz_url for. Besides that: Awesome improvement! - Stephan Erb On Sept. 11, 2015, 4:23 a.m., Joshua Cohen

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-15 Thread Stephan Erb
to the issue addressed in this review request, so feel free to dismiss it here) - Stephan Erb On Sept. 15, 2015, 1:50 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 38390: Adding oversubscription summary.

2015-09-15 Thread Stephan Erb
tps://reviews.apache.org/r/38390/#comment155921> How about attaching a date or version classifier here? Makes it much easier for a reader to understand if this is a valid concern or if the docu is just out of date (unfortunately that is rather common in many projects). - Stephan Erb On Sept. 15, 2015

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-11 Thread Stephan Erb
> On Sept. 11, 2015, 9:55 a.m., Stephan Erb wrote: > > src/main/resources/scheduler/assets/breadcrumb.html, line 35 > > <https://reviews.apache.org/r/38270/diff/2/?file=1067960#file1067960line35> > > > > The title is rather specific and might not match what p

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-11 Thread Stephan Erb
> On Sept. 11, 2015, 9:55 a.m., Stephan Erb wrote: > > src/main/resources/scheduler/assets/breadcrumb.html, line 35 > > <https://reviews.apache.org/r/38270/diff/2/?file=1067960#file1067960line35> > > > > The title is rather specific and might not match what p

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-12-11 Thread Stephan Erb
terall, it will be his disk quota / resources that will be affected by disabling the rotation. - Stephan Erb On Nov. 25, 2015, 6 p.m., George Sirois wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.

2015-12-14 Thread Stephan Erb
just recently urged users not to skip updates (http://www.mail-archive.com/user@mesos.apache.org/msg05379.html). - Stephan Erb On Dec. 12, 2015, 5:49 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 41331: Upgrade to pants 0.0.64 and pex 1.1.1.

2015-12-14 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41331/#review110213 --- Ship it! Ship It! - Stephan Erb On Dec. 14, 2015, 12:32 a.m

Re: Review Request 41368: Remove the client-side updater.

2015-12-15 Thread Stephan Erb
indicates that the old updater supported non-service updates, whereas the new one doesn't. We should at least communicate that more clearly. - Stephan Erb On Dec. 14, 2015, 11:36 p.m., Bill Farner wrote: > > --- > This is an auto

Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

2015-12-18 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41528/#review57 --- Ship it! Thanks for looking into this! - Stephan Erb On Dec

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-10 Thread Stephan Erb
pache.org/r/41201/#comment169373> This will also override variables like HOME specified above. Is this intended? - Stephan Erb On Dec. 10, 2015, 1:24 p.m., Kasisnu Singh wrote: > > --- > This is an automatically gener

Re: Review Request 41844: Update and slightly extend the beginner tutorial

2016-01-03 Thread Stephan Erb
://github.com/StephanErb/aurora/blob/tutorial/docs/tutorial.md Thanks, Stephan Erb

Re: Review Request 41809: Allow custom announce path

2016-01-04 Thread Stephan Erb
) <https://reviews.apache.org/r/41809/#comment173180> This comment does somewhat imply that I can use a path containing variables. Also the rest of the documentation leaves this somewhat unclear. - Stephan Erb On Jan. 4, 2016, 10:28 p.m., Kunal Thakar

Re: Review Request 41897: Upgrade to the latest zk point release.

2016-01-04 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41897/#review112679 --- News file needs updating too :-) - Stephan Erb On Jan. 5, 2016

Review Request 41846: Add a list of Aurora design documents

2016-01-02 Thread Stephan Erb
/diff/ Testing --- Rendered version is available at https://github.com/StephanErb/aurora/blob/design-docs/docs/design-documents.md Thanks, Stephan Erb

Re: Review Request 41846: Add a list of Aurora design documents

2016-01-02 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41846/#review112431 --- @ReviewBot retry - Stephan Erb On Jan. 2, 2016, 1:43 p.m

Re: Review Request 41717: Very Very WIP: Add jittering as an option to BackoffStrategy.

2016-01-01 Thread Stephan Erb
> On Dec. 27, 2015, 11:11 p.m., Stephan Erb wrote: > > Thanks for your effort. > > > > I believe `ExpBackoffEqualJitter.java` is the most usefull strategy. It is > > the closest to the current design while still resolving the problem > > depi

Review Request 41844: Update and slightly extend the beginner tutorial

2016-01-01 Thread Stephan Erb
4628241d7baa507fc17414d7cdb40e76e6d609a5 Diff: https://reviews.apache.org/r/41844/diff/ Testing --- Rendered version is available at https://github.com/StephanErb/aurora/blob/docu-update/docs/tutorial.md Thanks, Stephan Erb

Review Request 41853: Add recent Aurora-related talks

2016-01-02 Thread Stephan Erb
/presentations.md. Thanks, Stephan Erb

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

2016-01-06 Thread Stephan Erb
> On Dec. 29, 2015, 1:37 p.m., Stephan Erb wrote: > > Looks like the 3.4 client also requires a 3.4 ZK server [1]. So, would it > > be possible to get a deprecation cycle for that change (i.e., announce in > > 0.12 and bump in 0.13)? > > > > Unfortunately,

Re: Review Request 41786: Remove several scheduler command line arguments.

2015-12-31 Thread Stephan Erb
pache.org/r/41786/#comment172887> I've always thought those are somewhat meant to be used for backup recovery as an alternative to blocking the HTTP port? https://github.com/apache/aurora/blob/master/docs/storage-config.md#preparation. Maybe someone can ask @jsmith or another SRE

Re: Review Request 41778: Simplify test BUILD files to one target per directory.

2015-12-29 Thread Stephan Erb
> On Dec. 29, 2015, 11:44 p.m., Stephan Erb wrote: > > Would be awesome if you could document the druid knowledge of how to > > properly execute tests (single test, all tests, ...). > > > > There is already this > > http

Re: Review Request 41786: Remove several scheduler command line arguments.

2015-12-31 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41786/#review112401 --- Ship it! Ship It! - Stephan Erb On Dez. 30, 2015, 2:52 vorm

Re: Review Request 41786: Remove several scheduler command line arguments.

2015-12-31 Thread Stephan Erb
> On Dez. 31, 2015, 3:41 nachm., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java, > > line 67 > > <https://reviews.apache.org/r/41786/diff/1/?file=1178110#file1178110line67> > > > > These docs are now

Re: Review Request 41778: Simplify test BUILD files to one target per directory.

2015-12-29 Thread Stephan Erb
contributors up to speed. - Stephan Erb On Dec. 29, 2015, 11:32 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-08 Thread Stephan Erb
there: docs/deploying-aurora-scheduler.md (line 187) <https://reviews.apache.org/r/42077/#comment174250> Make it more explicit that those will only be used if a job has no custom paramters. - Stephan Erb On Jan. 8, 2016, 7:28 p.m., George Sirois

Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.

2016-01-03 Thread Stephan Erb
/TruncatedBinaryBackoffTest.java (line 74) <https://reviews.apache.org/r/41717/#comment172920> Copy paste error here. - Stephan Erb On Jan. 3, 2016, 4:39 p.m., Tony Dong wrote: > > --- > This is an automatically g

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

2016-01-07 Thread Stephan Erb
> On Jan. 6, 2016, 10:02 nachm., Stephan Erb wrote: > > src/main/python/apache/thermos/core/process.py, line 561 > > <https://reviews.apache.org/r/40922/diff/8/?file=1180836#file1180836line561> > > > > Is this timeout change intentional? > > Mar

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

2016-01-06 Thread Stephan Erb
g/r/40922/#comment173630> Is this path actually needed? Doesn't the command line argument default to FILE anyway? - Stephan Erb On Jan. 4, 2016, 1:25 p.m., Martin Hrabovcin wrote: > > --- > This is an automatically gener

Re: Review Request 41725: Add component deployment diagram

2015-12-26 Thread Stephan Erb
-a5a5-184c7aeacdcf__components.png Thanks, Stephan Erb

Re: Review Request 41725: Add component deployment diagram

2015-12-26 Thread Stephan Erb
/uploaded/files/2015/12/26/d1f51a1e-9125-40cf-a5a5-184c7aeacdcf__components.png Thanks, Stephan Erb

Review Request 41725: Add component deployment diagram

2015-12-26 Thread Stephan Erb
/ Testing --- Rendered page is available at https://github.com/StephanErb/aurora/blob/fmc/docs/installing.md Thanks, Stephan Erb

Re: Review Request 41725: Add component deployment diagram

2015-12-26 Thread Stephan Erb
/uploaded/files/2015/12/26/cca230da-a6c8-4957-890d-1c7b24e0604d__components.png Thanks, Stephan Erb

Re: Review Request 41725: Add component deployment diagram

2015-12-26 Thread Stephan Erb
ly generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/#review111905 ------- On Dec. 26, 2015, 5:23 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-m

Re: Review Request 41537: Upgrade mesos dependency to 0.25.0

2015-12-26 Thread Stephan Erb
for mesos.native==0.25.0: mesos.native==0.25.0 The end-to-end tests are failing to me. Is that local issue or do we need to upload that egg somewhere? - Stephan Erb On Dec. 23, 2015, 9:10 p.m., Bill Farner wrote

  1   2   3   4   5   6   7   8   9   10   >