Re: Review Request 42387: working version of jessie builds

[Benjamin Staffin]

> On Jan. 19, 2016, 4:12 p.m., John Sirois wrote:
> > builder/deb/debian-jessie/Dockerfile, line 38
> > 
> >
> > Its not exactly clear to me how this is any better than downloading 
> > gradle from gradle.  Since this is only used for the builder it seems to me 
> > the only relevant details is - not a standard package install - aka a 
> > ~random internet download.  If the plan is that benley's work here makes it 
> > upstream to a standard debian deb repo I think its worth a comment pointing 
> > that expected future out.  As it stands w/o that comment and forgetting we 
> > know and trust benley, this looks on the face decidedly worse than going 
> > straight to the gradle source.
> 
> Dmitriy Shirchenko wrote:
> Done.

I originally put together that gradle-packaging stuff to make it possible to 
build aurora inside of cowbuilder/pbuilder, where (at least in theory) all the 
build dependencies are supposed to be satisfiable with apt-get.  It's not as 
relevant to the docker-based process being used here, but removing it does mean 
there will be a build dep that isn't mentioned in the control file at all...


> On Jan. 19, 2016, 4:12 p.m., John Sirois wrote:
> > specs/debian/aurora-executor.thermos.init, line 22
> > 
> >
> > This is admittedly all over the place across our packages and OSs 
> > already before your change, but for the deb scheduler we have 
> > `/var/run/aurora-scheduler.pid` - how about `/var/run/aurora-observer.pid` 
> > or `/var/run/thermos-observer.pid`, some consistency here would be useful I 
> > think for discovery purposes.
> 
> Dmitriy Shirchenko wrote:
> Done.

I haven't seen this called aurora-observer anywhere else before.  I would have 
strongly preferred /var/run/thermos-observer.pid here, unless thermos observer 
itself is being renamed.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review115281
---


On Jan. 21, 2016, 2:20 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 21, 2016, 2:20 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   specs/debian/aurora-scheduler.upstart 
> 1ceb7042485efedcf7136b51737107aada4c4e96 
>   specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review115719
---

Ship it!


Ship It!

- Bill Farner


On Jan. 21, 2016, 2:20 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 21, 2016, 2:20 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   specs/debian/aurora-scheduler.upstart 
> 1ceb7042485efedcf7136b51737107aada4c4e96 
>   specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[Bill Farner]

> On Jan. 20, 2016, 5:26 p.m., Bill Farner wrote:
> > specs/debian/aurora-executor.thermos.init, lines 43-44
> > 
> >
> > Is this necessary due to `app_daemonize` or is there more to it?
> 
> Dmitriy Shirchenko wrote:
> im not really sure tbh. these were suggestions from +benley.
> 
> but are you asking about the format change or log_dir change? log_to_disk 
> was supposed to make it consistent and it was told me to it's better. 
> 
> i am not sure what log_dir was before, but now it's explicit and i see 
> logs going there.

My only complaint is that the logging behavior will be inconsistent for 
operators.  At any rate, i'd rather ship and iterate.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review115532
---


On Jan. 21, 2016, 2:20 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 21, 2016, 2:20 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   specs/debian/aurora-scheduler.upstart 
> 1ceb7042485efedcf7136b51737107aada4c4e96 
>   specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[Dmitriy Shirchenko]

> On Jan. 21, 2016, 1:26 a.m., Bill Farner wrote:
> > build-artifact.sh, line 35
> > 
> >
> > How about a selective `set -x`, `set +x` around the commands you wish 
> > to see echoed instead?

Removed. Adding set -x, set +x to my arsenal when debugging shell scripts. 
Thanks.


> On Jan. 21, 2016, 1:26 a.m., Bill Farner wrote:
> > builder/deb/debian-jessie/Dockerfile, line 37
> > 
> >
> > FYI - the deb has a build-time dep of a package named 'gradle', so it 
> > would be slightly more involved than that.

Thanks. Clarified comment.


> On Jan. 21, 2016, 1:26 a.m., Bill Farner wrote:
> > builder/deb/debian-jessie/build.sh, line 1
> > 
> >
> > Checking my recollection - this can't be a symlink due to the way it's 
> > mounted with docker, right?  If that's correct, can you leave a TODO for me 
> > to figure out how to share these files?

Sure. There could be an easy way to mounting the file into the container, but 
yea, leaving a TODO.


> On Jan. 21, 2016, 1:26 a.m., Bill Farner wrote:
> > specs/debian/aurora-executor.thermos.init, lines 43-44
> > 
> >
> > Is this necessary due to `app_daemonize` or is there more to it?

im not really sure tbh. these were suggestions from +benley.

but are you asking about the format change or log_dir change? log_to_disk was 
supposed to make it consistent and it was told me to it's better. 

i am not sure what log_dir was before, but now it's explicit and i see logs 
going there.


- Dmitriy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review115532
---


On Jan. 20, 2016, 12:59 a.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 20, 2016, 12:59 a.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   specs/debian/aurora-scheduler.upstart 
> 1ceb7042485efedcf7136b51737107aada4c4e96 
>   specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[Dmitriy Shirchenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/
---

(Updated Jan. 21, 2016, 10:20 p.m.)


Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.


Repository: aurora-packaging


Description
---

Adding debian jessie packaging with a test.


Diffs (updated)
-

  builder/deb/debian-jessie/Dockerfile PRE-CREATION 
  builder/deb/debian-jessie/build.sh PRE-CREATION 
  builder/deb/debian-jessie/pants.ini PRE-CREATION 
  specs/debian/aurora-executor.thermos.init 
e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
  specs/debian/aurora-executor.thermos.service PRE-CREATION 
  specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
  specs/debian/aurora-scheduler.service PRE-CREATION 
  specs/debian/aurora-scheduler.upstart 
1ceb7042485efedcf7136b51737107aada4c4e96 
  specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
  test/deb/debian-jessie/README.md PRE-CREATION 
  test/deb/debian-jessie/Vagrantfile PRE-CREATION 
  test/deb/debian-jessie/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/42387/diff/


Testing
---

New build with a test that starts a Vagrant and following README should lead to 
a successful job.


Thanks,

Dmitriy Shirchenko

Re: Review Request 42387: working version of jessie builds

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review115532
---


Mostly questions for posterity.


build-artifact.sh (line 35)


How about a selective `set -x`, `set +x` around the commands you wish to 
see echoed instead?



builder/deb/debian-jessie/Dockerfile (line 37)


FYI - the deb has a build-time dep of a package named 'gradle', so it would 
be slightly more involved than that.



builder/deb/debian-jessie/build.sh (line 1)


Checking my recollection - this can't be a symlink due to the way it's 
mounted with docker, right?  If that's correct, can you leave a TODO for me to 
figure out how to share these files?



specs/debian/aurora-executor.thermos.init (lines 43 - 44)


Is this necessary due to `app_daemonize` or is there more to it?


- Bill Farner


On Jan. 19, 2016, 4:59 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 19, 2016, 4:59 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   specs/debian/aurora-scheduler.upstart 
> 1ceb7042485efedcf7136b51737107aada4c4e96 
>   specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review115480
---

Ship it!


This lgtm.  I re-ran through fresh builds of all packages and tested both the 
debian-jessie and ubuntu-trusty installs worked, logs were present in the 
expected system location (journalctl vs /var/log/upstart), and that the 
scheduler and observer both correctly re-spawned when killed.

NB: Our standard review procedure is last reviewer patches in unless there are 
very large delays - so hang on for more feedback from others.

- John Sirois


On Jan. 19, 2016, 5:59 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 19, 2016, 5:59 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   specs/debian/aurora-scheduler.upstart 
> 1ceb7042485efedcf7136b51737107aada4c4e96 
>   specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[John Sirois]

> On Jan. 17, 2016, 3:54 a.m., Stephan Erb wrote:
> > specs/debian/aurora-scheduler.init, line 73
> > 
> >
> > IIRC the `start-stop-daemon` does not restart failed processes. How 
> > does this interact with Aurora commiting suicide at least onces a day?
> 
> Dmitriy Shirchenko wrote:
> Thanks. I added .service file which will respawn failed processes.

That does not solve the ubuntu-trusty case, but I built debs with this diff and 
ran through a fresh `test/deb/ubuntu-trusty/` session and found I could kill 
both the observer and the scheduler and they were re-spawned.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review114903
---


On Jan. 19, 2016, 5:59 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 19, 2016, 5:59 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   specs/debian/aurora-scheduler.upstart 
> 1ceb7042485efedcf7136b51737107aada4c4e96 
>   specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[Dmitriy Shirchenko]

> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote:
> > specs/debian/aurora-scheduler.postinst, line 38
> > 
> >
> > `specs/debian/aurora-scheduler.init` uses 
> > `PIDFILE=/var/run/aurora-scheduler.pid` - who uses `/var/run/aurora/`?

Done.


> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote:
> > specs/debian/aurora-executor.thermos.init, line 54
> > 
> >
> > Not sure the with $ARGS makes much sense for stop, it might even be a 
> > lie when stopping an older deploy.

Done.


> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote:
> > builder/deb/debian-jessie/Dockerfile, line 38
> > 
> >
> > Its not exactly clear to me how this is any better than downloading 
> > gradle from gradle.  Since this is only used for the builder it seems to me 
> > the only relevant details is - not a standard package install - aka a 
> > ~random internet download.  If the plan is that benley's work here makes it 
> > upstream to a standard debian deb repo I think its worth a comment pointing 
> > that expected future out.  As it stands w/o that comment and forgetting we 
> > know and trust benley, this looks on the face decidedly worse than going 
> > straight to the gradle source.

Done.


> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote:
> > specs/debian/aurora-executor.thermos.init, line 22
> > 
> >
> > This is admittedly all over the place across our packages and OSs 
> > already before your change, but for the deb scheduler we have 
> > `/var/run/aurora-scheduler.pid` - how about `/var/run/aurora-observer.pid` 
> > or `/var/run/thermos-observer.pid`, some consistency here would be useful I 
> > think for discovery purposes.

Done.


- Dmitriy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review115281
---


On Jan. 20, 2016, 12:59 a.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 20, 2016, 12:59 a.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   specs/debian/aurora-scheduler.upstart 
> 1ceb7042485efedcf7136b51737107aada4c4e96 
>   specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[Dmitriy Shirchenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/
---

(Updated Jan. 20, 2016, 12:59 a.m.)


Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.


Repository: aurora-packaging


Description
---

Adding debian jessie packaging with a test.


Diffs (updated)
-

  build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
  builder/deb/debian-jessie/Dockerfile PRE-CREATION 
  builder/deb/debian-jessie/build.sh PRE-CREATION 
  builder/deb/debian-jessie/pants.ini PRE-CREATION 
  specs/debian/aurora-executor.thermos.init 
e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
  specs/debian/aurora-executor.thermos.service PRE-CREATION 
  specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
  specs/debian/aurora-scheduler.service PRE-CREATION 
  specs/debian/aurora-scheduler.upstart 
1ceb7042485efedcf7136b51737107aada4c4e96 
  specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
  test/deb/debian-jessie/README.md PRE-CREATION 
  test/deb/debian-jessie/Vagrantfile PRE-CREATION 
  test/deb/debian-jessie/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/42387/diff/


Testing
---

New build with a test that starts a Vagrant and following README should lead to 
a successful job.


Thanks,

Dmitriy Shirchenko

Re: Review Request 42387: working version of jessie builds

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review115281
---


I'm running through a test presently - will report back.


specs/debian/aurora-executor.thermos.init (line 54)


Not sure the with $ARGS makes much sense for stop, it might even be a lie 
when stopping an older deploy.



builder/deb/debian-jessie/Dockerfile (line 38)


Its not exactly clear to me how this is any better than downloading gradle 
from gradle.  Since this is only used for the builder it seems to me the only 
relevant details is - not a standard package install - aka a ~random internet 
download.  If the plan is that benley's work here makes it upstream to a 
standard debian deb repo I think its worth a comment pointing that expected 
future out.  As it stands w/o that comment and forgetting we know and trust 
benley, this looks on the face decidedly worse than going straight to the 
gradle source.



specs/debian/aurora-executor.thermos.init (line 22)


This is admittedly all over the place across our packages and OSs already 
before your change, but for the deb scheduler we have 
`/var/run/aurora-scheduler.pid` - how about `/var/run/aurora-observer.pid` or 
`/var/run/thermos-observer.pid`, some consistency here would be useful I think 
for discovery purposes.



specs/debian/aurora-scheduler.postinst (line 38)


`specs/debian/aurora-scheduler.init` uses 
`PIDFILE=/var/run/aurora-scheduler.pid` - who uses `/var/run/aurora/`?


- John Sirois


On Jan. 19, 2016, 5:04 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 19, 2016, 5:04 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.postinst 
> 0d019b6ecace73c69c833ff2267fe95e11cf2f8d 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   specs/debian/aurora-scheduler.upstart 
> 1ceb7042485efedcf7136b51737107aada4c4e96 
>   specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[Dmitriy Shirchenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/
---

(Updated Jan. 20, 2016, 12:04 a.m.)


Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.


Repository: aurora-packaging


Description
---

Adding debian jessie packaging with a test.


Diffs (updated)
-

  build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
  builder/deb/debian-jessie/Dockerfile PRE-CREATION 
  builder/deb/debian-jessie/build.sh PRE-CREATION 
  builder/deb/debian-jessie/pants.ini PRE-CREATION 
  specs/debian/aurora-executor.thermos.init 
e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
  specs/debian/aurora-executor.thermos.service PRE-CREATION 
  specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
  specs/debian/aurora-scheduler.postinst 
0d019b6ecace73c69c833ff2267fe95e11cf2f8d 
  specs/debian/aurora-scheduler.service PRE-CREATION 
  specs/debian/aurora-scheduler.upstart 
1ceb7042485efedcf7136b51737107aada4c4e96 
  specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
  test/deb/debian-jessie/README.md PRE-CREATION 
  test/deb/debian-jessie/Vagrantfile PRE-CREATION 
  test/deb/debian-jessie/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/42387/diff/


Testing
---

New build with a test that starts a Vagrant and following README should lead to 
a successful job.


Thanks,

Dmitriy Shirchenko

Re: Review Request 42387: working version of jessie builds

[Dmitriy Shirchenko]

> On Jan. 17, 2016, 10:59 p.m., John Sirois wrote:
> > This built fine for me, and installed fine as well, but the resulting 
> > scheduler has stdout and stderr attached to /dev/null which needs to be 
> > fixed (no logs).  I had a harder time than I might resoning through things 
> > since this setup re-uses the ubuntu init arrangement, but under systemd.  
> > This means systemd generates a unit file on the fly to bridge the sysv 
> > init.  Had you thought about this extra indirection?  It seems like it 
> > would be easier to deal with a direct systemd setup / unit file like the 
> > centos builder has.

Yup, talked offline and now you can see the logs via 'journalctl -u 
aurora-scheduler'. 1,2 fds are no longer going to /dev/null. 

java31858 aurora1u  unix 0x880036c01bc0  0t0 140592 socket
java31858 aurora2u  unix 0x880036c01bc0  0t0 140592 socket

For record keeping, this was done via --no-close option to stop-start-daemon


> On Jan. 17, 2016, 10:59 p.m., John Sirois wrote:
> > builder/deb/debian-jessie/build.sh, line 40
> > 
> >
> > What's this? Cruft to kill?

Done.


- Dmitriy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review114872
---


On Jan. 19, 2016, 11:23 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 19, 2016, 11:23 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.postinst 
> 0d019b6ecace73c69c833ff2267fe95e11cf2f8d 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[Dmitriy Shirchenko]

> On Jan. 17, 2016, 10:54 a.m., Stephan Erb wrote:
> > specs/debian/aurora-scheduler.init, line 73
> > 
> >
> > IIRC the `start-stop-daemon` does not restart failed processes. How 
> > does this interact with Aurora commiting suicide at least onces a day?

Thanks. I added .service file which will respawn failed processes.


> On Jan. 17, 2016, 10:54 a.m., Stephan Erb wrote:
> > builder/deb/debian-jessie/build.sh, line 32
> > 
> >
> > Given that the packages should become official, it might be worthwhile 
> > to change this one here.

Done.


- Dmitriy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review114903
---


On Jan. 19, 2016, 11:23 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 19, 2016, 11:23 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.postinst 
> 0d019b6ecace73c69c833ff2267fe95e11cf2f8d 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[Dmitriy Shirchenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/
---

(Updated Jan. 19, 2016, 11:23 p.m.)


Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.


Repository: aurora-packaging


Description
---

Adding debian jessie packaging with a test.


Diffs (updated)
-

  build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
  builder/deb/debian-jessie/Dockerfile PRE-CREATION 
  builder/deb/debian-jessie/build.sh PRE-CREATION 
  builder/deb/debian-jessie/pants.ini PRE-CREATION 
  specs/debian/aurora-executor.thermos.init 
e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
  specs/debian/aurora-executor.thermos.service PRE-CREATION 
  specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
  specs/debian/aurora-scheduler.postinst 
0d019b6ecace73c69c833ff2267fe95e11cf2f8d 
  specs/debian/aurora-scheduler.service PRE-CREATION 
  test/deb/debian-jessie/README.md PRE-CREATION 
  test/deb/debian-jessie/Vagrantfile PRE-CREATION 
  test/deb/debian-jessie/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/42387/diff/


Testing
---

New build with a test that starts a Vagrant and following README should lead to 
a successful job.


Thanks,

Dmitriy Shirchenko

Re: Review Request 42387: working version of jessie builds

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review115221
---



specs/debian/aurora-scheduler.init (line 73)


Spoke with Dmitriy offline, but it turns out passing `--no-close` is 
critical here to un-blackhole logs and let stderr/stdout stay open and routed 
through the standard systemd journalling.


- John Sirois


On Jan. 16, 2016, 12:26 a.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 16, 2016, 12:26 a.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review114872
---


This built fine for me, and installed fine as well, but the resulting scheduler 
has stdout and stderr attached to /dev/null which needs to be fixed (no logs).  
I had a harder time than I might resoning through things since this setup 
re-uses the ubuntu init arrangement, but under systemd.  This means systemd 
generates a unit file on the fly to bridge the sysv init.  Had you thought 
about this extra indirection?  It seems like it would be easier to deal with a 
direct systemd setup / unit file like the centos builder has.


builder/deb/debian-jessie/build.sh (line 40)


What's this? Cruft to kill?


- John Sirois


On Jan. 16, 2016, 12:26 a.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 16, 2016, 12:26 a.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review114903
---



builder/deb/debian-jessie/build.sh (line 32)


Given that the packages should become official, it might be worthwhile to 
change this one here.



specs/debian/aurora-scheduler.init (line 72)


IIRC the `start-stop-daemon` does not restart failed processes. How does 
this interact with Aurora commiting suicide at least onces a day?


- Stephan Erb


On Jan. 16, 2016, 8:26 a.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 16, 2016, 8:26 a.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

[Dmitriy Shirchenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/
---

(Updated Jan. 16, 2016, 7:26 a.m.)


Review request for Aurora, John Sirois and Bill Farner.


Repository: aurora-packaging


Description (updated)
---

Adding debian jessie packaging with a test.


Diffs
-

  build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
  builder/deb/debian-jessie/Dockerfile PRE-CREATION 
  builder/deb/debian-jessie/build.sh PRE-CREATION 
  builder/deb/debian-jessie/pants.ini PRE-CREATION 
  specs/debian/aurora-executor.thermos.init 
e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
  specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
  test/deb/debian-jessie/README.md PRE-CREATION 
  test/deb/debian-jessie/Vagrantfile PRE-CREATION 
  test/deb/debian-jessie/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/42387/diff/


Testing
---

New build with a test that starts a Vagrant and following README should lead to 
a successful job.


Thanks,

Dmitriy Shirchenko