Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125903 --- Master (f28f41a) is red with this patch. ./build-support/jenkins

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-29 Thread George Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/ --- (Updated March 29, 2016, 4:18 p.m.) Review request for Aurora, Joshua Cohen, St

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125887 --- Ship it! LGTM, thanks for adding the tests! If you don't mind

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125827 --- Ship it! Master (f28f41a) is green with this patch. ./build-s

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread George Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/ --- (Updated March 29, 2016, 5:49 a.m.) Review request for Aurora, Joshua Cohen, St

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread Joshua Cohen
> On March 29, 2016, 12:03 a.m., Joshua Cohen wrote: > > Are there any concerns about any other unintended side effect of setting > > $HOME to the sandbox? I suppose it's opt-in for now, so that allays most > > fears. > > George Sirois wrote: > I couldn't think of any (nor did I discover a

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread George Sirois
> On March 29, 2016, 12:03 a.m., Joshua Cohen wrote: > > Are there any concerns about any other unintended side effect of setting > > $HOME to the sandbox? I suppose it's opt-in for now, so that allays most > > fears. I couldn't think of any (nor did I discover any in testing, both with and w

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread George Sirois
> On March 29, 2016, 12:03 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java, > > line 112 > > > > > > Given that this is a static method, it should b

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125779 --- Are there any concerns about any other unintended side effect of s

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125728 --- Master (0950095) is green with this patch. ./build-support/jenki

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125722 --- RELEASE-NOTES.md (line 14)

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125726 --- Ship it! Ship It! - Steve Niemitz On March 28, 2016, 6:21 p.

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread George Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125707 --- @ReviewBot retry - George Sirois On March 28, 2016, 6:21 p.m.,

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125706 --- Master (0950095) is red with this patch. ./build-support/jenkins