Re: Review Request 34337: Add Docker Parameters

2015-07-22 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 22, 2015, 10:42 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 34337: Add Docker Parameters

2015-07-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review92671 --- Ship it! Ship It! - Bill Farner On July 18, 2015, 11:50 p.m., Ma

Re: Review Request 34337: Add Docker Parameters

2015-07-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review92193 --- Ship it! Master (4eaacf7) is green with this patch. ./build-suppo

Re: Review Request 34337: Add Docker Parameters

2015-07-18 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 18, 2015, 11:50 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 34337: Add Docker Parameters

2015-07-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review92192 --- This patch does not apply cleanly on master (4eaacf7), do you need t

Re: Review Request 34337: Add Docker Parameters

2015-07-18 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 18, 2015, 11:36 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 34337: Add Docker Parameters

2015-07-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review92191 --- This patch does not apply cleanly on master (4eaacf7), do you need t

Re: Review Request 34337: Add Docker Parameters

2015-07-18 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 18, 2015, 11:30 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 34337: Add Docker Parameters

2015-07-09 Thread Bill Farner
> On July 8, 2015, 9:38 p.m., Bill Farner wrote: > > Only nits remaining, and one request for test coverage. > > > > One final disclaimer on the security issue this creates - IIUC, arbitrary > > user-specified volume mounts opens up your cluster to privilege escalation. > > See this discussion

Re: Review Request 34337: Add Docker Parameters

2015-07-08 Thread Mauricio Garavaglia
> On July 8, 2015, 9:38 p.m., Bill Farner wrote: > > Only nits remaining, and one request for test coverage. > > > > One final disclaimer on the security issue this creates - IIUC, arbitrary > > user-specified volume mounts opens up your cluster to privilege escalation. > > See this discussion

Re: Review Request 34337: Add Docker Parameters

2015-07-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review90994 --- Only nits remaining, and one request for test coverage. One final d

Re: Review Request 34337: Add Docker Parameters

2015-07-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review90855 --- Sorry for the delay in following up, i should have bandwidth to give

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review90416 --- Ship it! Master (82aa097) is green with this patch. ./build-suppo

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 5, 2015, 11:58 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 5, 2015, 11:55 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review90415 --- This patch does not apply cleanly on master (82aa097), do you need t

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 5, 2015, 11:32 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review90414 --- This patch does not apply cleanly on master (82aa097), do you need t

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 5, 2015, 10:39 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 34337: Add Docker Parameters

2015-06-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review89383 --- LGTM in general! Biggest blocker for me is ability to toggle this b

Re: Review Request 34337: Add Docker Parameters

2015-06-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review88676 --- Ship it! Master (d240926) is green with this patch. ./build-suppo

Re: Review Request 34337: Add Docker Parameters

2015-06-20 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated June 20, 2015, 11:42 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 34337: Add Docker Parameters

2015-05-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review84082 --- Master (07ab0bb) is red with this patch. ./build-support/jenkins/b

Review Request 34337: Add Docker Parameters

2015-05-17 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- Review request for Aurora. Repository: aurora Description --- Support Ar