Re: Review Request 41473: Accept a command line argument for an executor configuration via json

2015-12-17 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41473/#review110964
---



src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 (line 52)


Maybe change the name to "custom_executor_config" and the help to "Path to 
custom executor settings configuration file."



src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 (line 53)


Can you add the following constraint annotations:

@Exists
@CanRead



src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 (line 141)


Is there a reason that 
`o.a.aurora.scheduler.configuration.executor.ExecutorSettingsLoader#ExecutorConfig`
 exists in addition to 
`o.a.aurora.scheduler.configuration.executor.ExecutorConfig`? They seem to be 
identical classes, am I missing something?



src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 (lines 147 - 148)


nit: Should fit on one line (but probably will just go away if we de-dupe 
these ExecutorConfig classes).



src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 (line 150)


Add a message to provide context on the exception? E.g.

throw new IllegalArgumentException("Failed to read executor settings: " 
+ e, e);


- Joshua Cohen


On Dec. 17, 2015, 12:34 a.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41473/
> ---
> 
> (Updated Dec. 17, 2015, 12:34 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Patch to allow Aurora to accept an executor config via commandline which 
> overrides the default thermos one.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  d04763418f55aa1e9f1b537987d21920c05fd950 
> 
> Diff: https://reviews.apache.org/r/41473/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

2015-12-17 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41473/
---

(Updated Dec. 17, 2015, 8:57 p.m.)


Review request for Aurora.


Changes
---

Updated code with suggestions and taking into account Bill's patch to remove 
ExecutorConfig dup.


Repository: aurora


Description
---

Patch to allow Aurora to accept an executor config via commandline which 
overrides the default thermos one.


Diffs (updated)
-

  .gitattributes a5ab8cf17a14d2527e2a765ff94c3a74e719e0f4 
  NEWS 7a80f32465736de4fbdc7d2c7a3dbf790be31e16 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
d765dd798e6861e3920802db00e0b96a250d1bfa 
  api/src/main/thrift/org/apache/aurora/gen/storage.thrift 
624076d1acd8d087a857ebdfeec0831e1bd8e89c 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
ff886d9bc6ef44fa17bbad4fde208ab682483809 
  
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 d04763418f55aa1e9f1b537987d21920c05fd950 
  
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
 fafd90dbb4e628a213a5437aad8a50e7ec64ab79 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
838bfc9ed6242e777d81a17b337f342b7bea72ec 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
3ede9a0c3d1718cab07385c86b774efdfccc29f8 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
9aef59ac5e969b01004d8d9ede825caacca04674 
  src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 
d8686f1f1b53e5ff2791663489e24c342503831e 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
0e075607aabdc98a9c8c8c6bfa2929d3428645ff 
  src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 
258151feda2ea0adf0159c24c0e18a7b78b0c390 
  src/main/python/apache/aurora/client/api/__init__.py 
a6381585a2a9762202f14f929ab922806e84e8b6 
  src/main/python/apache/aurora/client/api/restarter.py 
1983034ff4e7510f7c2ca35ff9c851be24637c8e 
  src/main/python/apache/aurora/client/api/updater_util.py 
b54691eed59854ea5feb4120929cefbf1a95cd24 
  src/main/python/apache/aurora/client/cli/jobs.py 
ccc52c8357650b126185eb6100b3e2e0e37e1d45 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 
6410908b48f54f5188c29f247a9f7797ec802e34 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
35a4d627c5049eaec30380699e6005e8da2c10fd 
  
src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoaderTest.java
 90986a5b1ed88d3f71fb8414688878aea4a312cc 
  src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
5768481005ef505d6c397101d8cc005af9d6815f 
  src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 
97647ac3a4e99541484ac14f5796b5dffb01beb0 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
 02400f0bbf832fdac610868cff665f4312864b8b 
  
src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java
 3a80305e5169c8440b3a9d595fdaf8a52fdd15e3 
  src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 
0583a63a175880355a7296ebd1c6e6fb5dc99f38 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
f7f5275bed4eda5e276e408bf253f5da6a9cacd8 
  src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java 
PRE-CREATION 
  src/test/python/apache/aurora/client/api/test_api.py 
7debc7967cf926bc09f8a93cafa5059c0657e620 
  src/test/python/apache/aurora/client/api/test_restarter.py 
7557144ef1eed7ef24e69e82d04494c9f58dc217 
  src/test/python/apache/aurora/client/cli/test_restart.py 
2c51d541c4445f287d8794c0117fb038bb776329 
  src/test/python/apache/aurora/client/cli/util.py 
4b5ef4d1137cc9d545ea2205e4d14e438185a990 
  src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
97ce9732fd9561327c8c4c4f67fefd3866110bcc 
  src/test/python/apache/aurora/common/test_transport.py 
835bb3dfebccd0666f708d0023558aee80c1667d 

Diff: https://reviews.apache.org/r/41473/diff/


Testing (updated)
---

./build-support/jenkins/build.sh
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Tested with the following config files:
CommandExec.json
```json
{
  "executor": {
"name": "commandExec",
"command": {
  "value": "echo 'Hello World from Aurora!'"
},
"resources": [
  {
"name": "cpus",
"type": "SCALAR",
"scalar": {
  "value": 0.25
}
  },
  {
"name": "mem",
"type": "SCALAR",
"scalar": {
  "value": 128
}
  }
]
  }
}
```
Thermos.json:
```json
{
  "executor": {
"name": "thermos",
"command": {
  "value": "./thermos_executor.pex",
  "arguments": [
"--announcer-enable",
"--announcer-ensemble",

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

2015-12-17 Thread Bill Farner 


> On Dec. 17, 2015, 1:16 p.m., Bill Farner wrote:
> > LGTM once Joshua's final comments are addressed.

Oh, actually - can you add a line to the NEWS file about the new argument?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41473/#review111060
---


On Dec. 17, 2015, 1:10 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41473/
> ---
> 
> (Updated Dec. 17, 2015, 1:10 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Patch to allow Aurora to accept an executor config via commandline which 
> overrides the default thermos one.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  d04763418f55aa1e9f1b537987d21920c05fd950 
> 
> Diff: https://reviews.apache.org/r/41473/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Tested with the following config files:
> CommandExec.json
> ```json
> {
>   "executor": {
> "name": "commandExec",
> "command": {
>   "value": "echo 'Hello World from Aurora!'"
> },
> "resources": [
>   {
> "name": "cpus",
> "type": "SCALAR",
> "scalar": {
>   "value": 0.25
> }
>   },
>   {
> "name": "mem",
> "type": "SCALAR",
> "scalar": {
>   "value": 128
> }
>   }
> ]
>   }
> }
> ```
> Thermos.json:
> ```json
> {
>   "executor": {
> "name": "thermos",
> "command": {
>   "value": "./thermos_executor.pex",
>   "arguments": [
> "--announcer-enable",
> "--announcer-ensemble",
> "localhost:2181"
>   ],
>   "uris": [
> {
>   "value": "/home/vagrant/aurora/dist/thermos_executor.pex",
>   "executable": true,
>   "extract": false,
>   "cache": false
> }
>   ]
> },
> "resources": [
>   {
> "name": "cpus",
> "type": "SCALAR",
> "scalar": {
>   "value": 0.25
> }
>   },
>   {
> "name": "mem",
> "type": "SCALAR",
> "scalar": {
>   "value": 128
> }
>   }
> ]
>   }
> }
> ```
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

2015-12-17 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41473/#review111055
---

Ship it!


lgtm modulo a couple of style nits.


src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 (lines 54 - 55)


style nit: one arg per line when lines exceed 100 chars:

@CmdLine(
name = "...",
help = "...")



src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 (line 150)


Same here, one arg per line.


- Joshua Cohen


On Dec. 17, 2015, 9:10 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41473/
> ---
> 
> (Updated Dec. 17, 2015, 9:10 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Patch to allow Aurora to accept an executor config via commandline which 
> overrides the default thermos one.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  d04763418f55aa1e9f1b537987d21920c05fd950 
> 
> Diff: https://reviews.apache.org/r/41473/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Tested with the following config files:
> CommandExec.json
> ```json
> {
>   "executor": {
> "name": "commandExec",
> "command": {
>   "value": "echo 'Hello World from Aurora!'"
> },
> "resources": [
>   {
> "name": "cpus",
> "type": "SCALAR",
> "scalar": {
>   "value": 0.25
> }
>   },
>   {
> "name": "mem",
> "type": "SCALAR",
> "scalar": {
>   "value": 128
> }
>   }
> ]
>   }
> }
> ```
> Thermos.json:
> ```json
> {
>   "executor": {
> "name": "thermos",
> "command": {
>   "value": "./thermos_executor.pex",
>   "arguments": [
> "--announcer-enable",
> "--announcer-ensemble",
> "localhost:2181"
>   ],
>   "uris": [
> {
>   "value": "/home/vagrant/aurora/dist/thermos_executor.pex",
>   "executable": true,
>   "extract": false,
>   "cache": false
> }
>   ]
> },
> "resources": [
>   {
> "name": "cpus",
> "type": "SCALAR",
> "scalar": {
>   "value": 0.25
> }
>   },
>   {
> "name": "mem",
> "type": "SCALAR",
> "scalar": {
>   "value": 128
> }
>   }
> ]
>   }
> }
> ```
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

2015-12-17 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41473/
---

(Updated Dec. 17, 2015, 9:10 p.m.)


Review request for Aurora.


Changes
---

Apologies, need to fix my other repo, this is from a clean one.


Repository: aurora


Description
---

Patch to allow Aurora to accept an executor config via commandline which 
overrides the default thermos one.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 d04763418f55aa1e9f1b537987d21920c05fd950 

Diff: https://reviews.apache.org/r/41473/diff/


Testing
---

./build-support/jenkins/build.sh
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Tested with the following config files:
CommandExec.json
```json
{
  "executor": {
"name": "commandExec",
"command": {
  "value": "echo 'Hello World from Aurora!'"
},
"resources": [
  {
"name": "cpus",
"type": "SCALAR",
"scalar": {
  "value": 0.25
}
  },
  {
"name": "mem",
"type": "SCALAR",
"scalar": {
  "value": 128
}
  }
]
  }
}
```
Thermos.json:
```json
{
  "executor": {
"name": "thermos",
"command": {
  "value": "./thermos_executor.pex",
  "arguments": [
"--announcer-enable",
"--announcer-ensemble",
"localhost:2181"
  ],
  "uris": [
{
  "value": "/home/vagrant/aurora/dist/thermos_executor.pex",
  "executable": true,
  "extract": false,
  "cache": false
}
  ]
},
"resources": [
  {
"name": "cpus",
"type": "SCALAR",
"scalar": {
  "value": 0.25
}
  },
  {
"name": "mem",
"type": "SCALAR",
"scalar": {
  "value": 128
}
  }
]
  }
}
```


Thanks,

Renan DelValle

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

2015-12-17 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41473/#review111060
---

Ship it!


LGTM once Joshua's final comments are addressed.

- Bill Farner


On Dec. 17, 2015, 1:10 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41473/
> ---
> 
> (Updated Dec. 17, 2015, 1:10 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Patch to allow Aurora to accept an executor config via commandline which 
> overrides the default thermos one.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  d04763418f55aa1e9f1b537987d21920c05fd950 
> 
> Diff: https://reviews.apache.org/r/41473/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Tested with the following config files:
> CommandExec.json
> ```json
> {
>   "executor": {
> "name": "commandExec",
> "command": {
>   "value": "echo 'Hello World from Aurora!'"
> },
> "resources": [
>   {
> "name": "cpus",
> "type": "SCALAR",
> "scalar": {
>   "value": 0.25
> }
>   },
>   {
> "name": "mem",
> "type": "SCALAR",
> "scalar": {
>   "value": 128
> }
>   }
> ]
>   }
> }
> ```
> Thermos.json:
> ```json
> {
>   "executor": {
> "name": "thermos",
> "command": {
>   "value": "./thermos_executor.pex",
>   "arguments": [
> "--announcer-enable",
> "--announcer-ensemble",
> "localhost:2181"
>   ],
>   "uris": [
> {
>   "value": "/home/vagrant/aurora/dist/thermos_executor.pex",
>   "executable": true,
>   "extract": false,
>   "cache": false
> }
>   ]
> },
> "resources": [
>   {
> "name": "cpus",
> "type": "SCALAR",
> "scalar": {
>   "value": 0.25
> }
>   },
>   {
> "name": "mem",
> "type": "SCALAR",
> "scalar": {
>   "value": 128
> }
>   }
> ]
>   }
> }
> ```
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Review Request 41473: Accept a command line argument for an executor configuration via json

2015-12-16 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41473/
---

Review request for Aurora.


Repository: aurora


Description
---

Patch to allow Aurora to accept an executor config via commandline which 
overrides the default thermos one.


Diffs
-

  .auroraversion d2cbead89e9c31b9fb31db9a645afb99ff585b10 
  .auroraversion PRE-CREATION 
  .gitignore 6c37128b5d02b0e52eb467be3652a37b10d7bc06 
  .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd 
  3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 
  3rdparty/python/requirements.txt 1eeb36dee1a0ebd33999bbb3327338a51cba00d7 
  BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 
  BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 
  CHANGELOG a1634718e5e83581d62dcce44c0aa5778a1bfa0a 
  CONTRIBUTING.md 9a27950f4a9ff974e9342c8022487dd9b1eccc96 
  KEYS dff0fb48f1b0e8a18bc21014cc425d7d48f08c6d 
  NEWS 2edcea61fafea09b08faf03af4335ca82629d46d 
  api/src/main/thrift/org/apache/aurora/gen/BUILD 
2dcc46d9658044d96f4f1b3634f29ae1d446e0d7 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
a04e644453bfecde44ec7b51b53f42dc82e90c96 
  api/src/main/thrift/org/apache/thermos/BUILD 
6b13949aceb830b962a7098ae65462151119d752 
  build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
  build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 
  build-support/pants_requirements.txt fad8da5ce4c03f25554394bc628d4fbb0fe6cd69 
  build-support/pex 54e31f11f152cada3809ebd7b2cdec1d2ba12ac9 
  build-support/python/checkstyle 61acc22613acece01580761b25afc7a3edb6b845 
  build-support/python/checkstyle-check 
b2bfc5dd71193a8056828e9af05a4c16965f32a1 
  build-support/python/make-mesos-native-egg 
47438c5b71d686c4a42ae3f46f3a7093b34f3909 
  build-support/python/make-pycharm-virtualenv 
d7bd41835bcd9a8fe62ea522a177bfa7830a897b 
  build-support/python/update-pants-requirements 
82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec 
  build-support/release/release 209045767a18d263814700dfb5f9912447cc1205 
  build-support/release/release-candidate 
1caa56bfaee67dec6c70b50923b18900f88ced75 
  build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
  build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
  build.gradle 0401a9cbf0caf5578ef3c30e67c5b6a0a7a74a03 
  buildSrc/gradle.properties bbfdeb20161f497775e36c4b144436253c37c9f0 
  buildSrc/src/main/groovy/org/apache/aurora/build/CoverageReportCheck.groovy 
b47175666159128a98f731e157d5a1eb936a94bb 
  
commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java
 5abb06b1d41f3265d9d46c600ba193ce19d21188 
  
commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java 
d06ec69cb57d9c411ae33b301489f6460197dcc7 
  commons/src/main/java/org/apache/aurora/common/args/ArgFilters.java 
9a4d441023fd9eea868fd069c197eb002d98f0ab 
  commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 
cc4710cb5f559a108b140489a981a9d2c195b75b 
  commons/src/main/java/org/apache/aurora/common/args/Args.java 
ad0b299057e787a9587822e7778bd360f77e1678 
  commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java 
051e3f93ef17de90b7bffaa74fc6b54965927424 
  commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 
c1fe1c73c46da21c471b2669dbb8207b7c468054 
  commons/src/main/java/org/apache/aurora/common/args/Parsers.java 
62564a62d255e640e5790ed2e103ba8425a4c15b 
  commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 
3da1812abfdb30f12737b19f5e87bc14a02d4c3f 
  
commons/src/main/java/org/apache/aurora/common/args/constraints/RangeNumberVerifier.java
 27250944a60f906a4c220771e9948ed0297ee76c 
  commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java 
02c10ed067c8395a2688cd69d4d73d5fd17774ff 
  commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java 
1e12b06e284cd2e33b63b3690abd3dcd78f9e777 
  commons/src/main/java/org/apache/aurora/common/base/Closures.java 
d6cb82a30a8c6292bab0fa007dce2f54f6b66435 
  commons/src/main/java/org/apache/aurora/common/base/Commands.java 
8a88ae336f57fcdafb984cc3418dcd960da0028d 
  commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java 
072159e79b2d8872f39dfbba9f6a1d27295f1a7a 
  commons/src/main/java/org/apache/aurora/common/collections/Pair.java 
b1f9b6336aa8b8d0ff9e611dc2ad1dc8068ef7f3 
  
commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java 
7e88b27f2d4c210a1f6b04f256452ffbd3639be8 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java 
348a8c923118da3b4399afb1a6f09d904c3b 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/TimeSeriesDataSource.java
 8039def73377b0e56c3106876dc89e9183cd55a1 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/VarsHandler.java

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

2015-12-16 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41473/#review110816
---


Master (3e1f823) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 17, 2015, 12:34 a.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41473/
> ---
> 
> (Updated Dec. 17, 2015, 12:34 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Patch to allow Aurora to accept an executor config via commandline which 
> overrides the default thermos one.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  d04763418f55aa1e9f1b537987d21920c05fd950 
> 
> Diff: https://reviews.apache.org/r/41473/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>