On Feb. 27, 2014, 2:54 a.m., Maxim Khutornenko wrote:
This change needs to be split into at least 3 checkins to ensure proper
upgrade story:
- thrift changes along with scheduler changes: dual write in storage.thrift
and StorageBackfill to ensure smooth deploy rollback
- client
On Feb. 27, 2014, 1:38 a.m., Kevin Sweeney wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 364
https://reviews.apache.org/r/18526/diff/1/?file=504721#file504721line364
Mind adding a ticket number (filing one if it doesn't exist)?
Added ticket tracking removal.
-
On Feb. 26, 2014, 6:54 p.m., Maxim Khutornenko wrote:
This change needs to be split into at least 3 checkins to ensure proper
upgrade story:
- thrift changes along with scheduler changes: dual write in storage.thrift
and StorageBackfill to ensure smooth deploy rollback
- client
On Jan. 28, 2014, 3:36 a.m., Bill Farner wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 219
https://reviews.apache.org/r/17347/diff/1/?file=450737#file450737line219
This confirms my fear of the slippery slope of Quota becoming an
overloaded term. I'd love to call
On Feb. 27, 2014, 2:54 a.m., Maxim Khutornenko wrote:
This change needs to be split into at least 3 checkins to ensure proper
upgrade story:
- thrift changes along with scheduler changes: dual write in storage.thrift
and StorageBackfill to ensure smooth deploy rollback
- client
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18580/#review35685
---
Ship it!
Ship It!
- Jake Farrell
On Feb. 27, 2014, 6:53 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/#review35718
---
Mostly minor nits aside from sneaky commenting out of asserts in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/#review35719
---
Ship it!
Ship It!
- Bill Farner
On Feb. 26, 2014, 10:06 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/#review35721
---
build.gradle
https://reviews.apache.org/r/18537/#comment66434
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16062/
---
(Updated Feb. 27, 2014, 11:17 p.m.)
Review request for Aurora and Bill Farner.
On Feb. 27, 2014, 11:19 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java,
line 76
https://reviews.apache.org/r/18526/diff/2/?file=506086#file506086line76
I know why you're doing this here, but mind keeping it out for now?
Ignore
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18526/#review35723
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18526/#review35729
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18598/#review35731
---
Ship it!
Ship It!
- Kevin Sweeney
On Feb. 27, 2014, 4:44 p.m.,
On Feb. 27, 2014, 11:04 p.m., Kevin Sweeney wrote:
build.gradle, lines 251-260
https://reviews.apache.org/r/18537/diff/1/?file=504979#file504979line251
Rather than give up if /usr/bin/python isn't =2.6,3, shouldn't it
instead check for python2.7 and python2.6 on PATH (similar to
On Feb. 27, 2014, 3:04 p.m., Kevin Sweeney wrote:
build.gradle, lines 251-260
https://reviews.apache.org/r/18537/diff/1/?file=504979#file504979line251
Rather than give up if /usr/bin/python isn't =2.6,3, shouldn't it
instead check for python2.7 and python2.6 on PATH (similar to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18580/#review35737
---
Ship it!
Ship It!
- Bill Farner
On Feb. 27, 2014, 6:53 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/
---
Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian
On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
Mostly minor nits aside from sneaky commenting out of asserts in tests.
Thanks for the comments. Was trying to get the review out. Fixed the flaky test
and merged the fix into this branch.
On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18526/#review35738
---
src/main/java/org/apache/aurora/scheduler/base/Query.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18526/
---
(Updated Feb. 28, 2014, 1:18 a.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/
---
(Updated Feb. 28, 2014, 1:32 a.m.)
Review request for Aurora, Kevin Sweeney,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/
---
(Updated Feb. 27, 2014, 5:45 p.m.)
Review request for Aurora, Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35748
---
src/main/python/apache/aurora/common/http_signaler.py
On Feb. 27, 2014, 6:09 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/common/http_signaler.py, line 52
https://reviews.apache.org/r/18602/diff/3/?file=506638#file506638line52
Isn't it still the same problem here? Attempt to use %f for a string?
I'll go ahead and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18580/#review35754
---
Since there's a substantial change from the initial subject I'll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/
---
(Updated Feb. 27, 2014, 6:37 p.m.)
Review request for Aurora, Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/#review35751
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35755
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 28, 2014, 2:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/#review35756
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18580/#review35758
---
Ship it!
examples/vagrant/provision-aurora-scheduler.sh
31 matches
Mail list logo
