On Feb. 24, 2015, 8:54 p.m., Zameer Manji wrote:
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml,
line 149
https://reviews.apache.org/r/31376/diff/1/?file=874379#file874379line149
Have you filed an upstream bug about this behaviour?
I
On Feb. 24, 2015, 8:54 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/updater/Updates.java, line 57
https://reviews.apache.org/r/31376/diff/1/?file=874378#file874378line57
I don't think we should pass around any mutable state. I think data
objects like
On Feb. 23, 2015, 10:52 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/OfferManager.java, line 255
https://reviews.apache.org/r/30891/diff/7/?file=873086#file873086line255
s/may/will/?
Changed.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31376/
---
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs:
On Feb. 24, 2015, 7:35 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/async/OfferManager.java, line 301
https://reviews.apache.org/r/30891/diff/7/?file=873086#file873086line301
No need to hold the intrinsic lock while logging here
Having an explicit lock will
On Feb. 24, 2015, 7:30 p.m., Kevin Sweeney wrote:
Is this ready for review now?
It is. However, since AURORA-1041 is still in Open I am going to discard it and
repost when the ticket moves into Accepted.
- Maxim
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31376/#review73899
---
Ship it!
On Feb. 24, 2015, 8:28 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/Updates.java, line 57
https://reviews.apache.org/r/31376/diff/1/?file=874378#file874378line57
Would it make sense to accept/return `JobUpdateSummary`? The
mutable/immutable
On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote:
Steve Niemitz wrote:
I'm not a big fan of how the parsing works here either. I was thinking
about this last night, I think I have a better plan here. Lemme know what
you think.
I already want to add volume support
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31376/#review73906
---
src/main/java/org/apache/aurora/scheduler/updater/Updates.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30891/#review72448
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30895/#review73887
---
Ship it!
Ship It!
- Kevin Sweeney
On Feb. 23, 2015, 2:47 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31376/#review73900
---
Ship it!
Master (19378c1) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/
---
(Updated Feb. 24, 2015, 10:52 p.m.)
Review request for Aurora.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/
---
Review request for Aurora.
Repository: aurora
Description
---
Fix
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/#review73792
---
Master (19378c1) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/#review73815
---
Ship it!
Master (19378c1) is green with this patch.
On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote:
Steve Niemitz wrote:
I'm not a big fan of how the parsing works here either. I was thinking
about this last night, I think I have a better plan here. Lemme know what
you think.
I already want to add volume support
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review73822
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/#review73806
---
@ReviewBot retry
- Stephan Erb
On Feb. 24, 2015, 11:57 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/
---
(Updated Feb. 24, 2015, 3:18 p.m.)
Review request for Aurora.
Changes
On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote:
Steve Niemitz wrote:
I'm not a big fan of how the parsing works here either. I was thinking
about this last night, I think I have a better plan here. Lemme know what
you think.
I already want to add volume support
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/#review73832
---
src/test/python/apache/aurora/common/test_clusters.py
On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote:
Steve Niemitz wrote:
I'm not a big fan of how the parsing works here either. I was thinking
about this last night, I think I have a better plan here. Lemme know what
you think.
I already want to add volume support
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31235/#review73712
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29943/#review73877
---
Is this ready for review now?
- Kevin Sweeney
On Jan. 20, 2015,
On Feb. 24, 2015, 11:12 a.m., Kevin Sweeney wrote:
This is awesome! If this fixes the full suite, can you also remove
`--no-fast` from `build-support/jenkins/build.sh`?
Stephan Erb wrote:
I doubt that this patch is sufficient to warrant the change of the build
script. There may
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/#review73992
---
Ship it!
I can only wonder how many times this has caused an error
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31394/#review73955
---
Ship it!
Master (cd681d9) is green with this patch.
On Feb. 17, 2015, 11:09 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java,
line 114
https://reviews.apache.org/r/30710/diff/3/?file=861559#file861559line114
This is breaking Resources/Offer encapsulation and is not addressing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31394/#review73958
---
Ship it!
Ship It!
- Bill Farner
On Feb. 25, 2015, 1:06 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/#review73928
---
Ship it!
Master (cd681d9) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31389/#review73954
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 25, 2015, 12:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/
---
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/#review73939
---
Ship it!
src/test/python/apache/aurora/common/test_clusters.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31380/#review73938
---
Ship it!
Ship It!
- Joe Smith
On Feb. 24, 2015, 1:27 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/
---
(Updated Feb. 25, 2015, midnight)
Review request for Aurora, Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31389/
---
Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
Bugs:
On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote:
Steve Niemitz wrote:
I'm not a big fan of how the parsing works here either. I was thinking
about this last night, I think I have a better plan here. Lemme know what
you think.
I already want to add volume support
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31394/#review73953
---
Ship it!
Ship It!
- Kevin Sweeney
On Feb. 24, 2015, 5:06 p.m.,
On Feb. 24, 2015, 8:12 p.m., Kevin Sweeney wrote:
This is awesome! If this fixes the full suite, can you also remove
`--no-fast` from `build-support/jenkins/build.sh`?
I doubt that this patch is sufficient to warrant the change of the build
script. There may be many more error conditions
On Feb. 17, 2015, 11:09 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java,
line 114
https://reviews.apache.org/r/30710/diff/3/?file=861559#file861559line114
This is breaking Resources/Offer encapsulation and is not addressing
On Feb. 17, 2015, 11:09 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java,
line 174
https://reviews.apache.org/r/30710/diff/3/?file=861559#file861559line174
Prefer using guava `Ordering` [1] instead. It will avoid excessive
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review73936
---
This patch does not apply cleanly on master (cd681d9), do you need
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/
---
(Updated Feb. 25, 2015, 12:07 a.m.)
Review request for Aurora, Maxim
45 matches
Mail list logo
