Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-23 Thread Aurora ReviewBot
to rebase? - Aurora ReviewBot On Oct. 23, 2014, 6:27 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100

Re: Review Request 27114: Move from github to bintray for pants support binaries.

2014-10-23 Thread Aurora ReviewBot
/jenkins/build.sh - Aurora ReviewBot On Oct. 23, 2014, 10:19 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27114

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-23 Thread Aurora ReviewBot
to rebase? - Aurora ReviewBot On Oct. 23, 2014, 9:47 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058

Re: Review Request 27044: Make executor overhead configurable

2014-10-23 Thread Aurora ReviewBot
(ExecuteActionsTaskExecuter.java:61) ... 47 more BUILD FAILED Total time: 51.003 secs - Aurora ReviewBot On Oct. 24, 2014, 12:24 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 23329: remove embedded jquery

2014-10-23 Thread Aurora ReviewBot
to rebase? - Aurora ReviewBot On July 9, 2014, 9:50 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329

Re: Review Request 27089: Add documentation for the beta-update command.

2014-10-23 Thread Aurora ReviewBot
/jenkins/build.sh - Aurora ReviewBot On Oct. 23, 2014, 5:31 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27089

Re: Review Request 27084: Fix error when job create is called with --open-browser.

2014-10-23 Thread Aurora ReviewBot
to rebase? - Aurora ReviewBot On Oct. 23, 2014, 4:50 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27084

Re: Review Request 25794: Add a mock scheduler client to the AuroraClient service

2014-10-23 Thread Aurora ReviewBot
to rebase? - Aurora ReviewBot On Sept. 18, 2014, 9:38 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25794

Re: Review Request 26753: Start removing clientv1.

2014-10-23 Thread Aurora ReviewBot
to rebase? - Aurora ReviewBot On Oct. 21, 2014, 6:34 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26753

Re: Review Request 26899: Require StateManager callers to open their own transactions.

2014-10-23 Thread Aurora ReviewBot
to rebase? - Aurora ReviewBot On Oct. 21, 2014, 1:09 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26899

Re: Review Request 22457: Improve aurora job diff command.

2014-10-23 Thread Aurora ReviewBot
to rebase? - Aurora ReviewBot On Sept. 9, 2014, 2:07 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457

Re: Review Request 26802: Set a default for the error log dir

2014-10-23 Thread Aurora ReviewBot
to rebase? - Aurora ReviewBot On Oct. 16, 2014, 8:22 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26802

Re: Review Request 22457: Improve aurora job diff command.

2014-10-24 Thread Aurora ReviewBot
. FAILURE src.test.python.apache.aurora.client.config . SUCCESS - Aurora ReviewBot On Oct. 24, 2014, 2:50 p.m., Mark Chu-Carroll wrote

Re: Review Request 27129: Upgrade psutil to 2.1.3

2014-10-24 Thread Aurora ReviewBot
/jenkins/build.sh - Aurora ReviewBot On Oct. 24, 2014, 2:13 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27129

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Aurora ReviewBot
/jenkins/build.sh - Aurora ReviewBot On Oct. 24, 2014, 1:50 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100

Re: Review Request 27145: Add a script that publishes build results to review board.

2014-10-24 Thread Aurora ReviewBot
/jenkins/build.sh - Aurora ReviewBot On Oct. 24, 2014, 9:42 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Aurora ReviewBot
/jenkins/build.sh - Aurora ReviewBot On Oct. 24, 2014, 7:59 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-24 Thread Aurora ReviewBot
src.test.python.apache.aurora.client.commands.core . FAILURE src.test.python.apache.aurora.client.config . SUCCESS - Aurora ReviewBot On Oct. 24, 2014, 8:09 p.m., David McLaughlin wrote

Re: Review Request 27145: Add a script that publishes build results to review board.

2014-10-24 Thread Aurora ReviewBot
/jenkins/build.sh - Aurora ReviewBot On Oct. 24, 2014, 10:42 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Aurora ReviewBot
/jenkins/build.sh - Aurora ReviewBot On Oct. 24, 2014, 11:08 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100

Re: Review Request 27181: Allow the invoker to ignore patterns in git-clean.

2014-10-24 Thread Aurora ReviewBot
need to rebase? - Aurora ReviewBot On Oct. 24, 2014, 11:19 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27181

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-24 Thread Aurora ReviewBot
', 'reason', 'unsafe_hosts_filename', 'verbosity']) - Aurora ReviewBot On Oct. 24, 2014, 10:48 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058

Re: Review Request 27188: Use ship-it instead of +/-1.

2014-10-24 Thread Aurora ReviewBot
/jenkins/build.sh - Aurora ReviewBot On Oct. 25, 2014, 3:17 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27188

Re: Review Request 27253: Raise .auroraversion to 0.6.0-SNAPSHOT

2014-10-27 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 27, 2014, 11:25 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27253

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-27 Thread Aurora ReviewBot
src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . FAILURE - Aurora ReviewBot On Oct. 28, 2014, 1:43 a.m., Maxim Khutornenko wrote

Re: Review Request 27266: Fixing transient error message formatting in scheduler_client.py

2014-10-27 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 28, 2014, 3:23 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27266

Re: Review Request 27289: Fixing error reporting in v1 client updater.

2014-10-28 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Oct. 28, 2014, 5:13 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Oct. 28, 2014, 5:22 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 28, 2014, 6:01 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-28 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 28, 2014, 8:26 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262

Re: Review Request 27289: Fixing error reporting in v1 client updater.

2014-10-28 Thread Aurora ReviewBot
src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . FAILURE - Aurora ReviewBot On Oct. 28, 2014, 8:52 p.m., Maxim Khutornenko wrote

Re: Review Request 27309: Make executor overhead configurable via CLI.

2014-10-28 Thread Aurora ReviewBot
src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . FAILURE - Aurora ReviewBot On Oct. 28, 2014, 8:57 p.m., Zameer Manji wrote

Re: Review Request 27316: Fix minor discrepancies in RC script.

2014-10-28 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 28, 2014, 10:55 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27316

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-10-28 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Oct. 29, 2014, 12:20 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 27309: Make executor overhead configurable via CLI.

2014-10-29 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 29, 2014, 7:54 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27309

Re: Review Request 27352: Cleaning up old vagrant cluster names.

2014-10-29 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 29, 2014, 10:21 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27352

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 29, 2014, 11:19 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 29, 2014, 11:38 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

2014-10-29 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 30, 2014, 12:39 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27364

Re: Review Request 27365: Add FakeStatsProvider and check stat values in SchedulerLifecycleTest.

2014-10-29 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 30, 2014, 12:44 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27365

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

2014-10-29 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 30, 2014, 5:09 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27371

Re: Review Request 27375: Remove dependency on application-http.

2014-10-30 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 30, 2014, 6:02 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27375

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-30 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 30, 2014, 4:39 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

2014-10-30 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Oct. 30, 2014, 5:16 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

2014-10-30 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Oct. 30, 2014, 5:23 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

2014-10-30 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 30, 2014, 5:49 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27364

Re: Review Request 27375: Remove dependency on application-http.

2014-10-31 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Oct. 31, 2014, 9:03 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27375

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-02 Thread Aurora ReviewBot
to rebase? - Aurora ReviewBot On Nov. 2, 2014, 10:18 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-03 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 3, 2014, 2:49 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492

Re: Review Request 27538: Optionally ignore unknown transaction operations.

2014-11-03 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 3, 2014, 8:34 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

2014-11-03 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 3, 2014, 9:25 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 27541: Revert Adding resource consumption calculation for cron jobs.

2014-11-03 Thread Aurora ReviewBot
to rebase? - Aurora ReviewBot On Nov. 3, 2014, 9:59 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27541

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

2014-11-03 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 3, 2014, 10:46 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467

Re: Review Request 27545: Replace twitter.commons.io.FileUtils dependency w/ guava's Files

2014-11-03 Thread Aurora ReviewBot
src.test.python.apache.thermos.core.test_staged_kill . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . FAILURE - Aurora ReviewBot On Nov. 3, 2014, 11:09 p.m., Joshua Cohen wrote

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-03 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 4, 2014, 12:42 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-04 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 4, 2014, 3:35 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Aurora ReviewBot
src.test.python.apache.aurora.client.commands.core . FAILURE src.test.python.apache.aurora.client.config . SUCCESS - Aurora ReviewBot On Nov. 4, 2014, 7:55 p.m., Zameer Manji wrote

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 4, 2014, 9:22 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586

Re: Review Request 27591: Remove --bind-var for cron deschedule.

2014-11-04 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 4, 2014, 9:39 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

2014-11-04 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 4, 2014, 11:10 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598

Re: Review Request 27601: Adding resource consumption calculation for cron jobs.

2014-11-04 Thread Aurora ReviewBot
src.test.python.apache.thermos.core.test_staged_kill . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . FAILURE - Aurora ReviewBot On Nov. 5, 2014, 1:23 a.m., Maxim Khutornenko wrote

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

2014-11-04 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 5, 2014, 1:52 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 27591: Remove --bind-var for cron deschedule.

2014-11-04 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 5, 2014, 2:52 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 5, 2014, 3:34 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 27630: Mark inotify disk collector test as flaky.

2014-11-05 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 5, 2014, 6:04 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 27542: Add test coverage for WriteAheadStorage.

2014-11-05 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 5, 2014, 6:04 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

2014-11-05 Thread Aurora ReviewBot
in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 5, 2014, 5:58 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 27630: Mark inotify disk collector test as flaky.

2014-11-05 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 5, 2014, 6:16 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27630

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

2014-11-05 Thread Aurora ReviewBot
src.test.python.apache.thermos.monitoring.test_disk . FAILURE - Aurora ReviewBot On Nov. 5, 2014, 7:42 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

2014-11-05 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 5, 2014, 11:53 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628

Re: Review Request 27650: Remove duplicate call to log handling code.

2014-11-05 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 6, 2014, 12:02 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27650

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

2014-11-05 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 6, 2014, 12:47 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27628

Re: Review Request 27657: Print out the job url after scheduling a cron job.

2014-11-05 Thread Aurora ReviewBot
src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.cron . FAILURE src.test.python.apache.aurora.client.config . SUCCESS - Aurora ReviewBot On Nov. 6, 2014, 1:33 a.m

Re: Review Request 27657: Print out the job url after scheduling a cron job.

2014-11-06 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 6, 2014, 6:47 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657

Re: Review Request 27698: Move zookeeper connection off the main thread to prevent client deadlocks.

2014-11-06 Thread Aurora ReviewBot
. SUCCESS src.test.python.apache.aurora.client.config . SUCCESS - Aurora ReviewBot On Nov. 6, 2014, 8:45 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 27542: Add test coverage for WriteAheadStorage.

2014-11-06 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 6, 2014, 9:07 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27542

Re: Review Request 27698: Move zookeeper connection off the main thread to prevent client deadlocks.

2014-11-06 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 6, 2014, 9:33 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27698

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

2014-11-06 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 6, 2014, 10:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705

Re: Review Request 27710: Remove stracktrace redirection.

2014-11-06 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 6, 2014, 11:40 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27710

Re: Review Request 27712: Fixing beta-update OK status messaging.

2014-11-06 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 7, 2014, 12:30 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27712

Re: Review Request 27716: Remove SchedulerActive, replace with explicit lifecycle.

2014-11-06 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 7, 2014, 2:41 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27716

Re: Review Request 27716: Remove SchedulerActive, replace with explicit lifecycle.

2014-11-06 Thread Aurora ReviewBot
with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1 mins 27.269 secs - Aurora ReviewBot On Nov. 7, 2014, 3:40 a.m., Kevin Sweeney wrote

Re: Review Request 27716: Remove SchedulerActive, replace with explicit lifecycle.

2014-11-06 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 7, 2014, 3:46 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27716

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 7, 2014, 10:03 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Aurora ReviewBot
. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 7, 2014, 11:05 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Aurora ReviewBot
to rebase? - Aurora ReviewBot On Nov. 7, 2014, 11:42 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747

Re: Review Request 27757: Replace bindStartupAction with Service registration

2014-11-07 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 8, 2014, 12:06 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 8, 2014, 12:28 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747

Re: Review Request 27762: Use async eventbus

2014-11-07 Thread Aurora ReviewBot
. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 8, 2014, 12:50 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 27762: Use async eventbus

2014-11-07 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 8, 2014, 12:57 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762

Re: Review Request 27710: Remove stracktrace redirection.

2014-11-07 Thread Aurora ReviewBot
. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Nov. 6, 2014, 11:40 p.m., Zameer Manji wrote

Re: Review Request 27770: Make it easier to request another ReviewBot run, and flag diffs that seem to lack test coverage.

2014-11-07 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 8, 2014, 4:24 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27770

Re: Review Request 27772: Fix false passing test case in SchedulerDriverServiceTest.

2014-11-07 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 8, 2014, 5:53 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27772

Re: Review Request 27778: Fix false positive client test.

2014-11-08 Thread Aurora ReviewBot
src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS - Aurora ReviewBot On Nov. 8, 2014, 7:06 p.m., Bill Farner wrote

Re: Review Request 27779: Create the PyCharm project configuration for easier IDE setup.

2014-11-08 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 8, 2014, 7:27 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27779

Re: Review Request 27828: Move read-modify-write logic out of AttributeStore.Mutable for simpler layering.

2014-11-10 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 10, 2014, 8:50 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27828

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-10 Thread Aurora ReviewBot
/test_update.py:080 Expected 2 blank lines, found 3 |class TestUpdateCommand(AuroraClientCommandTest): - Aurora ReviewBot On Nov. 11, 2014, 12:29 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-10 Thread Aurora ReviewBot
-support/jenkins/build.sh - Aurora ReviewBot On Nov. 11, 2014, 12:58 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848

Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.

2014-11-11 Thread Aurora ReviewBot
-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Nov. 11, 2014, 10:42 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 27892: Fixes for the make pycharm script:

2014-11-11 Thread Aurora ReviewBot
. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Nov. 11, 2014, 11:11 p.m., Joshua Cohen wrote

  1   2   3   4   5   6   7   >