Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review72195 --- Ship it! Master (994d669) is green with this patch. ./build-suppo

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/ --- (Updated Feb. 12, 2015, 5:40 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review72098 --- Master (61e6c35) is red with this patch. ./build-support/jenkins/b

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review72091 --- @ReviewBot retry - Maxim Khutornenko On Feb. 11, 2015, 1:19 a.m.,

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

> On Feb. 11, 2015, 11:59 p.m., David McLaughlin wrote: > > FWIW I do agree with Bill's comment that minimum pulse time should be > > enforced in scheduler rather than here. I am +1 on the scheduler check as complementary to the client when/if there is a need for it. I am -1 on using scheduler

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review72068 --- Ship it! FWIW I do agree with Bill's comment that minimum pulse tim

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review72065 --- Ship it! pending clean test run from review bot. - Joshua Cohen

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

> On Feb. 11, 2015, 2:23 a.m., Aurora ReviewBot wrote: > > Master (64fa0ca) is red with this patch. > > ./build-support/jenkins/build.sh > > > >  self.expect_finish() > >  self.replay_mocks() > > 

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review71907 --- Master (64fa0ca) is red with this patch. ./build-support/jenkins/b

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review71900 --- Ship it! Ship It! - Bill Farner On Feb. 11, 2015, 1:19 a.m., Max

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/ --- (Updated Feb. 11, 2015, 1:19 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

> On Feb. 3, 2015, 3:35 a.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/api/updater.py, line 99 > > > > > > s/in/by the Fixed. > On Feb. 3, 2015, 3:35 a.m., Joshua Cohen wrote: > > src/test/python/

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

> On Feb. 3, 2015, 12:28 a.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/api/updater_util.py, line 108 > > > > > > Can you investigate whether the python code respects the `isSetX` > > pattern? My h

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

> On Feb. 3, 2015, 12:28 a.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/api/updater_util.py, line 25 > > > > > > I suggest increasing this, say to 120. We already have a pretty good > > safety net b

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

> On Feb. 3, 2015, 12:28 a.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/api/updater_util.py, line 25 > > > > > > I suggest increasing this, say to 120. We already have a pretty good > > safety net b

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review70701 --- src/main/python/apache/aurora/client/api/updater.py

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

> On Feb. 3, 2015, 12:28 a.m., Bill Farner wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 35 > > > > > > I think we should consider avoiding exposing this to end users. This > > setting is really

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review70662 --- src/main/python/apache/aurora/client/api/updater_util.py

Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/ --- Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Bug

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review70427 --- Master (c739122) is red with this patch. ./build-support/jenkins/b

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/ --- (Updated Jan. 30, 2015, 10:31 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review70434 --- Ship it! Master (c739122) is green with this patch. ./build-suppo