Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-03-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350/#review75203 --- Stephan: I'm ready to commit this but it looks like you don't have

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-03-04 Thread Stephan Erb
On March 4, 2015, 7:30 p.m., Kevin Sweeney wrote: Stephan: I'm ready to commit this but it looks like you don't have an email address in reviewboard. Can you set one so that we can attribute this patch and ping this review? ``` File

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350/ --- (Updated Feb. 24, 2015, 10:52 p.m.) Review request for Aurora. Changes

Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350/ --- Review request for Aurora. Repository: aurora Description --- Fix

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350/#review73792 --- Master (19378c1) is red with this patch.

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350/#review73815 --- Ship it! Master (19378c1) is green with this patch.

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350/#review73806 --- @ReviewBot retry - Stephan Erb On Feb. 24, 2015, 11:57 a.m.,

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350/ --- (Updated Feb. 24, 2015, 3:18 p.m.) Review request for Aurora. Changes

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350/#review73832 --- src/test/python/apache/aurora/common/test_clusters.py

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Kevin Sweeney
On Feb. 24, 2015, 11:12 a.m., Kevin Sweeney wrote: This is awesome! If this fixes the full suite, can you also remove `--no-fast` from `build-support/jenkins/build.sh`? Stephan Erb wrote: I doubt that this patch is sufficient to warrant the change of the build script. There may

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350/#review73992 --- Ship it! I can only wonder how many times this has caused an error

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350/#review73928 --- Ship it! Master (cd681d9) is green with this patch.

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350/#review73939 --- Ship it! src/test/python/apache/aurora/common/test_clusters.py

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Stephan Erb
On Feb. 24, 2015, 8:12 p.m., Kevin Sweeney wrote: This is awesome! If this fixes the full suite, can you also remove `--no-fast` from `build-support/jenkins/build.sh`? I doubt that this patch is sufficient to warrant the change of the build script. There may be many more error conditions