[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-23 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 15: (3 comments)

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10447 ) Change subject: IMPALA-7061: Rework HBase splitting and assignment .. Patch Set 6: (5 comments) Thanks for tackling this. This

[Impala-ASF-CR] Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-23 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10489 to look at the new patch set (#4). Change subject: Trimming build-all-flag-combinations and adding minicluster profile.

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10491 Change subject: IMPALA-7055: fix race with DML errors .. IMPALA-7055: fix race with DML errors Error statuses could be lost because

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 ) Change subject: IMPALA-7055: fix race with DML errors .. Patch Set 1: I'm still in the process of testing this but wanted to get

[Impala-ASF-CR] IMPALA-7058: disable fuzz test for RC and Seq

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10485 ) Change subject: IMPALA-7058: disable fuzz test for RC and Seq .. IMPALA-7058: disable fuzz test for RC and Seq There

[Impala-ASF-CR] IMPALA-7058: disable fuzz test for RC and Seq

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10485 ) Change subject: IMPALA-7058: disable fuzz test for RC and Seq .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10489 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Patch Set 4: Code-Review+1 This makes sense

[Impala-ASF-CR] Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-23 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10489 to look at the new patch set (#3). Change subject: Trimming build-all-flag-combinations and adding minicluster profile.

[Impala-ASF-CR] Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10489 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10489 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Patch Set 4: > This makes sense to me.

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10480/1/buildall.sh File

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-23 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#16). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10489 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Patch Set 4: Build started:

[Impala-ASF-CR] Trimming build-all-flag-cobinations and adding minicluster profile.

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10489 ) Change subject: Trimming build-all-flag-cobinations and adding minicluster profile. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10489 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10487 ) Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes. .. Patch Set 2: Verified+1 --

[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10487 ) Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes. .. IMPALA-7063: Fix

[Impala-ASF-CR] IMPALA-5392: Added all stack frames to ThreadInfo summary.

2018-05-23 Thread Abhishek Sharma (Code Review)
Abhishek Sharma has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 ) Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. .. Patch Set 10: > (1 comment) Hi Jim, in the original

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 10: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6953: part 2: clean up DiskIoMgr

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10479 ) Change subject: IMPALA-6953: part 2: clean up DiskIoMgr .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-05-23 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-05-23 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. IMPALA-6802 (part 4): Clean up authorization tests The fourth part

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 ) Change subject: IMPALA-7055: fix race with DML errors .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7067: deflake test cancellation

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10499 ) Change subject: IMPALA-7067: deflake test_cancellation .. Patch Set 1: Running tests to make sure that it works. -- To view, visit

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 ) Change subject: IMPALA-7055: fix race with DML errors .. Patch Set 3: Hit IMPALA-7067. Will hold off on merging in case this patch

[Impala-ASF-CR] IMPALA-7067: deflake test cancellation

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10499 ) Change subject: IMPALA-7067: deflake test_cancellation .. Patch Set 1: Build started:

[Impala-ASF-CR](2.x) IMPALA-6131: Track time of last statistics update in metadata

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10484 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. IMPALA-6131: Track time of last

[Impala-ASF-CR](2.x) IMPALA-6131: Track time of last statistics update in metadata

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10484 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 1: Verified+1 -- To view, visit

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-23 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10496 Change subject: Bump libunwind version to 1.3-rc1 .. Bump libunwind version to 1.3-rc1 This changes bumps libunwind to version 1.3-rc1,

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10483 ) Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 3: hit IMPALA-7058 -- To view, visit

[Impala-ASF-CR](2.x) Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-23 Thread Philip Zeyliger (Code Review)
Hello Joe McDonnell, Tim Armstrong, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10497 to review the following change. Change subject: Trimming build-all-flag-combinations and adding minicluster profile.

[Impala-ASF-CR](2.x) Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10497 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Patch Set 1: Build started:

[Impala-ASF-CR] PREVIEW: IMPALA-110 (part 1): Refactor PartitionedAggregationNode

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: PREVIEW: IMPALA-110 (part 1): Refactor PartitionedAggregationNode .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 16: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4025: Part 2: Add percentile disc aggregation function

2018-05-23 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/9777 ) Change subject: IMPALA-4025: Part 2: Add percentile_disc aggregation function .. IMPALA-4025: Part 2: Add percentile_disc aggregation

[Impala-ASF-CR] [DOCS] Added a link to impala kerberos doc in impala-shell options doc

2018-05-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10482 ) Change subject: [DOCS] Added a link to impala kerberos doc in impala-shell options doc .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10489 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Trimming

[Impala-ASF-CR] Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10489 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Patch Set 4: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 ) Change subject: IMPALA-7055: fix race with DML errors .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4025: Part 2: Add percentile disc aggregation function

2018-05-23 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/9777 ) Change subject: IMPALA-4025: Part 2: Add percentile_disc aggregation function .. IMPALA-4025: Part 2: Add percentile_disc aggregation

[Impala-ASF-CR] IMPALA-4025: Part 3: Add percentile cont & median aggregation functions

2018-05-23 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/9778 ) Change subject: IMPALA-4025: Part 3: Add percentile_cont & median aggregation functions .. IMPALA-4025: Part 3: Add percentile_cont &

[Impala-ASF-CR] IMPALA-4025: Part 1: Generalize and cleanup StmtRewriter

2018-05-23 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10495 Change subject: IMPALA-4025: Part 1: Generalize and cleanup StmtRewriter .. IMPALA-4025: Part 1: Generalize and cleanup StmtRewriter

[Impala-ASF-CR] [DOCS] Added a link to impala kerberos doc in impala-shell options doc

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10482 ) Change subject: [DOCS] Added a link to impala kerberos doc in impala-shell options doc .. Patch Set 1: Build started:

[Impala-ASF-CR] [DOCS] Added a link to impala kerberos doc in impala-shell options doc

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10482 ) Change subject: [DOCS] Added a link to impala kerberos doc in impala-shell options doc .. [DOCS] Added a link to

[Impala-ASF-CR] [DOCS] Added a link to impala kerberos doc in impala-shell options doc

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10482 ) Change subject: [DOCS] Added a link to impala kerberos doc in impala-shell options doc .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR](2.x) IMPALA-6131: Track time of last statistics update in metadata

2018-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10484 Change subject: IMPALA-6131: Track time of last statistics update in metadata .. IMPALA-6131: Track time of last statistics update in

[Impala-ASF-CR] IMPALA-7048: Failed test: test write index many columns tables

2018-05-23 Thread Zoltan Borok-Nagy (Code Review)
Hello Thomas Marshall, Lars Volker, Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10476 to look at the new patch set (#2). Change subject: IMPALA-7048: Failed test: test_write_index_many_columns_tables

[Impala-ASF-CR] IMPALA-5392: Added all stack frames to ThreadInfo summary.

2018-05-23 Thread Abhishek Sharma (Code Review)
Abhishek Sharma has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 ) Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. .. Patch Set 10: Hi Jim, Please ignore the last

[Impala-ASF-CR] IMPALA-7048: Failed test: test write index many columns tables

2018-05-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10476 ) Change subject: IMPALA-7048: Failed test: test_write_index_many_columns_tables .. Patch Set 2: Code-Review+2 (1 comment) Thanks,

[Impala-ASF-CR] IMPALA-7048: Failed test: test write index many columns tables

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10476 ) Change subject: IMPALA-7048: Failed test: test_write_index_many_columns_tables .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 ) Change subject: IMPALA-7055: fix race with DML errors .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 11: The job hit a weird crash, need to investigate more:

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-23 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10488 to look at the new patch set (#2). Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6953: part 2: clean up DiskIoMgr

2018-05-23 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10479 to look at the new patch set (#3). Change subject: IMPALA-6953: part 2: clean up DiskIoMgr ..

[Impala-ASF-CR] IMPALA-6953: part 2: clean up DiskIoMgr

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10479 ) Change subject: IMPALA-6953: part 2: clean up DiskIoMgr .. Patch Set 3: Code-Review+2 Fix a clang-tidy error. Need to investigate the

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 ) Change subject: IMPALA-7055: fix race with DML errors .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 ) Change subject: IMPALA-7055: fix race with DML errors .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 2: Oh, that's not nearly as bad as I

[Impala-ASF-CR] PREVIEW: IMPALA-110 (part 1): Refactor PartitionedAggregationNode

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: PREVIEW: IMPALA-110 (part 1): Refactor PartitionedAggregationNode .. Patch Set 1: (7 comments) I did a quick pass,

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10447 ) Change subject: IMPALA-7061: Rework HBase splitting and assignment .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-23 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10447 to look at the new patch set (#7). Change subject: IMPALA-7061: Rework HBase splitting and assignment

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 ) Change subject: IMPALA-7055: fix race with DML errors .. Patch Set 1: Code-Review+2 (1 comment) Thanks for taking care of that Tim. It

[Impala-ASF-CR](2.x) IMPALA-6131: Track time of last statistics update in metadata

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10484 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 11: It's probably one of these java udf queries 06:40:15 [gw1]

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 ) Change subject: IMPALA-7055: fix race with DML errors .. Patch Set 1: (2 comments) Maybe take another look to make sure that my

[Impala-ASF-CR] IMPALA-7055: fix race with DML errors

2018-05-23 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10491 to look at the new patch set (#2). Change subject: IMPALA-7055: fix race with DML errors ..

[Impala-ASF-CR] [DOCS] Sentry is required for Impala to enable delegation

2018-05-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10451 ) Change subject: [DOCS] Sentry is required for Impala to enable delegation .. Patch Set 2: Is there a JIRA that states that delegation

[Impala-ASF-CR](2.x) IMPALA-6131: Track time of last statistics update in metadata

2018-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10484 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 1: The commit on master (

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-05-23 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 1: (11 comments) Taking this over since Adam is out.

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-05-23 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 15: (3 comments)

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10447 ) Change subject: IMPALA-7061: Rework HBase splitting and assignment .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-23 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10447 to look at the new patch set (#5). Change subject: IMPALA-7061: Rework HBase splitting and assignment ..

[Impala-ASF-CR](2.x) IMPALA-6131: Track time of last statistics update in metadata

2018-05-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10484 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7048: Failed test: test write index many columns tables

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10476 ) Change subject: IMPALA-7048: Failed test: test_write_index_many_columns_tables .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10487 Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes. .. IMPALA-7063: Fix compilation for

[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10487 ) Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes. .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10483 ) Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-23 Thread Lars Volker (Code Review)
Hello Thomas Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10483 to look at the new patch set (#2). Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size

[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10487 ) Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes. .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10487 ) Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes. .. Patch Set 2: Code-Review+2 Carrying

[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10487 ) Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10486 ) Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive .. Patch Set 1: (1 comment) Is this a breaking

[Impala-ASF-CR] IMPALA-7058: disable fuzz test for RC and Seq

2018-05-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10485 Change subject: IMPALA-7058: disable fuzz test for RC and Seq .. IMPALA-7058: disable fuzz test for RC and Seq There appear to still

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10486 Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive .. IMPALA-7060: Restrict Impala to only

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-23 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/10486 ) Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-7058: disable fuzz test for RC and Seq

2018-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10485 ) Change subject: IMPALA-7058: disable fuzz test for RC and Seq .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7058: disable fuzz test for RC and Seq

2018-05-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10485 ) Change subject: IMPALA-7058: disable fuzz test for RC and Seq .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-23 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10483 ) Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size .. Patch Set 1: (2 comments)

  1   2   >