[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-25 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#15). Change subject: IMPALA-5706: Spilling sort optimisations

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Rahul Shivu Mahadev (Code Review)
Rahul Shivu Mahadev has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 3: Run changes with

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-25 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. IMPALA-3307: Add support for IANA time-zone db Impala currently uses

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-25 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 9: > > Uploaded patch set 9. > > Patch -set 9 contains

[Impala-ASF-CR](2.x) Ignore IMPALA-6131 which has already been picked

2018-05-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10516 Change subject: Ignore IMPALA-6131 which has already been picked .. Ignore IMPALA-6131 which has already been picked IMPALA-6131 was

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-25 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. IMPALA-3307: Add support for IANA time-zone db Impala currently uses

[Impala-ASF-CR](2.x) Ignore IMPALA-6131 which has already been picked

2018-05-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10516 ) Change subject: Ignore IMPALA-6131 which has already been picked .. Patch Set 1: Verified+1 Ran "python -m json.tool

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 9: > > > Uploaded patch set 9. > > > > Patch -set 9

[Impala-ASF-CR] [DOCS] Fixed an inconsistent table ordering recommendations with STRAIGHT JOIN

2018-05-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10519 Change subject: [DOCS] Fixed an inconsistent table ordering recommendations with STRAIGHT_JOIN .. [DOCS] Fixed an inconsistent table

[Impala-ASF-CR] IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs

2018-05-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10520 Change subject: IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs .. IMPALA-5642: [DOCS] An additional restriction for

[Impala-ASF-CR] [DOCS] Correct info about REGEXP

2018-05-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10518 Change subject: [DOCS] Correct info about REGEXP .. [DOCS] Correct info about REGEXP Change-Id:

[Impala-ASF-CR] [DOCS] Correct info about REGEXP

2018-05-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10518 ) Change subject: [DOCS] Correct info about REGEXP .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10518

[Impala-ASF-CR] [DOCS] Correct info about REGEXP

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10518 ) Change subject: [DOCS] Correct info about REGEXP .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-05-25 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: > It looks like there's some history here, but can we make

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-25 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. IMPALA-3307: Add support for IANA time-zone db Impala currently uses

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 15: > (2 comments) > > > Do we have sufficient test

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 6: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 1: (1 comment) Looks fine.

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Rahul Shivu Mahadev (Code Review)
Rahul Shivu Mahadev has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Rahul Shivu Mahadev (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10490 to look at the new patch set (#4). Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 3: Code-Review+2 Rebase. Carry +2. --

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10517 Change subject: IMPALA-7071: make get_fs_path() idempotent .. IMPALA-7071: make get_fs_path() idempotent This avoids future errors like

[Impala-ASF-CR] IMPALA-6933: Avoids db name collisions for Kudu tests

2018-05-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10513 ) Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests .. Patch Set 1: We had a long out of band discussion about this

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) Ignore IMPALA-6131 which has already been picked

2018-05-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed Thomas Marshall from this change. ( http://gerrit.cloudera.org:8080/10516 ) Change subject: Ignore IMPALA-6131 which has already been picked .. Removed reviewer Thomas Marshall. -- To view, visit

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread Dan Hecht (Code Review)
Hello Michael Brown, Sailesh Mukil, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10517 to look at the new patch set (#2). Change subject: IMPALA-7071: make get_fs_path() idempotent

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread Dan Hecht (Code Review)
Hello Michael Brown, Sailesh Mukil, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10517 to look at the new patch set (#3). Change subject: IMPALA-7071: make get_fs_path() idempotent

[Impala-ASF-CR] [DOCS] Complex types in DDL not supported for text format files

2018-05-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10508 ) Change subject: [DOCS] Complex types in DDL not supported for text format files .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Complex types in DDL not supported for text format files

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10508 ) Change subject: [DOCS] Complex types in DDL not supported for text format files .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 6: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6933: Avoids db name collisions for Kudu tests

2018-05-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10513 ) Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests .. Patch Set 1: went with the pid idea so to distinguish the

[Impala-ASF-CR] [DOCS] Complex types in DDL not supported for text format files

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10508 ) Change subject: [DOCS] Complex types in DDL not supported for text format files .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] [DOCS] Complex types in DDL not supported for text format files

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10508 ) Change subject: [DOCS] Complex types in DDL not supported for text format files .. [DOCS] Complex types in DDL not

[Impala-ASF-CR](2.x) Ignore IMPALA-6131 which has already been picked

2018-05-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10516 ) Change subject: Ignore IMPALA-6131 which has already been picked .. Ignore IMPALA-6131 which has already been picked

[Impala-ASF-CR] IMPALA-6933: Avoids db name collisions for Kudu tests

2018-05-25 Thread Vuk Ercegovac (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10513 to look at the new patch set (#2). Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests ..

[Impala-ASF-CR](2.x) Ignore IMPALA-6131 which has already been picked

2018-05-25 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10516 ) Change subject: Ignore IMPALA-6131 which has already been picked .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7079: Disable the multiple blocks test in erasure coding build

2018-05-25 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10521 Change subject: IMPALA-7079: Disable the multiple blocks test in erasure coding build .. IMPALA-7079: Disable the multiple blocks

[Impala-ASF-CR] IMPALA-7079: Disable the multiple blocks test in erasure coding build

2018-05-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10521 ) Change subject: IMPALA-7079: Disable the multiple blocks test in erasure coding build .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7079: Disable the multiple blocks test in erasure coding build

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10521 ) Change subject: IMPALA-7079: Disable the multiple blocks test in erasure coding build .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5502: [DOCS] Removed JDBC and ODBC connectors without a context

2018-05-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10522 Change subject: IMPALA-5502: [DOCS] Removed JDBC and ODBC connectors without a context .. IMPALA-5502: [DOCS] Removed JDBC and ODBC

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. IMPALA-4970: Record identity

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-25 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#16). Change subject: IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 15: > Could you file a JIRA for that? We probably

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-05-25 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 13: This change did not cherrypick successfully into

[Impala-ASF-CR] IMPALA-7079: Disable the multiple blocks test in erasure coding build

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10521 ) Change subject: IMPALA-7079: Disable the multiple blocks test in erasure coding build .. IMPALA-7079: Disable the

[Impala-ASF-CR] IMPALA-7079: Disable the multiple blocks test in erasure coding build

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10521 ) Change subject: IMPALA-7079: Disable the multiple blocks test in erasure coding build .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] [DOCS] Correct info about REGEXP

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10518 ) Change subject: [DOCS] Correct info about REGEXP .. [DOCS] Correct info about REGEXP Change-Id:

[Impala-ASF-CR] [DOCS] Correct info about REGEXP

2018-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10518 ) Change subject: [DOCS] Correct info about REGEXP .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5392: Added all stack frames to ThreadInfo summary.

2018-05-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 ) Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. .. Patch Set 10: Code-Review-2 Unfortunately, we cannot merge

[Impala-ASF-CR] IMPALA-6933: Avoids db name collisions for Kudu tests

2018-05-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10513 Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests .. IMPALA-6933: Avoids db name collisions for Kudu tests Kudu

[Impala-ASF-CR] IMPALA-6020: [DOCS] REFRESH statement cannot detect HDFS block movement

2018-05-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10470 ) Change subject: IMPALA-6020: [DOCS] REFRESH statement cannot detect HDFS block movement .. Patch Set 1: I filed this, but I can't, for