[Impala-ASF-CR] IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord()

2023-04-10 Thread Anonymous Coward (Code Review)
Hello Quanlong Huang, Yifan Zhang, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19621 to look at the new patch set (#3). Change subject: IMPALA-11998: Fix potential invalid iterator issue in

[Impala-ASF-CR] IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord()

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19621 ) Change subject: IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord() .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord()

2023-04-10 Thread Anonymous Coward (Code Review)
18770832...@163.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/19621 ) Change subject: IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord() .. Patch Set 2: (3

[Impala-ASF-CR] IMPALA-7942 (part 2): Add query hints for predicate selectivities

2023-04-10 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18023 ) Change subject: IMPALA-7942 (part 2): Add query hints for predicate selectivities .. Patch Set 29: (1 comment)

[Impala-ASF-CR] IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts

2023-04-10 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/19682 ) Change subject: IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-12039 (addendum): Verify presence of pgrep during docker build

2023-04-10 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19713 ) Change subject: IMPALA-12039 (addendum): Verify presence of pgrep during docker build .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12008: Fix incorrect end time in DML profiles

2023-04-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19644 ) Change subject: IMPALA-12008: Fix incorrect end time in DML profiles .. Patch Set 3: Code-Review+1 This code looks good to me. I have

[Impala-ASF-CR] IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord()

2023-04-10 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19621 ) Change subject: IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord() .. Patch Set 3: -Code-Review hit

[Impala-ASF-CR] IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19682 ) Change subject: IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts .. Patch Set 8:

[Impala-ASF-CR] IMPALA-12039 (addendum): Verify presence of pgrep during docker build

2023-04-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19713 ) Change subject: IMPALA-12039 (addendum): Verify presence of pgrep during docker build .. Patch Set 1: The rocky8.5 dockerised job

[Impala-ASF-CR] IMPALA-12039 (addendum): Verify presence of pgrep during docker build

2023-04-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19713 ) Change subject: IMPALA-12039 (addendum): Verify presence of pgrep during docker build .. Patch Set 1: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts

2023-04-10 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19682 ) Change subject: IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord()

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19621 ) Change subject: IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord() .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-12008: Fix incorrect end time in DML profiles

2023-04-10 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19644 ) Change subject: IMPALA-12008: Fix incorrect end time in DML profiles .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12039 (addendum): Verify presence of pgrep during docker build

2023-04-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19713 Change subject: IMPALA-12039 (addendum): Verify presence of pgrep during docker build .. IMPALA-12039 (addendum): Verify presence of

[Impala-ASF-CR] IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord()

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19621 ) Change subject: IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord() .. Patch Set 3:

[Impala-ASF-CR] IMPALA-12039 (addendum): Verify presence of pgrep during docker build

2023-04-10 Thread Michael Smith (Code Review)
Michael Smith has removed a vote on this change. Change subject: IMPALA-12039 (addendum): Verify presence of pgrep during docker build .. Removed Code-Review+2 by Michael Smith -- To view, visit

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-12045: Strip ANSI escape sequences for JUnitXML

2023-04-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19708 ) Change subject: IMPALA-12045: Strip ANSI escape sequences for JUnitXML .. IMPALA-12045: Strip ANSI escape sequences for

[Impala-ASF-CR] IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19682 ) Change subject: IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts .. Patch Set 8: Build

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Joe McDonnell, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19712 to look at the new patch set (#2). Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

[Impala-ASF-CR] IMPALA-12039 (addendum): Verify presence of pgrep during docker build

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19713 ) Change subject: IMPALA-12039 (addendum): Verify presence of pgrep during docker build .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 2: > Patch Set 2: Verified-1 > >

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts

2023-04-10 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/19682 ) Change subject: IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 5: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. IMPALA-12043: Fix

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Joe McDonnell, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19712 to look at the new patch set (#3). Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 4: (7 comments) Patch set 4 run

[Impala-ASF-CR] IMPALA-12039 (addendum): Verify presence of pgrep during docker build

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19713 ) Change subject: IMPALA-12039 (addendum): Verify presence of pgrep during docker build .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord()

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19621 ) Change subject: IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord() .. Patch Set 3:

[Impala-ASF-CR](asf-site) Add 4.1.2 change log

2023-04-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19657 ) Change subject: Add 4.1.2 change log .. Patch Set 1: Ignored the test failure since it doesn't handle the web site changes. -- To

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 3: Patch set 3 adds both

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Joe McDonnell, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19712 to look at the new patch set (#4). Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

[Impala-ASF-CR] IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord()

2023-04-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19621 ) Change subject: IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord() .. Patch Set 4: Code-Review+1

[Impala-ASF-CR] IMPALA-7942 (part 2): Add query hints for predicate selectivities

2023-04-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18023 ) Change subject: IMPALA-7942 (part 2): Add query hints for predicate selectivities .. Patch Set 29: (1 comment)

[Impala-ASF-CR] IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord()

2023-04-10 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19621 ) Change subject: IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord() .. Patch Set 4: Code-Review+2 --

[Impala-ASF-CR] IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord()

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19621 ) Change subject: IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord() .. Patch Set 4: Build

[Impala-ASF-CR] IMPALA-12039 (addendum): Verify presence of pgrep during docker build

2023-04-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19713 ) Change subject: IMPALA-12039 (addendum): Verify presence of pgrep during docker build .. IMPALA-12039 (addendum): Verify

[Impala-ASF-CR] IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI

2023-04-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 ) Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI .. Patch Set 2: > Patch Set 2: > > > Patch Set

[Impala-ASF-CR] IMPALA-11057: Speed up hex int function

2023-04-10 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18091 ) Change subject: IMPALA-11057: Speed up hex_int function .. Patch Set 8: @morningman - are you still pursuing this change? We would

[Impala-ASF-CR] IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts

2023-04-10 Thread Aman Sinha (Code Review)
Hello Quanlong Huang, Kurt Deschler, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19682 to look at the new patch set (#7). Change subject: IMPALA-12006: Improve cardinality estimation for joins involving multiple

[Impala-ASF-CR] IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts

2023-04-10 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/19682 ) Change subject: IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19682 ) Change subject: IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts .. Patch Set 7: Build

[Impala-ASF-CR] IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord()

2023-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19621 ) Change subject: IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord() .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord()

2023-04-10 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19621 ) Change subject: IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord() .. Patch Set 3: Code-Review+1 --

[Impala-ASF-CR] IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts

2023-04-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19682 ) Change subject: IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts .. Patch Set 6: Code-Review+1

[Impala-ASF-CR] IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts

2023-04-10 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19682 ) Change subject: IMPALA-12006: Improve cardinality estimation for joins involving multiple conjuncts .. Patch Set 6: (1 comment)