[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. IMPALA-12925: Fix decimal data type for external JDBC

[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. Patch Set 10: Thanks Abhishek and Michael. -- To view,

[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. Patch Set 10: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. Patch Set 10: Hit irrelevant IMPALA-11285. Try yo rerun

[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21171 ) Change subject: IMPALA-12905: Disk-based tuple caching .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-04-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21171 ) Change subject: IMPALA-12905: Disk-based tuple caching .. Patch Set 6: (13 comments)

[Impala-ASF-CR] IMPALA-12905: Disk-based tuple caching

2024-04-04 Thread Joe McDonnell (Code Review)
Hello Kurt Deschler, Yida Wu, Alexey Serbin, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21171 to look at the new patch set (#7). Change subject: IMPALA-12905: Disk-based tuple caching

[Impala-ASF-CR] IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

2024-04-04 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21236 to look at the new patch set (#4). Change subject: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

[Impala-ASF-CR] IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21236 ) Change subject: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables .. Patch Set 5:

[Impala-ASF-CR] IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21236 ) Change subject: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables .. Patch Set 3:

[Impala-ASF-CR] IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

2024-04-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21236 ) Change subject: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12969: Release JNI array if DeserializeThriftMsg failed

2024-04-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21234 ) Change subject: IMPALA-12969: Release JNI array if DeserializeThriftMsg failed .. IMPALA-12969: Release JNI array if

[Impala-ASF-CR] IMPALA-12152: Add query option to wait for events sync up

2024-04-04 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20131 ) Change subject: IMPALA-12152: Add query option to wait for events sync up .. Patch Set 14: (1 comment) Thank Michael for reviewing

[Impala-ASF-CR] IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

2024-04-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21236 ) Change subject: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables .. Patch Set 5: Code-Review+2

[Impala-ASF-CR] IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21236 ) Change subject: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables .. Patch Set 4:

[Impala-ASF-CR] [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-04-04 Thread Anonymous Coward (Code Review)
pranav.lo...@cloudera.com has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/21131 ) Change subject: [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters ..

[Impala-ASF-CR] [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 4: Build

[Impala-ASF-CR] [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 4: (3

[Impala-ASF-CR] [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 4: Build

[Impala-ASF-CR] IMPALA-12960: Fix Incorrect RowsPassedThrough Metric in Streaming Aggregation

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21235 ) Change subject: IMPALA-12960: Fix Incorrect RowsPassedThrough Metric in Streaming Aggregation .. Patch Set 1: Verified+1 --

[Impala-ASF-CR] [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-04-04 Thread Anonymous Coward (Code Review)
pranav.lo...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 4: >

[Impala-ASF-CR] IMPALA-12960: Fix Incorrect RowsPassedThrough Metric in Streaming Aggregation

2024-04-04 Thread Yida Wu (Code Review)
Yida Wu has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21235 ) Change subject: IMPALA-12960: Fix Incorrect RowsPassedThrough Metric in Streaming Aggregation .. IMPALA-12960: Fix Incorrect

[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. IMPALA-12925: Fix decimal data type for external JDBC table

[Impala-ASF-CR] IMPALA-12925: Fix decimal data type for external JDBC table

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 ) Change subject: IMPALA-12925: Fix decimal data type for external JDBC table .. Patch Set 9: Build Successful

[Impala-ASF-CR] [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 4: Verified+1

[Impala-ASF-CR] IMPALA-12960: Fix Incorrect RowsPassedThrough Metric in Streaming Aggregation

2024-04-04 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21235 ) Change subject: IMPALA-12960: Fix Incorrect RowsPassedThrough Metric in Streaming Aggregation .. Patch Set 1: Thanks Riza and Wenzhe for

[Impala-ASF-CR] IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

2024-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21236 ) Change subject: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables .. Patch Set 5:

[Impala-ASF-CR] IMPALA-5323: Support BINARY columns in Kudu tables

2024-04-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18868 ) Change subject: IMPALA-5323: Support BINARY columns in Kudu tables .. Patch Set 7: (3 comments) Looks good, thanks.