[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. IMPALA-6508: add KRPC test flag This change adds a flag "--use_krpc"

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dry

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9291 To

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 10: (1 comment) Thanks for the reviews. Please see PS10. http://gerrit.clo

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#10). Change subject: IMPALA-6508: add KRPC test flag

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 9: Code-Review+1 (1 comment) Feel free to carry forward my +1 after fixin

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 9: (3 comments) Thanks for the reviews, please see PS9. http://gerrit.clou

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#9). Change subject: IMPALA-6508: add KRPC test flag .

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/9291/5/tests/common/cus

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 8: Michael and/or David may want to do another pass and +2 the change. -- T

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/9291/8/test

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/9291/7/bin/start-impala

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-14 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#8). Change subject: IMPALA-6508: add KRPC test flag .

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/9291/7/bin/start-impala-

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 7: > Patch Set 7: > > David, it'd be great if you also had time for a look h

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 7: David, it'd be great if you also had time for a look here. Thanks :) --

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 7: I ran private core and exhaustive tests and added skips for tests that di

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#7). Change subject: IMPALA-6508: add KRPC test flag .. IM

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9291/5/tests/common/cust

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#6). Change subject: IMPALA-6508: add KRPC test flag .. IM

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 5: (2 comments) > This means we will have automated test runs with both k

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 5: (3 comments) > Patch Set 5: > > (3 comments) > > I was trying to think a

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 5: (3 comments) I was trying to think about how this could be done withou

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 4: (4 comments) Thanks for the review, please see my inline comments and PS

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-12 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#5). Change subject: IMPALA-6508: add KRPC test flag .. IM

[Impala-ASF-CR] IMPALA-6508: add krpc test flag

2018-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add krpc test flag .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/9291/4/bin/start-impala-

[Impala-ASF-CR] IMPALA-6508: add krpc test flag

2018-02-12 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#4). Change subject: IMPALA-6508: add krpc test flag .. IM