[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 15: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. IMPALA-7658: Proper codegen for HiveUdfCall

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 14: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 15: Build started:

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 14: Build Successful

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-03 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 14: (2 comments)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-03 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. IMPALA-7658: Proper codegen for HiveUdfCall Implementing codegen for

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-03 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 13: (2 comments) LGTM pending these 2 comments

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 13: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-02 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 13: (5 comments)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-09-02 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. IMPALA-7658: Proper codegen for HiveUdfCall Implementing codegen for

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 12: Code-Review+1 (5 comments) Only nits and small

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-26 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. IMPALA-7658: Proper codegen for HiveUdfCall Implementing codegen for

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-26 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. IMPALA-7658: Proper codegen for HiveUdfCall Implementing codegen for

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 10: (1 comment) I started an exhaustive test, I agree that

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 10: Code-Review+2 (2 comments) I'm happy with this modulo

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-25 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. IMPALA-7658: Proper codegen for HiveUdfCall Implementing codegen for

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-25 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 10: (4 comments)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 8: (6 comments)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-24 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. IMPALA-7658: Proper codegen for HiveUdfCall Implementing codegen for

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-14 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. IMPALA-7658: Proper codegen for HiveUdfCall Implementing codegen for

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 6: Build Failed

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-14 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. IMPALA-7658: Proper codegen for HiveUdfCall Implementing codegen for

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 5: Build Failed

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-12 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. IMPALA-7658: Proper codegen for HiveUdfCall Implementing codegen for

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-12 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 4: (1 comment) Added benchmark results on Jira.

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 4: I took a pass over this, just treating as a WIP. The

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-10 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. IMPALA-7658: Proper codegen for HiveUdfCall Implementing codegen for

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-08 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16314 Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. IMPALA-7658: Proper codegen for HiveUdfCall Implementing codegen for