[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-10 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (4 comments) http://gerrit.cloudera.org:8080/#/c/4144/14/fe/s

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-10 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#16). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTIT

[Impala-ASF-CR] IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo

2016-10-10 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#6). Change subject: IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo .. IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo This change removes some of the occurrences of t

[Impala-ASF-CR] IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo

2016-10-10 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#7). Change subject: IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo .. IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo This change removes some of the occurrences of t

[Impala-ASF-CR] IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo

2016-10-10 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#8). Change subject: IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo .. IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo This change removes some of the occurrences of t

[Impala-ASF-CR] IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo

2016-10-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4187/5/tests/comparison/cluster.py File t

[Impala-ASF-CR] IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo

2016-10-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo .. Patch Set 8: Thanks everyone for following this. I would like to ask everyone for a final pass with th

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/4144

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we simpli

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 3: (23 comments) http://gerrit.cloudera.org:8080/#/c/4414/3/common/thrift/Ca

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4651/1/be/src/exec/aggregation-node.cc

[Impala-ASF-CR] IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo

2016-10-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/4187/8/be/src/util/redactor.detail.h File

[Impala-ASF-CR] IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo

2016-10-10 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#9). Change subject: IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo .. IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo This change removes some of the occurrences of t

[Impala-ASF-CR] IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo

2016-10-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/4187/8/be/src/util/redactor.detail.h Fil

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/4144/14/fe/src/

[Impala-ASF-CR] IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo

2016-10-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4187 To unsubscribe, visit

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

2016-10-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. Patch Set 1: (4 comments) Thanks, Todd. Can you ref IMPALA-4134 in the commit comment? http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-2789: More compact mem layout with null bits at the end.

2016-10-10 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-2789: More compact mem layout with null bits at the end. .. IMPALA-2789: More compact mem layout with null bits at the end. The main motivation of this change i

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

2016-10-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4670/1/be/src/exec/kudu-table-sink.cc File be/src/exe

[Impala-ASF-CR] PREVIEW IMPALA-3644 Make predicate order deterministic

2016-10-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: PREVIEW IMPALA-3644 Make predicate order deterministic .. Patch Set 2: Is this still a preview of have tests passed? -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

2016-10-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4670/1/be/src/exec/kudu-table-sink.cc File be/src/

[Impala-ASF-CR] PREVIEW IMPALA-3644 Make predicate order deterministic

2016-10-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: PREVIEW IMPALA-3644 Make predicate order deterministic .. Patch Set 2: The tests have failed, there still seems to be more to fix. I added more comments to the Ji

[Impala-ASF-CR] IMPALA-2789: More compact mem layout with null bits at the end.

2016-10-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2789: More compact mem layout with null bits at the end. .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/4673/2/be/src/exec/hdfs-scanner

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4414/3/common/thrift/CatalogObj

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4414/3/common/thrift/Cata

[Impala-ASF-CR] IMPALA-4270: Gracefully fail unsupported queries with mt dop > 0.

2016-10-10 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4677 Change subject: IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. .. IMPALA-4270: Gracefully fail unsupported queries with m

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-10 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 14: (4 comments) thanks http://gerrit.cloudera.org:8080/#/c/4349/14/common/thrift/Cat

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-10 Thread Huaisi Xu (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4349 to look at the new patch set (#15). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis.

[Impala-ASF-CR] IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

2016-10-10 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4674/2/bin/bootstrap_development.sh

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support reading

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 7: (28 comments) http://gerrit.cloudera.org:8080/#/c/4494/7/be/src/benchmarks/bit-packing-benchmark.cc File be/src/

[Impala-ASF-CR] IMPALA-4231: fix codegen time regression

2016-10-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4231: fix codegen time regression .. IMPALA-4231: fix codegen time regression The commit "IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder" slightly

[Impala-ASF-CR] IMPALA-4231: fix codegen time regression

2016-10-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4231: fix codegen time regression .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4623/2/be/src/exec/partitioned-aggregation-node.h File

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-10 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/4678 Change subject: IMPALA-4188: Leopard: support external Docker volumes .. IMPALA-4188: Leopard: support external Docker volumes To be abl

[Impala-ASF-CR] Impala-3342 Adding thread counters to measure time spent during plan fragment execution

2016-10-10 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#2). Change subject: Impala-3342 Adding thread counters to measure time spent during plan fragment execution .. Impala-3342 Adding thread counters to measure time spent during plan fragme

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 4: (19 comments) http://gerrit.cloudera.org:8080/#/c/4414/4/fe/src/main/java/org/ap

[Impala-ASF-CR] IMPALA-1473: Incorrect cardinality in exec summary for exchange

2016-10-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/4679 Change subject: IMPALA-1473: Incorrect cardinality in exec summary for exchange .. IMPALA-1473: Incorrect cardinality in exec su

[Impala-ASF-CR] IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

2016-10-10 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment .. IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment This script bootstraps an Impala dev env

[Impala-ASF-CR] IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

2016-10-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4674/2/bin/bootstrap_development.sh F

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-10 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 15: > (3 comments) Should I do the same for other catalog object as well? e.g. data so

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 15: I'd prefer to not address that question in this patch because we'll just end up wi

[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-10 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#2). Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node .. IMPALA-3920: TotalStorageWaitTime counter not populated for fragments wit

[Impala-ASF-CR] IMPALA-4270: Gracefully fail unsupported queries with mt dop > 0.

2016-10-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4677/1/testdata/workloads