[Impala-ASF-CR] IMPALA-4434: In Python, ''.split('\n') is [''], which has length 1

2016-11-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4434: In Python, ''.split('\n') is [''], which has length 1 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5061 To

[Impala-ASF-CR] IMPALA-4434: In Python, ''.split('\n') is [''], which has length 1

2016-11-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4434: In Python, ''.split('\n') is [''], which has length 1 .. IMPALA-4434: In Python, ''.split('\n') is [''], which has length 1 This test

[Impala-ASF-CR] Increase wait times for startup of Hive and its Metastore

2016-11-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Increase wait times for startup of Hive and its Metastore .. Patch Set 2: Code-Review+2 rebase only; carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4436: StringValue::StringCompare() should match strncmp()

2016-11-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4436: StringValue::StringCompare() should match strncmp() .. Patch Set 3: Code-Review+2 Carry and promote Alex's +1. -- To view, visit

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-15 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#6). Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present This change

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add Parquet timestamp validation Before this patch, we would simply read the INT96 Parquet

[Impala-ASF-CR] Run MT DOP tests on all file formats.

2016-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Run MT_DOP tests on all file formats. .. Patch Set 2: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5025 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4436: StringValue::StringCompare() should match strncmp()

2016-11-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4436: StringValue::StringCompare() should match strncmp() .. IMPALA-4436: StringValue::StringCompare() should match strncmp() According to

[Impala-ASF-CR] IMPALA-4436: StringValue::StringCompare() should match strncmp()

2016-11-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4436: StringValue::StringCompare() should match strncmp() .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5083 To

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 6: Code-Review+2 (2 comments) +2 FE, +1 Catalog

[Impala-ASF-CR] Run MT DOP tests on all file formats.

2016-11-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Run MT_DOP tests on all file formats. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5025 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for

[Impala-ASF-CR] IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

2016-11-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0. .. Patch Set 2: (4 comments)

[Impala-ASF-CR] Preview: IMPALA-4467: Add support for CRUD operations in stress test

2016-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Preview: IMPALA-4467: Add support for CRUD operations in stress test .. Patch Set 1: (16 comments) Looks like it's going in the right direction. Most comments

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. Patch Set 1: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-4444: Transfer row group resources to row batch on scan failure

2016-11-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-: Transfer row group resources to row batch on scan failure .. IMPALA-: Transfer row group resources to row batch on scan failure

[Impala-ASF-CR] IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

2016-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0. .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

2016-11-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

2016-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0. .. Patch Set 4: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5050 To

[Impala-ASF-CR] Run MT DOP tests on all file formats.

2016-11-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Run MT_DOP tests on all file formats. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5025 To unsubscribe, visit

[Impala-ASF-CR] Run MT DOP tests on all file formats.

2016-11-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Run MT_DOP tests on all file formats. .. Run MT_DOP tests on all file formats. Change-Id: I28d5bcc48bbe32fb970b41daa919096061a05beb Reviewed-on:

[Impala-ASF-CR] clang-tidy should tidy tests; fix alignas error in clang builds.

2016-11-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: clang-tidy should tidy tests; fix alignas error in clang builds. .. clang-tidy should tidy tests; fix alignas error in clang builds.

[Impala-ASF-CR] IMPALA-4479: Use correct isSet() thrift function when evaluating constant bool exprs.

2016-11-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4479: Use correct isSet() thrift function when evaluating constant bool exprs. .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4434: In Python, ''.split('\n') is [''], which has length 1

2016-11-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4434: In Python, ''.split('\n') is [''], which has length 1 .. Patch Set 2: Code-Review+2 rebase only; carry +2 -- To view, visit

[Impala-ASF-CR] clang-tidy should tidy tests; fix alignas error in clang builds.

2016-11-15 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5094 Change subject: clang-tidy should tidy tests; fix alignas error in clang builds. .. clang-tidy should tidy tests; fix alignas error in clang

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-15 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#5). Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present This change

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-15 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. Patch Set 4: (9 comments)

[Impala-ASF-CR] IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

2016-11-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0. .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] Increase wait times for startup of Hive and its Metastore

2016-11-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Increase wait times for startup of Hive and its Metastore .. Increase wait times for startup of Hive and its Metastore On Ubuntu 14.04 on AWS EC2

[Impala-ASF-CR] Increase wait times for startup of Hive and its Metastore

2016-11-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Increase wait times for startup of Hive and its Metastore .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5068 To unsubscribe,