[Impala-ASF-CR] IMPALA-3079: Fix sequence file writer

2017-02-22 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new change for review. http://gerrit.cloudera.org:8080/6107 Change subject: IMPALA-3079: Fix sequence file writer .. IMPALA-3079: Fix sequence file writer Before the fix, sequence file writer

[Impala-ASF-CR] IMPALA-4848: Add WIDHT BUCKET() function

2017-02-22 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#2). Change subject: IMPALA-4848: Add WIDHT_BUCKET() function .. IMPALA-4848: Add WIDHT_BUCKET() function Change-Id: I081bc916b1bef7b929ca161a9aade3b54c6b858f --- M

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 21: Code-Review+2 (2 comments) Michael, can you take a final pass as well?

[Impala-ASF-CR] Three misc webpage changes

2017-02-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Three misc webpage changes .. Patch Set 1: Code-Review+1 seems fine but I don't really know jquery -- To view, visit http://gerrit.cloudera.org:8080/6045 To

[Impala-ASF-CR] IMPALA-4962: Fix SHOW COLUMN STATS for HS2

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4962: Fix SHOW COLUMN STATS for HS2 .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/292/ -- To view,

[Impala-ASF-CR] Three misc webpage changes

2017-02-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Three misc webpage changes .. Patch Set 1: The changes here seem reasonable. Is there a plan to migrate other HTML tables to DataTables? (E.g., Queries, Query

[Impala-ASF-CR] Three misc webpage changes

2017-02-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Three misc webpage changes .. Patch Set 1: Anyone want to take a quick look at this? -- To view, visit http://gerrit.cloudera.org:8080/6045 To unsubscribe,

[Impala-ASF-CR] IMPALA-4962: Fix SHOW COLUMN STATS for HS2

2017-02-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4962: Fix SHOW COLUMN STATS for HS2 .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6109/1/tests/hs2/test_fetch.py File

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#8). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4959: Avoid picking up the system's boost cmake module

2017-02-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4959: Avoid picking up the system's boost cmake module .. Patch Set 3: yup thanks for pinging about that, I just submitted it for gvm -- To view,

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-22 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#7). Change subject: IMPALA-2328: Read support for min/max Parquet statistics .. IMPALA-2328: Read support for min/max Parquet statistics This change adds support for skipping row

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2328: Read support for min/max Parquet statistics .. Patch Set 6: (14 comments) Thanks for the review. Please see PS7.

[Impala-ASF-CR] IMPALA-4959: Avoid picking up the system's boost cmake module

2017-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: IMPALA-4959: Avoid picking up the system's boost cmake module .. Patch Set 3: mj, alex: what's missing here? gvm run? not sure that'll do much -- To

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6025 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4959: Avoid picking up the system's boost cmake module

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4959: Avoid picking up the system's boost cmake module .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/293/

[Impala-ASF-CR] IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1"

2017-02-22 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1" .. Abandoned No contact from author in over 2 months -- To view, visit

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 21: (1 comment)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6025/6/be/src/exprs/aggregate-functions-ir.cc

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 21: (1 comment)

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/19/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#8). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-22 Thread Zach Amsden (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5951 to look at the new patch set (#22). Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts ..

[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ .. IMPALA-3406: [DOCS] Empty the original Cloudera FAQ Almost all of the original Impala

[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6003 To unsubscribe,

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 7: (7 comments) I'm pretty happy with this change

[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info

2017-02-22 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4962: Fix SHOW COLUMN STATS for HS2

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4962: Fix SHOW COLUMN STATS for HS2 .. IMPALA-4962: Fix SHOW COLUMN STATS for HS2 Impala incorrectly returned NULLs in the "Max Size"

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 1 of removing 'Cloudera Manager'

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 1 of removing 'Cloudera Manager' .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6049 To

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 1 of removing 'Cloudera Manager'

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3401 [DOCS] Phase 1 of removing 'Cloudera Manager' .. IMPALA-3401 [DOCS] Phase 1 of removing 'Cloudera Manager' Rewrote sections to

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 7: (40 comments) http://gerrit.cloudera.org:8080/#/c/5816/7/be/src/exec/analytic-eval-node.cc File

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#8). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches

[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/42/ -- To

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/21/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 22: Code-Review+2 Michael, any more comments? -- To view, visit

[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/44/ -- To

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 1 of removing 'Cloudera Manager'

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 1 of removing 'Cloudera Manager' .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/43/ --

[Impala-ASF-CR] IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3411 [DOCS] Rework Impala governance topics to be generic. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5957 To

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2328: Read support for min/max Parquet statistics .. Patch Set 7: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-22 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6032 to look at the new patch set (#8). Change subject: IMPALA-2328: Read support for min/max Parquet statistics ..

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 8: (9 comments)

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-22 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic .. Patch Set 5: (8 comments) Addressed all of John's comments.

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2328: Read support for min/max Parquet statistics .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6032 To

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2328: Read support for min/max Parquet statistics .. Patch Set 8: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/294/ --

[Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial

2017-02-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Patch references to Cloudera and CDH in Impala tutorial .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5663 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4624: Implement Parquet dictionary filtering

2017-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-4624: Implement Parquet dictionary filtering .. Patch Set 8: (31 comments) Addressed the review comments. I also added a query option

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2328: Read support for min/max Parquet statistics .. Patch Set 4: (1 comment) Thanks for the review. I addressed the remaining comments in PS8. There's

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-22 Thread Ambreen Kazi (Code Review)
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5962 to look at the new patch set (#6). Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

[Impala-ASF-CR] [DOCS] Release note updates for Impala 2.8

2017-02-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: [DOCS] Release note updates for Impala 2.8 .. Patch Set 9: Code-Review+2 As the RM for 2.8, I'm +2ing this. We can fix nits in follow-ups, but this will block 2.9

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-22 Thread Ambreen Kazi (Code Review)
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5962 to look at the new patch set (#7). Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

[Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial

2017-02-22 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: Patch references to Cloudera and CDH in Impala tutorial .. Patch Set 3: Code-Review+1 Looks good. -- To view, visit http://gerrit.cloudera.org:8080/5663 To

[Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal

2017-02-22 Thread Laurel Hale (Code Review)
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/6108 Change subject: IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal .. IMPALA-3401 [DOCS] Phase 7 of "Cloudera Manager" removal

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#8). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches

[Impala-ASF-CR] IMPALA-4848: Add WIDHT BUCKET() function

2017-02-22 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#3). Change subject: IMPALA-4848: Add WIDHT_BUCKET() function .. IMPALA-4848: Add WIDHT_BUCKET() function Change-Id: I081bc916b1bef7b929ca161a9aade3b54c6b858f --- M

[Impala-ASF-CR] IMPALA-3905: Implements HdfsScanner::GetNext() for text scans.

2017-02-22 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-3905: Implements HdfsScanner::GetNext() for text scans. .. IMPALA-3905: Implements HdfsScanner::GetNext() for text scans. Implements

[Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Patch references to Cloudera and CDH in Impala tutorial .. Patch references to Cloudera and CDH in Impala tutorial There was one tutorial that

[Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Patch references to Cloudera and CDH in Impala tutorial .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5663 To

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2328: Read support for min/max Parquet statistics .. Patch Set 9: PS9 addresses a clang-tidy error. -- To view, visit

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2328: Read support for min/max Parquet statistics .. Patch Set 10: Code-Review+2 PS10 is a rebase. Carrying Marcel's +2. -- To view, visit

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2328: Read support for min/max Parquet statistics .. Patch Set 10: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/295/ --

[Impala-ASF-CR] Three misc webpage changes

2017-02-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Three misc webpage changes .. Patch Set 1: Thanks for the reviews! > seems fine but I don't really know jquery If it makes it easier, this is basically C

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-22 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic .. Patch Set 7: Code-Review+1 I'm still getting some errors when it builds. Looks like there

[Impala-ASF-CR] Add .pep8rc for Impala's Python style

2017-02-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add .pep8rc for Impala's Python style .. Patch Set 1: Any news with this? -- To view, visit http://gerrit.cloudera.org:8080/5829 To unsubscribe, visit

[Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial

2017-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Patch references to Cloudera and CDH in Impala tutorial .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/46/ -- To