[Impala-ASF-CR] IMPALA-6011: Remove use of Guava Hasher.

2017-10-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8216 ) Change subject: IMPALA-6011: Remove use of Guava Hasher. .. Patch Set 2: Just getting back to this. For my own education, does it

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-09 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 14: Updated exec times: Existing TPC-DS

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-09 Thread Tim Wood (Code Review)
Hello Matthew Mulder, Michael Brown, David Knupp, Alex Behm, Mostafa Mokhtar, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8102 to look at the new patch set (#15). Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6011: Remove use of Guava Hasher.

2017-10-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8216 ) Change subject: IMPALA-6011: Remove use of Guava Hasher. .. Patch Set 2: Afaik these hashes are stored in Navigator and used for finding

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8233 ) Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors .. Patch Set 1: (1 comment) Agree with Phil's

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-10-09 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8023 to look at the new patch set (#3). Change subject: IMPALA-4856: Port data stream service to KRPC .. IMPALA-4856:

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-09 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 14: > Patch Set 14: > > Updated exec

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-10-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-09 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 15: > Uploaded patch set 15. Removed

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 ) Change subject: IMPALA-4236: Codegen CopyRows() for select nodes .. Patch Set 6: (2 comments) Your code looks good but I'd really

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-09 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 14: @Tim, Can you try rerunning

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8051 ) Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals .. Patch Set 2: (6 comments)

[Impala-ASF-CR] Download toolchain in parallel.

2017-10-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8237 Change subject: Download toolchain in parallel. .. Download toolchain in parallel. By downloading from the toolchain S3 buckets in

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-09 Thread Tianyi Wang (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8170 to look at the new patch set (#3). Change subject: IMPALA-5789: Add always_false flag in bloom filter

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-09 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-09 Thread Tim Wood (Code Review)
Hello Matthew Mulder, Michael Brown, David Knupp, Alex Behm, Mostafa Mokhtar, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8102 to look at the new patch set (#16). Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for

[Impala-ASF-CR] Download toolchain in parallel.

2017-10-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8237 ) Change subject: Download toolchain in parallel. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8237 To

[Impala-ASF-CR] Download toolchain in parallel.

2017-10-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8237 ) Change subject: Download toolchain in parallel. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8237

[Impala-ASF-CR] Download toolchain in parallel.

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8237 ) Change subject: Download toolchain in parallel. .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8147 ) Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-10-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8147 ) Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node .. Patch Set 7: Code-Review+2 -- To view,

[Impala-ASF-CR](asf-site) Remove old leftover, unmaintained parts of website.

2017-10-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8234 ) Change subject: Remove old leftover, unmaintained parts of website. .. Patch Set 1: Code-Review+2 Seems reasonable to me. -- To view,

[Impala-ASF-CR] IMPALA-5429: Multi threaded block metadata loading

2017-10-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8235 Change subject: IMPALA-5429: Multi threaded block metadata loading .. IMPALA-5429: Multi threaded block metadata loading

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-10-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException thrown by aggregate function.

2017-10-09 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 ) Change subject: IMPALA-4682 Fix IllegalStateException thrown by aggregate function. .. Patch Set 3: (2 comments) Please see the

[Impala-ASF-CR] IMPALA-4682: Remove Preconditions check from analyzeAggregation().

2017-10-09 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dimitris Tsirogiannis, anujphadke, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8143 to look at the new patch set (#4). Change subject: IMPALA-4682: Remove Preconditions check from analyzeAggregation().

[Impala-ASF-CR] IMPALA-6023: Fix broken breakpad test

2017-10-09 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8240 Change subject: IMPALA-6023: Fix broken breakpad test .. IMPALA-6023: Fix broken breakpad test We have a test to make sure that hitting a

[Impala-ASF-CR] IMPALA-4682: Remove Preconditions check from analyzeAggregation().

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 ) Change subject: IMPALA-4682: Remove Preconditions check from analyzeAggregation(). .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6016: Fix logging in TableLoadingMgr class

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8212 ) Change subject: IMPALA-6016: Fix logging in TableLoadingMgr class .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-10-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 14: Code-Review+2 This has 4 +1's

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-10-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8139 ) Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK') .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-09 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 16: > Uploaded patch set 16. Pytest

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 5: (1 comment)

[Impala-ASF-CR](asf-site) Remove old leftover, unmaintained parts of website.

2017-10-09 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8234 ) Change subject: Remove old leftover, unmaintained parts of website. .. Remove old leftover, unmaintained parts of website.

[Impala-ASF-CR](asf-site) Remove old leftover, unmaintained parts of website.

2017-10-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8234 ) Change subject: Remove old leftover, unmaintained parts of website. .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 ) Change subject: IMPALA-4236: Codegen CopyRows() for select nodes .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-10-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 ) Change subject: IMPALA-4236: Codegen CopyRows() for select nodes .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-10-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 ) Change subject: IMPALA-4236: Codegen CopyRows() for select nodes .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-09 Thread Vuk Ercegovac (Code Review)
Hello Philip Zeyliger, Balazs Jeszenszky, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8202 to look at the new patch set (#5). Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received.

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 5: latest patch fixes

[Impala-ASF-CR] Download toolchain in parallel.

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8237 ) Change subject: Download toolchain in parallel. .. Download toolchain in parallel. By downloading from the toolchain

[Impala-ASF-CR] Download toolchain in parallel.

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8237 ) Change subject: Download toolchain in parallel. .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8147 ) Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node .. IMPALA-5448: fix invalid

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8147 ) Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node .. Patch Set 7: Verified+1 -- To

[Impala-ASF-CR] IMPALA-5429: Multi threaded block metadata loading

2017-10-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8235 ) Change subject: IMPALA-5429: Multi threaded block metadata loading .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. IMPALA-5940: Avoid log spew by using

[Impala-ASF-CR] IMPALA-4682: Remove Preconditions check from analyzeAggregation().

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8143 ) Change subject: IMPALA-4682: Remove Preconditions check from analyzeAggregation(). .. IMPALA-4682: Remove

[Impala-ASF-CR] IMPALA-4682: Remove Preconditions check from analyzeAggregation().

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 ) Change subject: IMPALA-4682: Remove Preconditions check from analyzeAggregation(). .. Patch Set 4: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6016: Fix logging in TableLoadingMgr class

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8212 ) Change subject: IMPALA-6016: Fix logging in TableLoadingMgr class .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6016: Fix logging in TableLoadingMgr class

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8212 ) Change subject: IMPALA-6016: Fix logging in TableLoadingMgr class .. IMPALA-6016: Fix logging in TableLoadingMgr class

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-09 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 16: > Patch Set 16: > > > Uploaded

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-10-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8139 ) Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK') .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-3504: [DOCS] Document utc timestamp()

2017-10-09 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. ( http://gerrit.cloudera.org:8080/8190 ) Change subject: IMPALA-3504: [DOCS] Document utc_timestamp() .. Patch Set 2: (3 comments)